From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48DB9A04B5; Tue, 12 Jan 2021 02:15:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8FC5140D63; Tue, 12 Jan 2021 02:15:37 +0100 (CET) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id 2CDD8140D5C for <dev@dpdk.org>; Tue, 12 Jan 2021 02:15:36 +0100 (CET) Received: by mail-lf1-f46.google.com with SMTP id x20so796186lfe.12 for <dev@dpdk.org>; Mon, 11 Jan 2021 17:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+Ng9aQjRX6PST/TkFmvhltgGHR3uFWOCUEZoOs5/F0s=; b=P3eFScYErvIOuCZjk1Y7S9fEOLWwZZ6pkya86FldxtUMNgwL7pJKKpzMKNqIKRt937 lLK4jo2hbNpOyj+LffAuug1Qt/oT/O8K40ED+9PF2WJ1P4FWrCM2P4E8ISSHTE2F1Dmm mZT5QBQ6dhQNTXPHy2ZKGDwrDkMM9EQcdyKjS9FxE2qLlNV7TpkQx/5eB+KSBMTRgQV+ rSPzBbxSK+hnCW+247AHZtk06x7Kw7seHM76mYloftorL64gDhFmDdWKJVyQsfmX+otH EzdPUPuNoHMsOthQUPDUqmK3jHkDTN9+t5iF+H2A1ZQ8SAoOHPNUbybopXIqQQcnEIex MC4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+Ng9aQjRX6PST/TkFmvhltgGHR3uFWOCUEZoOs5/F0s=; b=bKtTQQkB1+pxi7By2ILPfDyrce0Rb7xj84eWP2WzMR37JyOhkhFiokRvXLYp4YcsNs wZ8DfwTjEzryH+IZVL2cWv7yF+hZnN5YnLaQfKbD0s11sgJCuqdccLBL7XNuK5Vhws+z XH2jZBB2EcNED+y5wUgb6jfsJASDO7e8HGJ4MxqXXgccaYGip2FXbeE94U8GFle0h+WC NNe94LIH5SkdS0vXvHBp3++lvfnYxHHv9zyznpSTAWkGrV3hvWck0dRs1ggPEnyHj9e5 SOGYrGFOFkj9s5aaT1Y5MNPJ08yDxwIa+f+5G+3BpDxmnDuK96EGEi1eHoBDJQgBZbCl vFXg== X-Gm-Message-State: AOAM531r8BfmWtBPz+CsiT3a+G45eZuArBNBnIinjKdchQY0IvmZGR8u Hvjn7GDVQDqX7hKoKkm37nU= X-Google-Smtp-Source: ABdhPJxoYlibeZVZiAk/bW3M7TrQF3KLLrW52mKAiyjDRiv+ndkuOC13WJUs/feryxIT88MHr6AYaw== X-Received: by 2002:a19:84f:: with SMTP id 76mr955357lfi.215.1610414135741; Mon, 11 Jan 2021 17:15:35 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id u5sm178776lfr.154.2021.01.11.17.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 17:15:35 -0800 (PST) Date: Tue, 12 Jan 2021 04:15:34 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Tyler Retzlaff <roretzla@linux.microsoft.com> Cc: dev@dpdk.org, thomas@monjalon.net, Pallavi Kadam <pallavi.kadam@intel.com>, Khoa To <khot@microsoft.com> Message-ID: <20210112041534.1402eaa3@sovereign> In-Reply-To: <1610408246-29482-1-git-send-email-roretzla@linux.microsoft.com> References: <1610408246-29482-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> + Pallavi, Khoa On Mon, 11 Jan 2021 15:37:26 -0800, Tyler Retzlaff wrote: > From: Tyler Retzlaff <roretzla@microsoft.com> > > declare reduced set of exports for rte_metrics on windows and include > it in the set of libraries to build and install. > > rte_metrics_tel* exports depend on conditionally available component. > this change minimally allows enabling the building of rte_metrics on > windows. What's the future plan? Once we talked about a script that would inspect objects and filter missing functions from the list in .map to build .def. Is MSFT working on it? Or do we choose another way? > --- /dev/null > +++ b/lib/librte_metrics/rte_metrics_exports.def > @@ -0,0 +1,8 @@ > +EXPORTS > + rte_metrics_get_names > + rte_metrics_get_values > + rte_metrics_init + rte_metrics_deinit > + rte_metrics_reg_name > + rte_metrics_reg_names > + rte_metrics_update_value > + rte_metrics_update_values