DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: eugeny.parshutin@linux.intel.com
Cc: kevin.laatz@intel.com, dev@dpdk.org, ilia.kurakin@intel.com,
	ciara.power@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide
Date: Wed, 13 Jan 2021 17:11:19 +0000
Message-ID: <20210113171119.GA639@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201202174806.10288-1-eugeny.parshutin@linux.intel.com>

On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshutin@linux.intel.com wrote:
> From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> 
> Return back 'profiling with vtune' section to profiling programmers
> guide with updated instruction on how to enable vtune profiling
> with meson configuration option.
> 
> Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
> ---
>  doc/guides/prog_guide/profile_app.rst | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/profile_app.rst b/doc/guides/prog_guide/profile_app.rst
> index 709368198..c87ca5d9d 100644
> --- a/doc/guides/prog_guide/profile_app.rst
> +++ b/doc/guides/prog_guide/profile_app.rst
> @@ -33,6 +33,20 @@ Refer to the
>  for details about application profiling.
>  
>  
> +Profiling with VTune
> +~~~~~~~~~~~~~~~~~~~~
> +
> +To allow VTune attaching to the DPDK application, reconfigure a DPDK build
> +folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option
> +and recompile the DPDK:
> +
> +.. code-block:: console
> +
> +    meson build
> +    meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1
> +    ninja -C build
> +
Since the VTUNE parts seem to be protected by just "#ifdef" rather than a
check for a specific value, I think the "=1" can be omitted in the
instructions. That should also make the quoted unnecessary.

With that change to simplify things,

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


  reply	other threads:[~2021-01-13 17:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 17:48 eugeny.parshutin
2021-01-13 17:11 ` Bruce Richardson [this message]
2021-01-13 20:22   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113171119.GA639@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    --cc=eugeny.parshutin@linux.intel.com \
    --cc=ilia.kurakin@intel.com \
    --cc=kevin.laatz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git