From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C9ABA0A02; Wed, 13 Jan 2021 18:11:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39042140E6B; Wed, 13 Jan 2021 18:11:31 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 74C2C140E69 for ; Wed, 13 Jan 2021 18:11:29 +0100 (CET) IronPort-SDR: ABuoOF7MHHLbJaRFvfb02WOb6MlMVaowLSCu2pfbaIekwq8nNWQ0o7oCsrL7T8zoNS8FXszK+i BGbWK65Ntxeg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="196876457" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="196876457" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 09:11:28 -0800 IronPort-SDR: f6VwCQTj95Zt7XgWGzyLbeOhSpUdoAENNlvlIPqf5jYnnnUC45tinwHH+7c9MaVqcTWsh4g3KD bIbUMqTe9Vgg== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="353555812" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.29.100]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Jan 2021 09:11:26 -0800 Date: Wed, 13 Jan 2021 17:11:19 +0000 From: Bruce Richardson To: eugeny.parshutin@linux.intel.com Cc: kevin.laatz@intel.com, dev@dpdk.org, ilia.kurakin@intel.com, ciara.power@intel.com Message-ID: <20210113171119.GA639@bricha3-MOBL.ger.corp.intel.com> References: <20201202174806.10288-1-eugeny.parshutin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201202174806.10288-1-eugeny.parshutin@linux.intel.com> Subject: Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshutin@linux.intel.com wrote: > From: Eugeny Parshutin > > Return back 'profiling with vtune' section to profiling programmers > guide with updated instruction on how to enable vtune profiling > with meson configuration option. > > Signed-off-by: Eugeny Parshutin > --- > doc/guides/prog_guide/profile_app.rst | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/doc/guides/prog_guide/profile_app.rst b/doc/guides/prog_guide/profile_app.rst > index 709368198..c87ca5d9d 100644 > --- a/doc/guides/prog_guide/profile_app.rst > +++ b/doc/guides/prog_guide/profile_app.rst > @@ -33,6 +33,20 @@ Refer to the > for details about application profiling. > > > +Profiling with VTune > +~~~~~~~~~~~~~~~~~~~~ > + > +To allow VTune attaching to the DPDK application, reconfigure a DPDK build > +folder by passing ``-Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1`` meson option > +and recompile the DPDK: > + > +.. code-block:: console > + > + meson build > + meson configure build -Dc_args='-DRTE_ETHDEV_PROFILE_WITH_VTUNE'=1 > + ninja -C build > + Since the VTUNE parts seem to be protected by just "#ifdef" rather than a check for a specific value, I think the "=1" can be omitted in the instructions. That should also make the quoted unnecessary. With that change to simplify things, Acked-by: Bruce Richardson