From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EE5BA0A02; Wed, 13 Jan 2021 18:20:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 369F2140E8A; Wed, 13 Jan 2021 18:20:39 +0100 (CET) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id 751C6140CEC for ; Wed, 13 Jan 2021 18:20:36 +0100 (CET) Received: by mail-lj1-f170.google.com with SMTP id p13so3447143ljg.2 for ; Wed, 13 Jan 2021 09:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rNDI5JrNMa5syIFQqauF/EdeRosr0T87s3IQrhUhnyg=; b=O8KmNogRJgvulqJx9orRXAfNkX4401tViMIJnF+0yNru5wICBAdOj9/YjxuDPNV6YI l08t40ITTeNyAkT3ZLj7LiFY8CDX2TBkCjhGG/x0BD4UWI8L7MqCotfv6hZjMXmHxGmE UcFrcapFxXXwL5tdphXidhvj1k13qDl0ba5we5oQ7b0y6Z6pzyfrHto+B4trrIZQeHWZ sOXG52gqkwboXclmKj4KniK35fq+2tKIVFIuxyhcJ0SJ1w8ltm2bVr6/hSZ+k9KXINqu 7B7HVqGVnIL/jCKN/fVQcOvKzTyrWTg+FrCV40KHfrmYYVgZiVUJpUZqrnGI2MCfyrJC Kirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rNDI5JrNMa5syIFQqauF/EdeRosr0T87s3IQrhUhnyg=; b=kb+hH3Q40bykCrzbn9nDCy+1KwNyIV9rG5HYXE8N0kosYPL1NaEqjo7Jofl3wFLCrj X4VkTd9YrqzW5S71pDJBpZewhHNZEz+i05x4hrA4n1RgsS0AQmSb6tDRzg35nii63EZM 8X4wMZhzNRnpnWzCtsv8nPHfS0j7AUyWxVRKbzqMWx2z+v0KwXHXMUaKEJ0Xz5DxykFQ OcD/DnQQyx9ZuCYwX0qIR4Yc5OLSPTCfz++cVsBmbGm/wsvVdckaRZqs/H532VsTyudY xtQSBVQ0dkyyGVkTv1LRFOmDurhGXu6LPM7BmsfALZEpQQbyloPIgCQW3X+3xY4qakVk YXDQ== X-Gm-Message-State: AOAM530aRIUMLt9djO2/mlBcBSAXkUyIUDY0ug10dSbcQZCw2JZMCArZ osQKIkUkDWk6hhsLzV4WFNrxb7jvUIInGw== X-Google-Smtp-Source: ABdhPJwtYNiEgDXGxb6p/xhfH5e2/6LblRra+f3sLatgqPHDjD9nkiOBC35KTY6jszsMpLqEr4xKKg== X-Received: by 2002:a2e:9214:: with SMTP id k20mr1321042ljg.45.1610558436024; Wed, 13 Jan 2021 09:20:36 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v28sm268242lfd.57.2021.01.13.09.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 09:20:35 -0800 (PST) Date: Wed, 13 Jan 2021 20:20:34 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: dev@dpdk.org Message-ID: <20210113202034.2b778fc9@sovereign> In-Reply-To: <1610490821-2938-1-git-send-email-roretzla@linux.microsoft.com> References: <1610490821-2938-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] bus/pci/windows: guard against sdk/dpdk guid collision X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 12 Jan 2021 14:33:41 -0800, Tyler Retzlaff wrote: > DEVCLASS and DEVINTERFACE guids are defined/managed by the windows > platform sdk headers. Please write names and acronyms in proper case in all human-readable text (commit subject except topic, commit message, log messages). > * hide dpdk defined GUID_DEVCLASS_NETUIO and GUID_DEVINTERFACE_NETUIO if > the NTDDI_VERSION >= 0x0A00000A > * include for windows sdk defined GUID_DEVINTERFACE_NETUIO This translates the code almost verbatim, not needed. Instead you could state which SDK versions are affected. Suggested wording: pci/windows: fix build with SDK 10.0.xxxxx NetUIO device class and interface GUIDs are defined in system headers starting from platform SDK v10.0.xxxxx. Inspect SDK version to avoid redefinition. Fixes: hhhhhhhhhhhh ("...") Cc: stable@dpdk.org Signed-off-by: Tyler Retzlaff I can't find which "xxxxx" corresponds to NTDDI_WIN10_FE. "hhhhhhhhhhhh" are 12 chars of the hash of the commit which introduced the code you fixed. "..." is said commit subject. This info is needed to backport your fix to stable branch, so that it can also be built with newer SDK. May not be very important until Windows port gets its users, I mostly tell it to illustrate the process. > +#if (! defined(NTDDI_WIN10_FE) || NTDDI_VERSION < NTDDI_WIN10_FE) Braces are redundant here and DPDK style is to avoid them (see rte_common.h).