From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3200A0A02; Thu, 14 Jan 2021 03:27:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 876B5140D95; Thu, 14 Jan 2021 03:27:26 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id A2509140D67 for ; Thu, 14 Jan 2021 03:27:24 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id v3so2140373plz.13 for ; Wed, 13 Jan 2021 18:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2SlvigyAUeHtjq2Jx2yBswVSXDXfW7TbtVaV6B6Y1qs=; b=dxsIFQ3p0vsmSFWZ++khQ6EYyNGxH6fEHUHujckXIT32pTx2CbMH5kQvZQWoMkD+jA WENle0ktfsNner5JScPRx8dUaYPrpkrGS2VxmxvOl2HUYONdQ3DdIxTF/NXgcfqAaZl9 zmD4m9NDJNydwBy6xEUB2IFHQ9H6RiGdqOyfDa6v6RkotScmNOQZgTiyoVN7XHj/UJSB WvACJF1PpwDk7zULO1489i5Dhg83sVbqc5fOcYxxqgw5fgQZRsfPlB5glLqd5LEeNcvd AGZObRoz+osIfFM0I5790iRIXC+TcJMJfEzJNbbCyjiL6lOyyuM7o8MmNvQCSNBDsadN 7r3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2SlvigyAUeHtjq2Jx2yBswVSXDXfW7TbtVaV6B6Y1qs=; b=lIOw/+fwKg2z+TEzHzVK4cPxL4xrYjn1mw+75HoMr7uY/FEXUvHGUUANgApbdMfFd0 cHEmf3A/wcvzeWCPrdiM+x5BzPg3L59DFZvcWmfY3+hSyQSXl1n/gtTYjdFNWdz5BzDb 1bMYReMSp0s+NR6hR6r86mcD4ySErsbC3a8l9li4rUjZNa5ocAQr/Cg6W6sN/xQ3t0uo a1LH/kZzGCWAo/BQ0XYfNPFNI9GqImm2OQprVCqImkyLkRcP9Ch1hMqDthvo32Qo/1au t/C32ujoXy1uf7SecNLc1z4wNtB3a7YjS/J1wk2SKudJObetJsyjTZ4iUw9xkFYvfDHu i7XQ== X-Gm-Message-State: AOAM5305jby+5xepKHO3BfcFh10M6osrkJjIrpUwfGk6ERI4s+/RKpNt EWC58cuyw7LGOQr9kb8uuttzBj5/Orozlw== X-Google-Smtp-Source: ABdhPJxyRYq3vRNNE1IMj1yslazPJ82ex/5PU2Ry50nwaxAl0q8sBmr+NhBtAKNRdG9nt3z3bs7TQQ== X-Received: by 2002:a17:902:8bc8:b029:dc:36d4:fba8 with SMTP id r8-20020a1709028bc8b02900dc36d4fba8mr5273974plo.82.1610591243425; Wed, 13 Jan 2021 18:27:23 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f67sm3821278pfg.159.2021.01.13.18.27.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2021 18:27:22 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur Date: Wed, 13 Jan 2021 18:27:16 -0800 Message-Id: <20210114022716.7999-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210113043011.6291-1-somnath.kotur@broadcom.com> References: <20210113043011.6291-1-somnath.kotur@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/bnxt: fix lock handling in stop and close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set. Fixes: dd3613560573 ("net/bnxt: check chip reset in dev stop and close") Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- v1->v2: rebased to latest dpdk-next-net and updated commit log. --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f439aeee4..89e42ef14 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) if (bp->flags & BNXT_FLAG_FW_RESET) { PMD_DRV_LOG(ERR, "Adapter recovering from error..Please retry\n"); + pthread_mutex_unlock(&bp->err_recovery_lock); return -EAGAIN; } pthread_mutex_unlock(&bp->err_recovery_lock); @@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev) if (bp->flags & BNXT_FLAG_FW_RESET) { PMD_DRV_LOG(ERR, "Adapter recovering from error...Please retry\n"); + pthread_mutex_unlock(&bp->err_recovery_lock); return -EAGAIN; } pthread_mutex_unlock(&bp->err_recovery_lock); -- 2.21.1 (Apple Git-122.3)