From: Simei Su <simei.su@intel.com>
To: qi.z.zhang@intel.com
Cc: dev@dpdk.org, junfeng.guo@intel.com, jia.guo@intel.com,
yahui.cao@intel.com, Simei Su <simei.su@intel.com>
Subject: [dpdk-dev] [PATCH] net/iavf: fix null pointer dereference
Date: Thu, 14 Jan 2021 13:23:24 +0800 [thread overview]
Message-ID: <20210114052324.393980-1-simei.su@intel.com> (raw)
A pointer has already been dereferenced before checking if it is NULL.
It doesn't make any sense, so correct to avoid it.
Fixes: 4f3cfcbc3df3 ("net/iavf: support eCPRI msg type 0 for RSS")
Coverity issue: 365290
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/iavf/iavf_hash.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index ebaac58..9901f4b 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -597,11 +597,13 @@ iavf_hash_parse_pattern(const struct rte_flow_item pattern[], uint64_t *phint,
break;
case RTE_FLOW_ITEM_TYPE_ECPRI:
ecpri = item->spec;
- ecpri_common.u32 = rte_be_to_cpu_32(
- ecpri->hdr.common.u32);
if (!ecpri)
break;
- else if (ecpri_common.type !=
+
+ ecpri_common.u32 = rte_be_to_cpu_32(
+ ecpri->hdr.common.u32);
+
+ if (ecpri_common.type !=
RTE_ECPRI_MSG_TYPE_IQ_DATA) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM, item,
--
2.9.5
next reply other threads:[~2021-01-14 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 5:23 Simei Su [this message]
2021-01-14 7:53 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114052324.393980-1-simei.su@intel.com \
--to=simei.su@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).