From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEFA8A0A02; Thu, 14 Jan 2021 07:52:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66EE5140E54; Thu, 14 Jan 2021 07:52:59 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 22211140CB8 for ; Thu, 14 Jan 2021 07:52:57 +0100 (CET) IronPort-SDR: 6sFHyM2GEodZLSXsduIJM1RAGcZcgBLGCliTWkj6OvHZaF4sxXWNV+QpKK02qeNXwlB0/PH4jt lmD0s4aez3Zw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="196969166" X-IronPort-AV: E=Sophos;i="5.79,346,1602572400"; d="scan'208";a="196969166" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 22:52:57 -0800 IronPort-SDR: W4XKl7f08wdy8ipbGJuql8diesETWJkmH5dxD2OSeBqLH5NhRuzsj+MGP4OKjJYd5jwRlrxzDE VY0+WoSEjwLg== X-IronPort-AV: E=Sophos;i="5.79,346,1602572400"; d="scan'208";a="400803389" Received: from shwdenpg235.ccr.corp.intel.com ([10.240.182.60]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 22:52:55 -0800 From: "Zhang,Alvin" To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Alvin Zhang Date: Thu, 14 Jan 2021 14:52:48 +0800 Message-Id: <20210114065248.17160-1-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/i40e: fix out-of-scope variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alvin Zhang Using "key", which points to an out-of-scope variable "rss_key_default". Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_hash.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index e07f806..83a9af5 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -901,10 +901,12 @@ struct i40e_hash_match_pattern { PMD_DRV_LOG(WARNING, "RSS key length invalid, must be %u bytes, now set key to default", (uint32_t)sizeof(rss_conf->key)); - key = (const uint8_t *)rss_key_default; + + memcpy(rss_conf->key, rss_key_default, sizeof(rss_conf->key)); + } else { + memcpy(rss_conf->key, key, sizeof(rss_conf->key)); } - memcpy(rss_conf->key, key, sizeof(rss_conf->key)); rss_conf->conf.key = rss_conf->key; rss_conf->conf.key_len = sizeof(rss_conf->key); } -- 1.8.3.1