From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 425FBA0A02; Thu, 14 Jan 2021 08:59:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC494140FCB; Thu, 14 Jan 2021 08:59:08 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 17347140FCA for ; Thu, 14 Jan 2021 08:59:07 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5366320B6C40; Wed, 13 Jan 2021 23:59:06 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5366320B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1610611146; bh=c6z6Lr7xv8OKU/kTd3m4hzenfMuzBGFiGla3+G+V+no=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvhaHkzzmsv33Cthofth/qcPn6gl0nOYghlEx5P7WWPlGNSB0jCf7fQDVZIRLyZS0 4+XyMurupsdYQ/p3s0PTSl9sHU9mhU286Vq3qsOsyJFv/x49eFemPlwIvQVF+iz97M VnFw6HQOBRpvzrMey+Wqbm8QmpxOdkudGgwdjWSk= Date: Wed, 13 Jan 2021 23:59:06 -0800 From: Tyler Retzlaff To: Dmitry Kozlyuk Cc: dev@dpdk.org Message-ID: <20210114075906.GB27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1610490821-2938-1-git-send-email-roretzla@linux.microsoft.com> <20210113202034.2b778fc9@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113202034.2b778fc9@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH] bus/pci/windows: guard against sdk/dpdk guid collision X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 13, 2021 at 08:20:34PM +0300, Dmitry Kozlyuk wrote: > pci/windows: fix build with SDK 10.0.xxxxx > > NetUIO device class and interface GUIDs are defined in system > headers starting from platform SDK v10.0.xxxxx. Inspect SDK version > to avoid redefinition. > > Fixes: hhhhhhhhhhhh ("...") > Cc: stable@dpdk.org > > Signed-off-by: Tyler Retzlaff > > I can't find which "xxxxx" corresponds to NTDDI_WIN10_FE. there won't be a specific sdk/kit that corresponds. the best i can offer is to include in the message the latest sdk/kit version for that platform version. also be aware since there is no 1:1 alignment between NTDDI_VERSION and the sdk/kit build where the conflicting GUID definitions were introduced there will still be a subset of eal/pre-release kits if installed that will lead to compilation failure of dpdk even with this change. i'll also add a note in the commit message about this limitation. windows doesn't promise api compatibility for pre-release kits and there is no approved mechanism / versioning to provide such compatibility. > "hhhhhhhhhhhh" are 12 chars of the hash of the commit which introduced the > code you fixed. "..." is said commit subject. This info is needed to backport > your fix to stable branch, so that it can also be built with newer SDK. May > not be very important until Windows port gets its users, I mostly tell it to > illustrate the process. yes, understood this one is definitely appropriate for backport > > +#if (! defined(NTDDI_WIN10_FE) || NTDDI_VERSION < NTDDI_WIN10_FE) > > Braces are redundant here and DPDK style is to avoid them (see rte_common.h). yes, sorry will fix. best part is i don't like redundant braces i just added them because i encounter so many people who do. (can't win really)