From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8054FA0A02;
Thu, 14 Jan 2021 10:51:11 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8F729141099;
Thu, 14 Jan 2021 10:50:35 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by mails.dpdk.org (Postfix) with ESMTP id B20FB141098
for <dev@dpdk.org>; Thu, 14 Jan 2021 10:50:33 +0100 (CET)
IronPort-SDR: RSUbH9WChUUpk/q9IAjEbCuf6hyMkQvJ7GpUqn2JkQsYyyO0v/88jp2uPAaFhwEvVBjN0sLgji
7mBxiq37S4Jg==
X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="263129604"
X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="263129604"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
14 Jan 2021 01:50:32 -0800
IronPort-SDR: 9XqY7HeJHXgydVsx9M8r/HB0TRSwnmb49EYuZxMAnKTUioam+an3jJNfhtIWEu5LmzPcNnAuq+
81unnhoU8jsg==
X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="572283929"
Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])
by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
14 Jan 2021 01:50:31 -0800
From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: rahul.lakkireddy@chelsio.com,
Steve Yang <stevex.yang@intel.com>
Date: Thu, 14 Jan 2021 09:47:20 +0000
Message-Id: <20210114094720.14419-1-stevex.yang@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201217092312.27033-1-stevex.yang@intel.com>
References: <20201217092312.27033-1-stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v3 17/22] net/cxgbe: fix the jumbo frame flag
condition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition.
If the Ether overhead is larger than 18 when it supports VLAN tag,
that will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.
This fix will normalize the boundary condition with 'RTE_ETHER_MTU'
and overhead even though current overhead is 18.
Fixes: 4b2eff452d2e ("cxgbe: enable jumbo frames")
Fixes: 0ec33be4c857 ("cxgbe: allow to change mtu")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/cxgbe/cxgbe.h | 4 ++++
drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h
index ef62af1c3f..7c89a028bf 100644
--- a/drivers/net/cxgbe/cxgbe.h
+++ b/drivers/net/cxgbe/cxgbe.h
@@ -19,6 +19,10 @@
#define CXGBE_MAX_RX_PKTLEN (9000 + RTE_ETHER_HDR_LEN + \
RTE_ETHER_CRC_LEN) /* max pkt */
+/* The max frame size with default MTU */
+#define CXGBE_ETH_MAX_LEN (RTE_ETHER_MTU + \
+ RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN)
+
/* Max poll time is 100 * 100msec = 10 sec */
#define CXGBE_LINK_STATUS_POLL_MS 100 /* 100ms */
#define CXGBE_LINK_STATUS_POLL_CNT 100 /* Max number of times to poll */
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index 98d0362fa3..480d6f58a8 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -300,7 +300,7 @@ int cxgbe_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)
return -EINVAL;
/* set to jumbo mode if needed */
- if (new_mtu > RTE_ETHER_MAX_LEN)
+ if (new_mtu > CXGBE_ETH_MAX_LEN)
eth_dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
else
@@ -669,7 +669,7 @@ int cxgbe_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,
rxq->fl.size = temp_nb_desc;
/* Set to jumbo mode if necessary */
- if (pkt_len > RTE_ETHER_MAX_LEN)
+ if (pkt_len > CXGBE_ETH_MAX_LEN)
eth_dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
else
--
2.17.1