From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *
Date: Thu, 14 Jan 2021 10:05:57 +0300 [thread overview]
Message-ID: <20210114100557.3ec44961@sovereign> (raw)
In-Reply-To: <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote:
> On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote:
> > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> > > Explicitly cast void * to type * so that eal headers may be compiled
> > > as C or C++.
> >
> > Topic should probably be "eal/windows".
>
> i'll submit a new rev that changes this, it's not really windows specific
> but i guess windows is the only people crazy enough to use c++.
1. Topic usually describe area of changes, rte_os.h is in windows directory.
2. It's a perfectly valid concern that public headers must be usable from C++.
> > > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h
> > > index bf715896a..c20be29b1 100644
> > > --- a/lib/librte_ethdev/rte_ethdev_pci.h
> > > +++ b/lib/librte_ethdev/rte_ethdev_pci.h
> > > @@ -47,7 +47,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,
> > >
> > > static inline int
> > > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) {
> > > - struct rte_pci_device *pci_dev = bus_device;
> > > + struct rte_pci_device *pci_dev = (struct rte_pci_device *)bus_device;
> > >
> > > if (!pci_dev)
> > > return -ENODEV;
> >
> > This is a private header, it's never exposed---why the change is needed (not
> > that I have a strong opinion, though)?
>
> interesting, i'll look into why/how it is being included and confirm. i suppose
> the question in the back of my mind is if it is private then why is the header
> being installed at all?
+ Bruce
If it's a public header then maybe it's missing a @file?
next prev parent reply other threads:[~2021-01-14 7:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 1:18 Tyler Retzlaff
2021-01-13 17:52 ` Dmitry Kozlyuk
2021-01-14 5:45 ` Tyler Retzlaff
2021-01-14 7:05 ` Dmitry Kozlyuk [this message]
2021-01-14 10:55 ` Bruce Richardson
2021-01-14 18:27 ` Dmitry Kozlyuk
2021-01-14 18:49 ` Thomas Monjalon
2021-01-15 19:21 ` Tyler Retzlaff
2021-01-17 17:13 ` Thomas Monjalon
2021-01-15 19:38 ` [dpdk-dev] [PATCH v2] eal/windows: " Tyler Retzlaff
2021-01-17 17:19 ` Thomas Monjalon
2021-01-17 18:10 ` Stephen Hemminger
2021-01-17 19:51 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114100557.3ec44961@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).