From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ciara Power <ciara.power@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status
Date: Thu, 14 Jan 2021 12:17:33 +0000 [thread overview]
Message-ID: <20210114121733.46801-1-bruce.richardson@intel.com> (raw)
When querying the link status via telemetry interface, we don't want the
client to have to wait for multiple seconds for a reply. Therefore use
"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the
telemetry callback.
Cc: stable@dpdk.org
Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/librte_ethdev/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 17ddacc78..1f4545fe0 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,
if (!rte_eth_dev_is_valid_port(port_id))
return -1;
- ret = rte_eth_link_get(port_id, &link);
+ ret = rte_eth_link_get_nowait(port_id, &link);
if (ret < 0)
return -1;
--
2.27.0
next reply other threads:[~2021-01-14 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 12:17 Bruce Richardson [this message]
2021-01-14 15:06 ` Power, Ciara
2021-01-18 14:02 ` Thomas Monjalon
2021-01-18 14:48 ` Ferruh Yigit
2021-01-19 1:06 ` Min Hu (Connor)
2021-01-19 2:26 ` Stephen Hemminger
2021-01-19 2:58 ` Min Hu (Connor)
2021-01-19 10:06 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114121733.46801-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).