DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests
@ 2021-01-14 16:58 Stephen Hemminger
  2021-01-17 17:57 ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2021-01-14 16:58 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

The ticketlock test is fast and should be run all the time.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test/meson.build b/app/test/meson.build
index 94fd39fecb82..90c4d05814f1 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -245,6 +245,7 @@ fast_tests = [
         ['string_autotest', true],
         ['table_autotest', true],
         ['tailq_autotest', true],
+        ['ticketlock_autotest', true],
         ['timer_autotest', false],
         ['user_delay_us', true],
         ['version_autotest', true],
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests
  2021-01-14 16:58 [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests Stephen Hemminger
@ 2021-01-17 17:57 ` Thomas Monjalon
  2021-01-17 18:11   ` Stephen Hemminger
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2021-01-17 17:57 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, david.marchand, aconole, joyce.kong

14/01/2021 17:58, Stephen Hemminger:
> The ticketlock test is fast and should be run all the time.

I think it was not added because it includes a perf test.
Cc'ing more people for comments.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests
  2021-01-17 17:57 ` Thomas Monjalon
@ 2021-01-17 18:11   ` Stephen Hemminger
  2021-01-18 13:29     ` Aaron Conole
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2021-01-17 18:11 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, david.marchand, aconole, joyce.kong

On Sun, 17 Jan 2021 18:57:56 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 14/01/2021 17:58, Stephen Hemminger:
> > The ticketlock test is fast and should be run all the time.  
> 
> I think it was not added because it includes a perf test.
> Cc'ing more people for comments.
> 
> 

Other lock code (rwlock is very similar and in the fast tests).

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests
  2021-01-17 18:11   ` Stephen Hemminger
@ 2021-01-18 13:29     ` Aaron Conole
  2021-01-19 10:47       ` Thomas Monjalon
  0 siblings, 1 reply; 5+ messages in thread
From: Aaron Conole @ 2021-01-18 13:29 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Thomas Monjalon, dev, david.marchand, joyce.kong

Stephen Hemminger <stephen@networkplumber.org> writes:

> On Sun, 17 Jan 2021 18:57:56 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> 14/01/2021 17:58, Stephen Hemminger:
>> > The ticketlock test is fast and should be run all the time.  
>> 
>> I think it was not added because it includes a perf test.
>> Cc'ing more people for comments.
>> 
>> 
>
> Other lock code (rwlock is very similar and in the fast tests).

I agree, it should be included.  I did some digging and seems it wasn't
ever part of this set of lists, but could have been all along.  As for
execution time, here's a run from the 0-day bot:

https://github.com/ovsrobot/dpdk/actions/runs/486047432

17m seems to be in the normal range.

Acked-by: Aaron Conole <aconole@redhat.com>

Thanks, Stephen!


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests
  2021-01-18 13:29     ` Aaron Conole
@ 2021-01-19 10:47       ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-01-19 10:47 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, david.marchand, joyce.kong, Aaron Conole

18/01/2021 14:29, Aaron Conole:
> Stephen Hemminger <stephen@networkplumber.org> writes:
> 
> > On Sun, 17 Jan 2021 18:57:56 +0100
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> >> 14/01/2021 17:58, Stephen Hemminger:
> >> > The ticketlock test is fast and should be run all the time.  
> >> 
> >> I think it was not added because it includes a perf test.
> >> Cc'ing more people for comments.
> >> 
> >> 
> >
> > Other lock code (rwlock is very similar and in the fast tests).
> 
> I agree, it should be included.  I did some digging and seems it wasn't
> ever part of this set of lists, but could have been all along.  As for
> execution time, here's a run from the 0-day bot:
> 
> https://github.com/ovsrobot/dpdk/actions/runs/486047432
> 
> 17m seems to be in the normal range.
> 
> Acked-by: Aaron Conole <aconole@redhat.com>
> 
> Thanks, Stephen!

Applied, thanks




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-19 10:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 16:58 [dpdk-dev] [PATCH] test: add missing ticketlock test to fast tests Stephen Hemminger
2021-01-17 17:57 ` Thomas Monjalon
2021-01-17 18:11   ` Stephen Hemminger
2021-01-18 13:29     ` Aaron Conole
2021-01-19 10:47       ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git