From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6D6EA0A02; Thu, 14 Jan 2021 19:27:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64E92140F26; Thu, 14 Jan 2021 19:27:44 +0100 (CET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 195F6140F12; Thu, 14 Jan 2021 19:27:43 +0100 (CET) Received: by mail-lf1-f45.google.com with SMTP id a12so9422930lfl.6; Thu, 14 Jan 2021 10:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tlgh+u+MFiaOxZJ4x4SNUIRPY9Ii9KfxQ64KErl+MOc=; b=o2r60z576GbvozdmexX4AgUql8YN4zV7TFAq9k315O895nmNQxs5cOYzIzR6vRy1b0 PkHb00AaFaC7vt29dLgCibH/uFDzKKj/ONymCKu8pll2Luoq37I5oAAPW54hT+R+H/9l MZOmRjTT0Rkb7eAmDGsMHNrpIgorw6iJNAmUt+2hd5SLCZy6OFDmP+kofMDeCiGHTkE3 /Elm2kPGhJ3s5jq1D4O1H5zRsTLWby1fGd2K01ORh2XYrJ45pW/AlVkR4vY4eZhRXVcz LaGkJxyNqrK6iA/uZb1ZBM5PsaW0gVYBGVrIZUHsL7xx6DrWjYWMSje9VasPQIH0rWfm 8YYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tlgh+u+MFiaOxZJ4x4SNUIRPY9Ii9KfxQ64KErl+MOc=; b=Ou11II2xBaC1hi/Osuq6GEJoUUmc3spLl5QvF+AWoAoSxyjldCf7+GjhKWi3lXnaX1 mhDOv3+Y9/h2oZMBvW6UfKWpeZQmDWK57FAwkE459gUXlbiIhfRPkCWdXhE5E5kGyZ/F XZfvTdmt9PqfrzzrLMBMZwyD3EzXHZ7g2jI1T00yUgAAWZ+M38574uUrx3CgfCn7c2Ah 2KruuDqry+5x+olPDHQk8HWQqwpd1SjU2bsHbifgLSenb8W5RsNjjYkCYlIAR0Wf/Oj/ I7mwE5c3aC3umLkPbrG87UF5at2lH1zW35PL6v5w5BOpRu3K5cQgWaTFwotwC3vs5fg2 I/Mw== X-Gm-Message-State: AOAM531AAowBzBPDhVn6YCx8Xbd1PomRrY1mIkkLFBChYPuRmobn6tNu HES06xmRs7VWuj24iM6e5Rc= X-Google-Smtp-Source: ABdhPJwB+FjY3M9uHA9AkqfYfFUf7M4096FSf/HJZ6hn8KU8sbUqnkE4Euq6vnmHSxKxAmTO5AlSxA== X-Received: by 2002:ac2:46f9:: with SMTP id q25mr2024630lfo.550.1610648862603; Thu, 14 Jan 2021 10:27:42 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z23sm620558lfi.1.2021.01.14.10.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 10:27:41 -0800 (PST) Date: Thu, 14 Jan 2021 21:27:40 +0300 From: Dmitry Kozlyuk To: Bruce Richardson Cc: Tyler Retzlaff , dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org Message-ID: <20210114212740.3d69dbc2@sovereign> In-Reply-To: <20210114105554.GA1959@bricha3-MOBL.ger.corp.intel.com> References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> <20210113205255.6e865a04@sovereign> <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210114100557.3ec44961@sovereign> <20210114105554.GA1959@bricha3-MOBL.ger.corp.intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type * X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > If it's a public header then maybe it's missing a @file? > > > My 2c on this in general... > > The use of public vs private headers is not always clear, sadly, in DPDK, > for historical reasons. With the make builds, libraries picked up headers > from other libraries via the "include" folder for all of DPDK, meaning that > if a particular header was internal only but used by multiple other libs, > it was placed in "include" for simplicity, rather than having each library > using it having to have separate "-I/path/to/header" cflags specified. > With the switch to meson, this common folder use is no longer be the case, > but because of the old way of doing things it may be that in the transition > some private headers were inadvertently kept as public (and possibly vice > versa, though that is more likely to be spotted by now). > > /Bruce Here is why rte_ethdev_pci.h should be considered private to DPDK: * rte_eth_copy_pci_info - intended for device init, that is, driver job * eth_dev_pci_specific_init - wrapper for the above * rte_eth_dev_pci_allocate - @internal, deals with private data * rte_eth_dev_pci_generic_probe - @internal, deals with private data * rte_eth_dev_pci_generic_remove - @internal