From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C3AEEA0A02;
Fri, 15 Jan 2021 08:32:54 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 48097140D8F;
Fri, 15 Jan 2021 08:32:54 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id A5F82140D74
for <dev@dpdk.org>; Fri, 15 Jan 2021 08:32:52 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id
10F7WPO2018054; Thu, 14 Jan 2021 23:32:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=pfpt0220; bh=71W4g7T972rQuHUIChpyUDG+E9I7zaQ1zOC/x5GtaK8=;
b=PBzLA9V7YYiCQsKr1y0NrOvQM7N+LEI0bCe+pwVHfbNpc5kP4jwxBvSyz9sqAeG6Szbc
gC9c9/vr8/f1CAl6eIAtNLHFsPDuuIvMmaQxFIvkbWPtPE8B+xgert07+BDOCWKU2Riz
f6CW2n3MV940yIAmE/OFvL9Lz+jrFUkGVIaV912xFI0BSAdf3EJf65BSfoO+D4TYuXdT
5xQcmTsV0A92W/EbzrSiPdHTPjrM2OWty+98Awid3NPCfL2bgLAl0GHzAMJa09mnx53h
fC3a5HxX9CGWKeV4uRZXBmF/Eti0jcyCeZTDxLi1p6zJ54BbP51Iyb9cqcrRiaSMCtSN Sw==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0b-0016f401.pphosted.com with ESMTP id 35ycvq1u3t-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Thu, 14 Jan 2021 23:32:51 -0800
Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 14 Jan 2021 23:32:50 -0800
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com
(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 14 Jan 2021 23:32:49 -0800
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend
Transport; Thu, 14 Jan 2021 23:32:49 -0800
Received: from hyd1588t430.marvell.com (unknown [10.29.52.204])
by maili.marvell.com (Postfix) with ESMTP id 9FE253F7040;
Thu, 14 Jan 2021 23:32:47 -0800 (PST)
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: <anatoly.burakov@intel.com>, David Christensen <drc@linux.vnet.ibm.com>,
<david.marchand@redhat.com>
CC: <jerinj@marvell.com>, <dev@dpdk.org>, Nithin Dabilpuram
<ndabilpuram@marvell.com>
Date: Fri, 15 Jan 2021 13:02:40 +0530
Message-ID: <20210115073243.7025-1-ndabilpuram@marvell.com>
X-Mailer: git-send-email 2.8.4
In-Reply-To: <20201012081106.10610-1-ndabilpuram@marvell.com>
References: <20201012081106.10610-1-ndabilpuram@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737
definitions=2021-01-15_03:2021-01-15,
2021-01-15 signatures=0
Subject: [dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Partial DMA unmap is not supported by VFIO type1 IOMMU
in Linux. Though the return value is zero, the returned
DMA unmap size is not same as expected size.
So add test case and fix to both heap triggered DMA
mapping and user triggered DMA mapping/unmapping.
Refer vfio_dma_do_unmap() in drivers/vfio/vfio_iommu_type1.c
Snippet of comment is below.
/*
* vfio-iommu-type1 (v1) - User mappings were coalesced together to
* avoid tracking individual mappings. This means that the granularity
* of the original mapping was lost and the user was allowed to attempt
* to unmap any range. Depending on the contiguousness of physical
* memory and page sizes supported by the IOMMU, arbitrary unmaps may
* or may not have worked. We only guaranteed unmap granularity
* matching the original mapping; even though it was untracked here,
* the original mappings are reflected in IOMMU mappings. This
* resulted in a couple unusual behaviors. First, if a range is not
* able to be unmapped, ex. a set of 4k pages that was mapped as a
* 2M hugepage into the IOMMU, the unmap ioctl returns success but with
* a zero sized unmap. Also, if an unmap request overlaps the first
* address of a hugepage, the IOMMU will unmap the entire hugepage.
* This also returns success and the returned unmap size reflects the
* actual size unmapped.
* We attempt to maintain compatibility with this "v1" interface, but
* we take control out of the hands of the IOMMU. Therefore, an unmap
* request offset from the beginning of the original mapping will
* return success with zero sized unmap. And an unmap request covering
* the first iova of mapping will unmap the entire range.
This behavior can be verified by using first patch and add return check for
dma_unmap.size != len in vfio_type1_dma_mem_map()
v8:
- Add cc stable to patch 3/3
v7:
- Dropped vfio test case of patch 3/4 i.e
"test: add test case to validate VFIO DMA map/unmap"
as it couldn't be supported in POWER9 system.
v6:
- Fixed issue with x86-32 build introduced by v5.
v5:
- Changed vfio test in test_vfio.c to use system pages allocated from
heap instead of mmap() so that it comes in range of initially configured
window for POWER9 System.
- Added acked-by from David for 1/4, 2/4.
v4:
- Fixed issue with patch 4/4 on x86 builds.
v3:
- Fixed external memory test case(4/4) to use system page size
instead of 4K.
- Fixed check-git-log.sh issue and rebased.
- Added acked-by from anatoly.burakov@intel.com to first 3 patches.
v2:
- Reverted earlier commit that enables mergin contiguous mapping for
IOVA as PA. (see 1/3)
- Updated documentation about kernel dma mapping limits and vfio
module parameter.
- Moved vfio test to test_vfio.c and handled comments from
Anatoly.
Nithin Dabilpuram (3):
vfio: revert changes for map contiguous areas in one go
vfio: fix DMA mapping granularity for type1 IOVA as VA
test: change external memory test to use system page sz
app/test/test_external_mem.c | 3 +-
doc/guides/linux_gsg/linux_drivers.rst | 10 ++++
lib/librte_eal/linux/eal_vfio.c | 93 +++++++++++++---------------------
lib/librte_eal/linux/eal_vfio.h | 1 +
4 files changed, 49 insertions(+), 58 deletions(-)
--
2.8.4