[dpdk-dev] [PATCH 0/3] net build fixes

[dpdk-dev] [PATCH 0/3] net build fixes

[David Marchand]

Some fixes following make support removal.
The first patch is a real fix.
The other two are cleanups so I did not mark them for backport.

-- 
David Marchand

David Marchand (3):
  net/hinic: restore vectorised code
  net/i40e: remove vector config
  net/fm10k: remove vector config

 drivers/net/fm10k/meson.build    |  1 -
 drivers/net/hinic/hinic_pmd_rx.c |  6 ++--
 drivers/net/hinic/hinic_pmd_tx.c | 10 +++---
 drivers/net/i40e/i40e_rxtx.c     | 52 --------------------------------
 drivers/net/i40e/meson.build     |  3 --
 5 files changed, 8 insertions(+), 64 deletions(-)

-- 
2.23.0

[dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

[David Marchand]

Following make support removal, the vectorised code is not built
anymore, fix the build flag check.

Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/hinic/hinic_pmd_rx.c |  6 +++---
 drivers/net/hinic/hinic_pmd_tx.c | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/hinic/hinic_pmd_rx.c b/drivers/net/hinic/hinic_pmd_rx.c
index a49769a863..842399cc4c 100644
--- a/drivers/net/hinic/hinic_pmd_rx.c
+++ b/drivers/net/hinic/hinic_pmd_rx.c
@@ -4,7 +4,7 @@
 
 #include <rte_ether.h>
 #include <rte_mbuf.h>
-#ifdef __ARM64_NEON__
+#ifdef RTE_ARCH_ARM64
 #include <arm_neon.h>
 #endif
 
@@ -762,7 +762,7 @@ void hinic_free_all_rx_mbufs(struct hinic_rxq *rxq)
 static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32,
 					    volatile void *src_be32)
 {
-#if defined(__X86_64_SSE__)
+#if defined(RTE_ARCH_X86_64)
 	volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
 	__m128i *wqe_le = (__m128i *)dst_le32;
 	__m128i shuf_mask =  _mm_set_epi8(12, 13, 14, 15, 8, 9, 10,
@@ -770,7 +770,7 @@ static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32,
 
 	/* l2nic just use first 128 bits */
 	wqe_le[0] = _mm_shuffle_epi8(wqe_be[0], shuf_mask);
-#elif defined(__ARM64_NEON__)
+#elif defined(RTE_ARCH_ARM64)
 	volatile uint8x16_t *wqe_be = (volatile uint8x16_t *)src_be32;
 	uint8x16_t *wqe_le = (uint8x16_t *)dst_le32;
 	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10,
diff --git a/drivers/net/hinic/hinic_pmd_tx.c b/drivers/net/hinic/hinic_pmd_tx.c
index 9d0264e67a..669f82389c 100644
--- a/drivers/net/hinic/hinic_pmd_tx.c
+++ b/drivers/net/hinic/hinic_pmd_tx.c
@@ -7,7 +7,7 @@
 #include <rte_sctp.h>
 #include <rte_udp.h>
 #include <rte_ip.h>
-#ifdef __ARM64_NEON__
+#ifdef RTE_ARCH_ARM64
 #include <arm_neon.h>
 #endif
 
@@ -203,7 +203,7 @@
 
 static inline void hinic_sq_wqe_cpu_to_be32(void *data, int nr_wqebb)
 {
-#if defined(__X86_64_SSE__)
+#if defined(RTE_ARCH_X86_64)
 	int i;
 	__m128i *wqe_line = (__m128i *)data;
 	__m128i shuf_mask = _mm_set_epi8(12, 13, 14, 15, 8, 9, 10,
@@ -217,7 +217,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data, int nr_wqebb)
 		wqe_line[3] = _mm_shuffle_epi8(wqe_line[3], shuf_mask);
 		wqe_line += 4;
 	}
-#elif defined(__ARM64_NEON__)
+#elif defined(RTE_ARCH_ARM64)
 	int i;
 	uint8x16_t *wqe_line = (uint8x16_t *)data;
 	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10,
@@ -237,7 +237,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data, int nr_wqebb)
 
 static inline void hinic_sge_cpu_to_be32(void *data, int nr_sge)
 {
-#if defined(__X86_64_SSE__)
+#if defined(RTE_ARCH_X86_64)
 	int i;
 	__m128i *sge_line = (__m128i *)data;
 	__m128i shuf_mask = _mm_set_epi8(12, 13, 14, 15, 8, 9, 10,
@@ -248,7 +248,7 @@ static inline void hinic_sge_cpu_to_be32(void *data, int nr_sge)
 		*sge_line = _mm_shuffle_epi8(*sge_line, shuf_mask);
 		sge_line++;
 	}
-#elif defined(__ARM64_NEON__)
+#elif defined(RTE_ARCH_ARM64)
 	int i;
 	uint8x16_t *sge_line = (uint8x16_t *)data;
 	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10,
-- 
2.23.0

Re: [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

[Ruifeng Wang]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, January 15, 2021 9:40 PM
> To: dev@dpdk.org
> Cc: ferruh.yigit@intel.com; stable@dpdk.org; Ziyang Xuan
> <xuanziyang2@huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou
> <zhouguoyang@huawei.com>; Ciara Power <ciara.power@intel.com>;
> Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net
> Subject: [PATCH 1/3] net/hinic: restore vectorised code
> 
> Following make support removal, the vectorised code is not built anymore,
> fix the build flag check.
> 
> Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/hinic/hinic_pmd_rx.c |  6 +++---
> drivers/net/hinic/hinic_pmd_tx.c | 10 +++++-----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/hinic/hinic_pmd_rx.c
> b/drivers/net/hinic/hinic_pmd_rx.c
> index a49769a863..842399cc4c 100644
> --- a/drivers/net/hinic/hinic_pmd_rx.c
> +++ b/drivers/net/hinic/hinic_pmd_rx.c
> @@ -4,7 +4,7 @@
> 
>  #include <rte_ether.h>
>  #include <rte_mbuf.h>
> -#ifdef __ARM64_NEON__
> +#ifdef RTE_ARCH_ARM64

We can test '__ARM_NEON' which will be defined by compilers.
https://developer.arm.com/documentation/ihi0053/latest/

>  #include <arm_neon.h>
>  #endif
> 
> @@ -762,7 +762,7 @@ void hinic_free_all_rx_mbufs(struct hinic_rxq *rxq)
> static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32,
>  					    volatile void *src_be32)
>  {
> -#if defined(__X86_64_SSE__)
> +#if defined(RTE_ARCH_X86_64)
>  	volatile __m128i *wqe_be = (volatile __m128i *)src_be32;
>  	__m128i *wqe_le = (__m128i *)dst_le32;
>  	__m128i shuf_mask =  _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ -
> 770,7 +770,7 @@ static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32,
> 
>  	/* l2nic just use first 128 bits */
>  	wqe_le[0] = _mm_shuffle_epi8(wqe_be[0], shuf_mask); -#elif
> defined(__ARM64_NEON__)
> +#elif defined(RTE_ARCH_ARM64)
>  	volatile uint8x16_t *wqe_be = (volatile uint8x16_t *)src_be32;
>  	uint8x16_t *wqe_le = (uint8x16_t *)dst_le32;
>  	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, diff --git
> a/drivers/net/hinic/hinic_pmd_tx.c b/drivers/net/hinic/hinic_pmd_tx.c
> index 9d0264e67a..669f82389c 100644
> --- a/drivers/net/hinic/hinic_pmd_tx.c
> +++ b/drivers/net/hinic/hinic_pmd_tx.c
> @@ -7,7 +7,7 @@
>  #include <rte_sctp.h>
>  #include <rte_udp.h>
>  #include <rte_ip.h>
> -#ifdef __ARM64_NEON__
> +#ifdef RTE_ARCH_ARM64
>  #include <arm_neon.h>
>  #endif
> 
> @@ -203,7 +203,7 @@
> 
>  static inline void hinic_sq_wqe_cpu_to_be32(void *data, int nr_wqebb)  { -
> #if defined(__X86_64_SSE__)
> +#if defined(RTE_ARCH_X86_64)
>  	int i;
>  	__m128i *wqe_line = (__m128i *)data;
>  	__m128i shuf_mask = _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ -
> 217,7 +217,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data,
> int nr_wqebb)
>  		wqe_line[3] = _mm_shuffle_epi8(wqe_line[3], shuf_mask);
>  		wqe_line += 4;
>  	}
> -#elif defined(__ARM64_NEON__)
> +#elif defined(RTE_ARCH_ARM64)
>  	int i;
>  	uint8x16_t *wqe_line = (uint8x16_t *)data;
>  	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, @@ -237,7
> +237,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data, int
> nr_wqebb)
> 
>  static inline void hinic_sge_cpu_to_be32(void *data, int nr_sge)  { -#if
> defined(__X86_64_SSE__)
> +#if defined(RTE_ARCH_X86_64)
>  	int i;
>  	__m128i *sge_line = (__m128i *)data;
>  	__m128i shuf_mask = _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ -
> 248,7 +248,7 @@ static inline void hinic_sge_cpu_to_be32(void *data, int
> nr_sge)
>  		*sge_line = _mm_shuffle_epi8(*sge_line, shuf_mask);
>  		sge_line++;
>  	}
> -#elif defined(__ARM64_NEON__)
> +#elif defined(RTE_ARCH_ARM64)
>  	int i;
>  	uint8x16_t *sge_line = (uint8x16_t *)data;
>  	const uint8x16_t shuf_mask = {3, 2, 1, 0, 7, 6, 5, 4, 11, 10,
> --
> 2.23.0

Re: [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

[David Marchand]

On Sat, Jan 16, 2021 at 3:39 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
> > Subject: [PATCH 1/3] net/hinic: restore vectorised code
> >
> > Following make support removal, the vectorised code is not built anymore,
> > fix the build flag check.
> >
> > Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  drivers/net/hinic/hinic_pmd_rx.c |  6 +++---
> > drivers/net/hinic/hinic_pmd_tx.c | 10 +++++-----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/hinic/hinic_pmd_rx.c
> > b/drivers/net/hinic/hinic_pmd_rx.c
> > index a49769a863..842399cc4c 100644
> > --- a/drivers/net/hinic/hinic_pmd_rx.c
> > +++ b/drivers/net/hinic/hinic_pmd_rx.c
> > @@ -4,7 +4,7 @@
> >
> >  #include <rte_ether.h>
> >  #include <rte_mbuf.h>
> > -#ifdef __ARM64_NEON__
> > +#ifdef RTE_ARCH_ARM64
>
> We can test '__ARM_NEON' which will be defined by compilers.
> https://developer.arm.com/documentation/ihi0053/latest/

On the principle, I agree, but this was not what was tested before.

The activation was only gated by checking for the arm architecture.
See: https://git.dpdk.org/dpdk/tree/drivers/net/hinic/Makefile?id=05b6eee7bdabf7c17ed69c44515e0cd7d6e1da23#n14
So I restored the test as it was before make removal.

What you propose can be done in a followup from the hinic developers,
but the minimal fix is still this current patch.


-- 
David Marchand

Re: [dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

[Ruifeng Wang]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, January 18, 2021 4:18 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; stable@dpdk.org; Ziyang Xuan
> <xuanziyang2@huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou
> <zhouguoyang@huawei.com>; Ciara Power <ciara.power@intel.com>;
> thomas@monjalon.net; nd <nd@arm.com>
> Subject: Re: [PATCH 1/3] net/hinic: restore vectorised code
> 
> On Sat, Jan 16, 2021 at 3:39 PM Ruifeng Wang <Ruifeng.Wang@arm.com>
> wrote:
> > > Subject: [PATCH 1/3] net/hinic: restore vectorised code
> > >
> > > Following make support removal, the vectorised code is not built
> > > anymore, fix the build flag check.
> > >
> > > Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > >  drivers/net/hinic/hinic_pmd_rx.c |  6 +++---
> > > drivers/net/hinic/hinic_pmd_tx.c | 10 +++++-----
> > >  2 files changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/net/hinic/hinic_pmd_rx.c
> > > b/drivers/net/hinic/hinic_pmd_rx.c
> > > index a49769a863..842399cc4c 100644
> > > --- a/drivers/net/hinic/hinic_pmd_rx.c
> > > +++ b/drivers/net/hinic/hinic_pmd_rx.c
> > > @@ -4,7 +4,7 @@
> > >
> > >  #include <rte_ether.h>
> > >  #include <rte_mbuf.h>
> > > -#ifdef __ARM64_NEON__
> > > +#ifdef RTE_ARCH_ARM64
> >
> > We can test '__ARM_NEON' which will be defined by compilers.
> > https://developer.arm.com/documentation/ihi0053/latest/
> 
> On the principle, I agree, but this was not what was tested before.
> 
> The activation was only gated by checking for the arm architecture.
> See:
> https://git.dpdk.org/dpdk/tree/drivers/net/hinic/Makefile?id=05b6eee7bda
> bf7c17ed69c44515e0cd7d6e1da23#n14
> So I restored the test as it was before make removal.
> 
> What you propose can be done in a followup from the hinic developers, but
> the minimal fix is still this current patch.

I'm OK with this.

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> 
> 
> --
> David Marchand

[dpdk-dev] [PATCH 2/3] net/i40e: remove vector config

[David Marchand]

This config item is not exposed anymore now that we removed make
support.
Note: all architectures provide vectorised functions.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/i40e/i40e_rxtx.c | 52 ------------------------------------
 drivers/net/i40e/meson.build |  3 ---
 2 files changed, 55 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 5df9a9df56..ff21db6b09 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -3444,58 +3444,6 @@ i40e_set_default_pctype_table(struct rte_eth_dev *dev)
 	}
 }
 
-#ifndef RTE_LIBRTE_I40E_INC_VECTOR
-int
-i40e_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
-{
-	return -1;
-}
-
-uint16_t
-i40e_recv_pkts_vec(
-	void __rte_unused *rx_queue,
-	struct rte_mbuf __rte_unused **rx_pkts,
-	uint16_t __rte_unused nb_pkts)
-{
-	return 0;
-}
-
-uint16_t
-i40e_recv_scattered_pkts_vec(
-	void __rte_unused *rx_queue,
-	struct rte_mbuf __rte_unused **rx_pkts,
-	uint16_t __rte_unused nb_pkts)
-{
-	return 0;
-}
-
-int
-i40e_rxq_vec_setup(struct i40e_rx_queue __rte_unused *rxq)
-{
-	return -1;
-}
-
-int
-i40e_txq_vec_setup(struct i40e_tx_queue __rte_unused *txq)
-{
-	return -1;
-}
-
-void
-i40e_rx_queue_release_mbufs_vec(struct i40e_rx_queue __rte_unused*rxq)
-{
-	return;
-}
-
-uint16_t
-i40e_xmit_fixed_burst_vec(void __rte_unused * tx_queue,
-			  struct rte_mbuf __rte_unused **tx_pkts,
-			  uint16_t __rte_unused nb_pkts)
-{
-	return 0;
-}
-#endif /* ifndef RTE_LIBRTE_I40E_INC_VECTOR */
-
 #ifndef CC_AVX2_SUPPORT
 uint16_t
 i40e_recv_pkts_vec_avx2(void __rte_unused *rx_queue,
diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
index 882168c256..bea4b18e3c 100644
--- a/drivers/net/i40e/meson.build
+++ b/drivers/net/i40e/meson.build
@@ -26,7 +26,6 @@ deps += ['hash']
 includes += include_directories('base')
 
 if arch_subdir == 'x86'
-	dpdk_conf.set('RTE_LIBRTE_I40E_INC_VECTOR', 1)
 	sources += files('i40e_rxtx_vec_sse.c')
 
 	# compile AVX2 version if either:
@@ -46,10 +45,8 @@ if arch_subdir == 'x86'
 		objs += i40e_avx2_lib.extract_objects('i40e_rxtx_vec_avx2.c')
 	endif
 elif arch_subdir == 'ppc'
-       dpdk_conf.set('RTE_LIBRTE_I40E_INC_VECTOR', 1)
        sources += files('i40e_rxtx_vec_altivec.c')
 elif arch_subdir == 'arm'
-       dpdk_conf.set('RTE_LIBRTE_I40E_INC_VECTOR', 1)
        sources += files('i40e_rxtx_vec_neon.c')
 endif
 
-- 
2.23.0

Re: [dpdk-dev] [PATCH 2/3] net/i40e: remove vector config

[Ferruh Yigit]

On 1/15/2021 1:40 PM, David Marchand wrote:
> This config item is not exposed anymore now that we removed make
> support.
> Note: all architectures provide vectorised functions.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

[dpdk-dev] [PATCH 3/3] net/fm10k: remove vector config

[David Marchand]

This config item is not exposed anymore now that we removed make
support.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/fm10k/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/fm10k/meson.build b/drivers/net/fm10k/meson.build
index fa264f489f..299b9ffb58 100644
--- a/drivers/net/fm10k/meson.build
+++ b/drivers/net/fm10k/meson.build
@@ -15,7 +15,6 @@ sources = files(
 	'fm10k_rxtx.c',
 )
 if arch_subdir == 'x86'
-	dpdk_conf.set('RTE_LIBRTE_FM10K_INC_VECTOR', 1)
 	sources += files('fm10k_rxtx_vec.c')
 endif
 
-- 
2.23.0

Re: [dpdk-dev] [PATCH 3/3] net/fm10k: remove vector config

[Ferruh Yigit]

On 1/15/2021 1:40 PM, David Marchand wrote:
> This config item is not exposed anymore now that we removed make
> support.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH 0/3] net build fixes

[Ferruh Yigit]

On 1/15/2021 1:40 PM, David Marchand wrote:
> Some fixes following make support removal.
> The first patch is a real fix.
> The other two are cleanups so I did not mark them for backport.
> 

Series applied to dpdk-next-net/main, thanks.