DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, Min Hu <humin29@huawei.com>,
	Wei Hu <xavier.huwei@huawei.com>,
	Chengwen Feng <fengchengwen@huawei.com>,
	Chengchang Tang <tangchengchang@huawei.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters
Date: Fri, 15 Jan 2021 15:52:32 +0000
Message-ID: <20210115155232.1406688-1-ferruh.yigit@intel.com> (raw)

The FEC APIs to get/set FEC mode has parameter name as 'fec_capa',
renamed them as 'fec_mode' to be more accurate with API.

No functional change.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Min Hu (Connor) <humin29@huawei.com>
Cc: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Cc: Chengwen Feng <fengchengwen@huawei.com>
Cc: Chengchang Tang <tangchengchang@huawei.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 lib/librte_ethdev/rte_ethdev.c        | 10 +++++-----
 lib/librte_ethdev/rte_ethdev.h        |  8 ++++----
 lib/librte_ethdev/rte_ethdev_driver.h |  8 ++++----
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 17ddacc78ded..332d7a789380 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3948,28 +3948,28 @@ rte_eth_fec_get_capability(uint16_t port_id,
 }
 
 int
-rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)
+rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode)
 {
 	struct rte_eth_dev *dev;
 
-	if (fec_capa == NULL)
+	if (fec_mode == NULL)
 		return -EINVAL;
 
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 	dev = &rte_eth_devices[port_id];
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP);
-	return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa));
+	return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode));
 }
 
 int
-rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa)
+rte_eth_fec_set(uint16_t port_id, uint32_t fec_mode)
 {
 	struct rte_eth_dev *dev;
 
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 	dev = &rte_eth_devices[port_id];
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP);
-	return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_capa));
+	return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_mode));
 }
 
 /*
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 2cbce958cf6c..0aefb7cb2f4a 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -3699,7 +3699,7 @@ int rte_eth_fec_get_capability(uint16_t port_id,
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
- * @param fec_capa
+ * @param fec_mode
  *   A bitmask of enabled FEC modes. If AUTO bit is set, other
  *   bits specify FEC modes which may be negotiated. If AUTO
  *   bit is clear, specify FEC modes to be used (only one valid
@@ -3712,7 +3712,7 @@ int rte_eth_fec_get_capability(uint16_t port_id,
  *   - (-ENODEV)  if *port_id* invalid.
  */
 __rte_experimental
-int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
+int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode);
 
 /**
  * @warning
@@ -3722,7 +3722,7 @@ int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
- * @param fec_capa
+ * @param fec_mode
  *   A bitmask of allowed FEC modes. If AUTO bit is set, other
  *   bits specify FEC modes which may be negotiated. If AUTO
  *   bit is clear, specify FEC modes to be used (only one valid
@@ -3735,7 +3735,7 @@ int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);
  *   - (-ENODEV)  if *port_id* invalid.
  */
 __rte_experimental
-int rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa);
+int rte_eth_fec_set(uint16_t port_id, uint32_t fec_mode);
 
 /**
  * Get current status of the Ethernet link flow control for Ethernet device
diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h
index 0eacfd842581..616a14d0361e 100644
--- a/lib/librte_ethdev/rte_ethdev_driver.h
+++ b/lib/librte_ethdev/rte_ethdev_driver.h
@@ -625,7 +625,7 @@ typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev,
  *
  * @param dev
  *   ethdev handle of port.
- * @param fec_capa
+ * @param fec_mode
  *   a bitmask of enabled FEC modes. If AUTO bit is set, other
  *   bits specify FEC modes which may be negotiated. If AUTO
  *   bit is clear, specify FEC modes to be used (only one valid
@@ -642,7 +642,7 @@ typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev,
  *   Device is removed.
  */
 typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev,
-			     uint32_t *fec_capa);
+			     uint32_t *fec_mode);
 
 /**
  * @internal
@@ -650,7 +650,7 @@ typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev,
  *
  * @param dev
  *   ethdev handle of port.
- * @param fec_capa
+ * @param fec_mode
  *   bitmask of allowed FEC modes. It must be only one
  *   if AUTO is disabled. If AUTO is enabled, other
  *   bits specify FEC modes which may be negotiated.
@@ -667,7 +667,7 @@ typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev,
  * @retval -EIO
  *   Device is removed.
  */
-typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t fec_capa);
+typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t fec_mode);
 
 /**
  * @internal
-- 
2.29.2


             reply	other threads:[~2021-01-15 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 15:52 Ferruh Yigit [this message]
2021-01-15 16:48 ` Ajit Khaparde
2021-01-16  1:48 ` Min Hu (Connor)
2021-01-29 16:54   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210115155232.1406688-1-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=humin29@huawei.com \
    --cc=tangchengchang@huawei.com \
    --cc=thomas@monjalon.net \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git