From: Qi Zhang <qi.z.zhang@intel.com>
To: thomas@monjalon.net
Cc: ferruh.yigit@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH v2] ethdev: refine doxygen for add UDP tunnel port API
Date: Tue, 19 Jan 2021 11:19:05 +0800 [thread overview]
Message-ID: <20210119031905.518082-1-qi.z.zhang@intel.com> (raw)
In-Reply-To: <20210112114703.350878-1-qi.z.zhang@intel.com>
Refine the doxygen for rte_eth_dev_udp_tunnel_port_add.
Add more detail description of the impacted offload functions.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
v2:
- reword doxygen that focus on API impact base on previous discussion.
lib/librte_ethdev/rte_ethdev.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index f758ec837..ab50a7039 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -4031,6 +4031,17 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,
* to change or add more UDP port for the tunnel. So the offloading function
* can take effect on the packets with the specific UDP port.
*
+ * The impacted offloading functions include:
+ *
+ * - A specific tunnel type in mbuf->packet_type
+ *
+ * - A rte_flow rule that matches on specific tunnel header
+ *
+ * NOTE: If a packet only has a matched UDP port but don't have a legal tunnel
+ * header, the packet may still not be recognized as a tunnel packet by
+ * the device parser, then the related offloading function will not take
+ * effect.
+ *
* @param port_id
* The port identifier of the Ethernet device.
* @param tunnel_udp
--
2.26.2
next prev parent reply other threads:[~2021-01-19 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 11:47 [dpdk-dev] [PATCH] ethdev: refine API description Qi Zhang
2021-01-15 15:51 ` Thomas Monjalon
2021-01-18 4:01 ` Zhang, Qi Z
2021-01-18 9:49 ` Thomas Monjalon
2021-01-19 0:47 ` Zhang, Qi Z
2021-01-19 3:19 ` Qi Zhang [this message]
2021-01-27 11:34 ` [dpdk-dev] [PATCH v2] ethdev: refine doxygen for add UDP tunnel port API Ferruh Yigit
2021-01-27 22:46 ` Thomas Monjalon
2021-02-03 20:02 ` [dpdk-dev] [PATCH v3 1/1] ethdev: refine doxygen comment of UDP tunnel API Thomas Monjalon
2021-02-06 10:40 ` Andrew Rybchenko
2021-02-10 11:20 ` Ferruh Yigit
2021-02-10 19:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119031905.518082-1-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).