From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA138A0A03; Tue, 19 Jan 2021 09:32:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61942140D45; Tue, 19 Jan 2021 09:32:30 +0100 (CET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id 6ABA2140D45 for ; Tue, 19 Jan 2021 09:32:28 +0100 (CET) Received: by mail-wr1-f48.google.com with SMTP id v15so15167694wrx.4 for ; Tue, 19 Jan 2021 00:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rqwiaJKObjUvTz0MFsnlJfT4UPQ77ql8JdcG+hCIsME=; b=IEyBWntJdhUlrBEcHtPf+/86WsLIHDT7v/myJZ/zoMDSge2awdMIQMbFMV2af1XfVr BC+Es9Cpk82AsMuqF1V593Y4BCGRg9DiiE+XnbsGO9e8KxGNPOGxksdXbDdr+q/vdDTX ByCr0ZNx2BiNCIsLX2r/v3XoDvRA4leTXCc6GpquKhrPR1JACt2xFGX/KxsJUuo1VHPc ZivlIlqmyX3eQT8jbs2OBrFLxMM3Vg2akmbVClYeqVWa6Xfr0mf5yPiSThmBLK8KsL9d j/WwvfnyiP5heyfG6hB/jDbOvckHwgkzTUXWGey/JwjOBvA79KTe0dNq1+4usWHOLVLI 1vkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rqwiaJKObjUvTz0MFsnlJfT4UPQ77ql8JdcG+hCIsME=; b=Suh+wohww/iSJczrWzMTEfRcO0fEFmqbfNdot62PxgIXp/gXQYFukGSo9HoE+/ibse s9x+DNm0SWag3GPNgQ04sckAk4gwdMKiZZAYkidrb4nVEh1Q8TpLUh1kcDoO0lOpkoZP 7+eH7bn3rA8AazCqHRonNuTjJ/nj23jtjHY2p6Q25gLbolX0VSrMGm9uT9YH3dZQU+/h nTElF9ZXydzt6vGK7uGNPf956Zh99uQ6GLsIOua3YG1Bxd7XrzGqekIZNoNDzykSUdXl Bj5KDC2W4TDqJKg+xCJmTSRP+IHH6+sYQE4YEksT0vJWo6Ew/SPZNS34MLhna+AjN2xY c/Wg== X-Gm-Message-State: AOAM531gmxYDjqeRblws0ELShSS/mnCIu7Us8WbSdPSOWWP58OseqEf7 MFyDgO/I2o9axEZp9/fWGocUtA== X-Google-Smtp-Source: ABdhPJzkQBWPc9a6hh4anKoJhfgrXvi0FIrtJ0lmSynC7OYbMvnTtseAE+hZ7wbOMekxPC01eimi9Q== X-Received: by 2002:adf:fa86:: with SMTP id h6mr3087645wrr.103.1611045148117; Tue, 19 Jan 2021 00:32:28 -0800 (PST) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id 62sm3505994wmd.34.2021.01.19.00.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 00:32:27 -0800 (PST) Date: Tue, 19 Jan 2021 09:32:26 +0100 From: Olivier Matz To: Ali Alnubani Cc: David Marchand , Ferruh Yigit , "zhaoyan.chen@intel.com" , dev , Andrew Rybchenko , "Ananyev, Konstantin" , Morten =?iso-8859-1?Q?Br=F8rup?= , "ajitkhaparde@gmail.com" , dpdk stable , Ajit Khaparde , Slava Ovsiienko , Alexander Kozyrev Message-ID: <20210119083226.GA2855@platinum> References: <20201104170007.8026-1-olivier.matz@6wind.com> <20210113132734.1636-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ali, On Mon, Jan 18, 2021 at 05:52:32PM +0000, Ali Alnubani wrote: > Hi, > (Sorry had to resend this to some recipients due to mail server problems). > > Just confirming that I can still reproduce the regression with single core and 64B frames on other servers. Many thanks for the feedback. Can you please detail what is the amount of performance loss in percent, and confirm the test case? (I suppose it is testpmd io forward). Unfortunatly, I won't be able to spend a lot of time on this soon (sorry for that). So I see at least these 2 options: - postpone the patch again, until I can find more time to analyze and optimize - apply the patch if the performance loss is acceptable compared to the added value of fixing a bug Regards, Olivier > > - Ali > > > -----Original Message----- > > From: Ali Alnubani > > Sent: Friday, January 15, 2021 8:39 PM > > To: David Marchand ; Olivier Matz > > ; Ferruh Yigit ; > > zhaoyan.chen@intel.com > > Cc: dev ; Andrew Rybchenko > > ; Ananyev, Konstantin > > ; Morten Brørup > > ; ajitkhaparde@gmail.com; dpdk stable > > ; Ajit Khaparde > > Subject: Re: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free > > > > Hi, > > Adding Ferruh and Zhaoyan, > > > > > Ali, > > > > > > You reported some performance regression, did you confirm it? > > > If I get no reply by monday, I'll proceed with this patch. > > > > Sure I'll confirm by Monday. > > > > Doesn't the regression also reproduce on the Lab's Intel servers? > > Even though the check iol-intel-Performance isn't failing, I can see that the > > throughput differences from expected for this patch are less than those of > > another patch that was tested only 20 minutes earlier. Both patches were > > applied to the same tree: > > > > https://mails.dpdk.org/archives/test-report/2021-January/173927.html > > > | 64 | 512 | 1.571 | > > > > https://mails.dpdk.org/archives/test-report/2021-January/173919.html > > > | 64 | 512 | 2.698 | > > > > Assuming that pw86457 doesn't have an effect on this test, it looks to me > > that this patch caused a regression in Intel hardware as well. > > > > Can someone update the baseline's expected values for the Intel NICs and > > rerun the test on this patch? > > > > Thanks, > > Ali