From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, navasile@linux.microsoft.com,
dmitrym@microsoft.com, pallavi.kadam@intel.com,
ferruh.yigit@intel.com, Beilei Xing <beilei.xing@intel.com>,
Jeff Guo <jia.guo@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Leyi Rong <leyi.rong@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 for Windows
Date: Wed, 20 Jan 2021 21:21:24 +0300 [thread overview]
Message-ID: <20210120212124.72fe1289@sovereign> (raw)
In-Reply-To: <20210120164016.26745-1-david.marchand@redhat.com>
On Wed, 20 Jan 2021 17:40:16 +0100, David Marchand wrote:
> There is probably better to do rather than disabling AVX512 globally for
> Windows but since I saw no patch fixing this, here it is.
>
> ---
> drivers/net/i40e/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
> index c0acdf4fd4..c9a1a50407 100644
> --- a/drivers/net/i40e/meson.build
> +++ b/drivers/net/i40e/meson.build
> @@ -54,7 +54,7 @@ if arch_subdir == 'x86'
> cc.has_argument('-mavx512f') and
> cc.has_argument('-mavx512bw'))
>
> - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
> + if not is_windows and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true)
> cflags += ['-DCC_AVX512_SUPPORT']
> avx512_args = [cflags, '-mavx512f', '-mavx512bw']
> if cc.has_argument('-march=skylake-avx512')
Clang doesn't seem to be affected, suggesting a cc.get_id() == 'gcc' check.
The error seems related to SEH (structured exception handling). Some MinGW
flavours don't use it, which can explain why the bug isn't not 100%
reproducible. IMO, just disabling AVX512 for MinGW is enough.
A nit, is there a reason to prefer "x == true" over "x"?
next prev parent reply other threads:[~2021-01-20 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:40 David Marchand
2021-01-20 17:46 ` David Marchand
2021-01-20 17:56 ` Ferruh Yigit
2021-01-20 18:21 ` Dmitry Kozlyuk [this message]
2021-01-20 18:24 ` Ferruh Yigit
2021-01-20 19:27 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120212124.72fe1289@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=leyi.rong@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).