From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B6439A09E4;
	Thu, 21 Jan 2021 10:43:42 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A232F140F47;
	Thu, 21 Jan 2021 10:43:42 +0100 (CET)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by mails.dpdk.org (Postfix) with ESMTP id 88B39140F46
 for <dev@dpdk.org>; Thu, 21 Jan 2021 10:43:40 +0100 (CET)
IronPort-SDR: xVHIF+e+GRY1yOO7pVg/pffXEFgW58BlTvQgunQTU8lw3mbdbJxm8J4kylF8CV589qVtrcosRj
 WA34Hd4G7oYw==
X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="166341867"
X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="166341867"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Jan 2021 01:43:39 -0800
IronPort-SDR: s02S9+75PiuBYBB7dDE8u5Y6g0+YrlXDJZEOAMLlaUaCMe4d+91R3OxnOoXIXNC+0jUakZnNcX
 bAu9fbu1TZEw==
X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="385236873"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.120])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 21 Jan 2021 01:43:38 -0800
Date: Thu, 21 Jan 2021 09:43:35 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>
Message-ID: <20210121094335.GB258@bricha3-MOBL.ger.corp.intel.com>
References: <20210114110606.21142-1-bruce.richardson@intel.com>
 <CAJFAV8xGhj02WdCboQDd7rJf7x=AL_MU_K4ZE6aFA+ikXVZkuw@mail.gmail.com>
 <20210121093352.GA258@bricha3-MOBL.ger.corp.intel.com>
 <4726085.tz9yOLTjxq@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4726085.tz9yOLTjxq@thomas>
Subject: Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote:
> 21/01/2021 10:33, Bruce Richardson:
> > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote:
> > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary?
> > >
> > Good question. The checks I was doing were only for missing headers.
> > Checking for superfluous headers is more complicated and not something I've
> > looked at. I know it was previously suggested to use the
> > "include-what-you-use" tool on DPDK, if anyone wants to attempt that.
> 
> I would love having an integration of include-what-you-use in our build system.
> I don't know whether it's trivial or difficult with meson.
> 
+1 to that.

I'm not familiar enough with the tool to comment on how hard or difficult
it would be. I try it once a few years ago, and I don't think I managed to
get it working successfully standalone, let alone as part of a build
system. However, I'm sure IWYU has moved on quite a bit since then...