From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C9C3CA0A0A;
	Fri, 22 Jan 2021 10:04:32 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6B354140DC6;
	Fri, 22 Jan 2021 10:04:32 +0100 (CET)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id B2EE1140DB2
 for <dev@dpdk.org>; Fri, 22 Jan 2021 10:04:31 +0100 (CET)
IronPort-SDR: DYSNvrWxP232oCG94hs64NVsaNyDLkermpfgGANPrBf4dc+xya8pORvOSDcDKPkWmTo6AmAvyy
 frtUs/i+CRtg==
X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240962304"
X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="240962304"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 22 Jan 2021 01:04:30 -0800
IronPort-SDR: FINOOJGbpihdKjKNA7fMO9mnYdD1ey8f9EgHHbPVWqs3BMnlla5tg6NmTwM8GQOhyk2oYenMtv
 urzp8ULGfREw==
X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427910737"
Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])
 by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 22 Jan 2021 01:04:27 -0800
From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com,
 thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,
 stevex.yang@intel.com, qiming.yang@intel.com
Date: Fri, 22 Jan 2021 09:01:07 +0000
Message-Id: <20210122090110.50453-1-stevex.yang@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201223085152.20866-1-stevex.yang@intel.com>
References: <20201223085152.20866-1-stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v3 0/3] fix 'max-pkt-len' errors
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Here fixed 3 issues for 'max-pkt-len':
1. When cmdline option '--max-pkt-len' set the value less then
   '1500 + overhead', the app/testpmd will force to resize the 'max-pkt-len'
   to '1500 + overhead'. However, the user really want to configure
   'max-pkt-len' to a specified value (< 1500 + overhead);

2. If the large value of '--max-pkt-len' gave (e.g.: 8000), and user want to
   reset the value to a small one (e.g.: 1400), it will became invalid due to
   JUMBO_FRAME offload state doesn't change before port started;

3. When rx/tx queue offloads capabilities aren't specified, the rx/tx queue
   setup will be failed once the port offloads changed.

---
v3:
 * rebased code to latest;
 * splited to 3 commits;

v2:
 * moved the update logic to 'rxtx_port_config';
 * added the 'tx_conf' part;
 * optimized the 'default' assignment;
---

Steve Yang (3):
  ethdev: fix MTU doesn't update when jumbo frame disabled
  app/testpmd: fix max-pkt-len option invalid
  app/testpmd: fix dynamic config error

 app/test-pmd/cmdline.c         |  1 +
 app/test-pmd/parameters.c      |  1 +
 app/test-pmd/testpmd.c         | 59 +++++++++++++++++++++++-----------
 app/test-pmd/testpmd.h         |  2 ++
 lib/librte_ethdev/rte_ethdev.c |  8 ++---
 5 files changed, 48 insertions(+), 23 deletions(-)

-- 
2.17.1