From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38F88A0A0A; Fri, 22 Jan 2021 21:31:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B30AA14119C; Fri, 22 Jan 2021 21:31:20 +0100 (CET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by mails.dpdk.org (Postfix) with ESMTP id 61EC414116B for ; Fri, 22 Jan 2021 21:31:19 +0100 (CET) Received: by mail-lj1-f178.google.com with SMTP id b10so7996785ljp.6 for ; Fri, 22 Jan 2021 12:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2spfESoV4muEtJWotWUo91om9my3mffaY4y16k1H90c=; b=AMn8U8cHG+FfP6Z2XWcy/6IprS19qdD74LwWlVKOOpgWFgGyQXO057iYe1OAx6x/OE IfAxzLsSCGKz7p1w2FABWcMIq+2DNuFYASDJo50KNjUfGRtX1dZ1yEN7uTHV1kVJDuQU 2hi0W9qoOy1x5dmJ3A5tAfl39QWpWSRSV8EvoQRe3QWGeiM7m9Qdto7RwouDNgHCVfr4 qApgXCyzqyylLrc18NtXkWmYgnL+M3rhJBfompUAgs3YILwP6XxlG/hiCaNSnDYsPu6D JGW4DTeA76nzaICIbzaA6HjNn/aDrH53EV3BFjzZ8u03hU7HmuocRpKP2i9wdbO41IK8 /1GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2spfESoV4muEtJWotWUo91om9my3mffaY4y16k1H90c=; b=WhhWwStW1RfAEgvbTb5K1Py50ZrtFMp5+/7YCFIZKteGyYRO1N4bfFvXEoetFtw3R2 QDRV/o+wfCFaeY5S0xjeDU1L4yQ1FlAil/NDvjj2846/qolMlSSE+ivyY9Q6BJmtn4cn tuUjSQq2czMTBlcmDcouyx1KG8GlqnEKVjB1mK6yXEtmqz2y7Jw4yxeeBerlLXSqmFx8 LDOSbofyaxs2qvul7lfl/iu4w6Bx2qY80Aue1QQHGYy5nggi4wONVHvGm+w2Z5exN+jU LkVYIKb4q4wFQZgTTAidF5TmcEeXMxSwoHXgV++ZpLgLkJc2tEQICROIlSc0B8/iby3+ +DCQ== X-Gm-Message-State: AOAM531JbyveqHlTgB+/M/ua1LkTV9cFR1H6Y7Bc1R/KGzPOgNNBx/u9 6Vrvs5mn2Vd64EWqor6MOX4= X-Google-Smtp-Source: ABdhPJyELxTv6ifjFLZzEjwEU9mMm4bE7p0FsNttTEcv4fJxI9U0vBfij7DUKiWioOX+YPoZhVUT3g== X-Received: by 2002:a2e:90cb:: with SMTP id o11mr223830ljg.60.1611347478960; Fri, 22 Jan 2021 12:31:18 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b18sm213713lfj.140.2021.01.22.12.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 12:31:17 -0800 (PST) Date: Fri, 22 Jan 2021 23:31:16 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com Message-ID: <20210122233116.31d1538b@sovereign> In-Reply-To: <2534344.1dmFBEvUxf@thomas> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <5629972.kJsfQy86Dy@thomas> <20210120102314.0235dfc1@sovereign> <2534344.1dmFBEvUxf@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > 20/01/2021 08:23, Dmitry Kozlyuk: > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > This is now the right timeframe to introduce this change > > > with the new Python module dependency. > > > Unfortunately, the ABI check is returning an issue: > > > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > > > Will investigate and fix ASAP. Now that I think of it: strings like this change every time new PCI IDs are added to a PMD, but AFAIK adding PCI IDs is not considered an ABI breakage, is it? One example is 28c9a7d7b48e ("net/mlx5: add ConnectX-6 Lx device ID") added 2020-07-08, i.e. clearly outside of ABI change window. "xxx_pmd_info" changes are due to JSON formatting (new is more canonical), which can be worked around easily, if the above is wrong. > > > > --- a/meson.build > > > > +++ b/meson.build > > > > -subdir('buildtools/pmdinfogen') > > > > > > This could be in patch 3 (removing the code). > > > > It would redefine "pmdinfogen" variable to old pmdinfogen. > > Besides, why build what's not used at this patch already? > > Just trying to find the best patch split. > If needed, OK to keep as is. I even don't mind squashing all three commits into one. The split is done to ease the review.