DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling
@ 2021-01-25 11:44 Haiyue Wang
  2021-01-26  3:25 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2021-01-25 11:44 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Haiyue Wang, Jingjing Wu, Beilei Xing

Change the fatal returning to print the error message only, so that the
VF device can continue to be configured.

Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 8e741031ec..af655084d2 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -429,10 +429,8 @@ iavf_dev_configure(struct rte_eth_dev *dev)
 	}
 
 	ret = iavf_dev_init_vlan(dev);
-	if (ret) {
+	if (ret)
 		PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret);
-		return -1;
-	}
 
 	if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {
 		if (iavf_init_rss(ad) != 0) {
-- 
2.30.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling
  2021-01-25 11:44 [dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling Haiyue Wang
@ 2021-01-26  3:25 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-01-26  3:25 UTC (permalink / raw)
  To: Wang, Haiyue, dev; +Cc: Yang, Qiming, Wu, Jingjing, Xing, Beilei



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Monday, January 25, 2021 7:44 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH v1] net/iavf: adjust the VLAN failure handling
> 
> Change the fatal returning to print the error message only, so that the VF
> device can continue to be configured.
> 
> Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-26  3:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 11:44 [dpdk-dev] [PATCH v1] net/iavf: adjust the VLAN failure handling Haiyue Wang
2021-01-26  3:25 ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).