DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Kozyrev <akozyrev@nvidia.com>
Cc: dev@dpdk.org, viacheslavo@nvidia.com, orika@nvidia.com,
	thomas@monjalon.net, ferruh.yigit@intel.com,
	andrew.rybchenko@oktetlabs.ru, jerinjacobk@gmail.com,
	ajit.khaparde@broadcom.com
Subject: Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
Date: Mon, 25 Jan 2021 19:43:54 -0800	[thread overview]
Message-ID: <20210125194354.5b2fccdc@hermes.local> (raw)
In-Reply-To: <20210126033824.29175-1-akozyrev@nvidia.com>

On Tue, 26 Jan 2021 03:38:24 +0000
Alexander Kozyrev <akozyrev@nvidia.com> wrote:

> IPv6 DSCP field ID is missing from the original list of Field IDs
> for MODIFY_FIELD action. Add it to support IPv6 header fully.
> 
> Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
>  lib/librte_ethdev/rte_flow.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 46e8ee70ab..68c68cdd6c 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
>  	RTE_FLOW_FIELD_IPV4_TTL,
>  	RTE_FLOW_FIELD_IPV4_SRC,
>  	RTE_FLOW_FIELD_IPV4_DST,
> +	RTE_FLOW_FIELD_IPV6_DSCP,
>  	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
>  	RTE_FLOW_FIELD_IPV6_SRC,
>  	RTE_FLOW_FIELD_IPV6_DST,

Adding field in middle of enum will break ABI.

  reply	other threads:[~2021-01-26  5:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  3:38 Alexander Kozyrev
2021-01-26  3:43 ` Stephen Hemminger [this message]
2021-01-26  5:21   ` Alexander Kozyrev
2021-01-26  5:35     ` Ajit Khaparde
2021-01-26  5:44     ` Stephen Hemminger
2021-01-26  5:36 ` Ajit Khaparde
2021-01-26 15:13 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
2021-01-27 11:52   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125194354.5b2fccdc@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=akozyrev@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=orika@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).