From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE11A052A; Tue, 26 Jan 2021 06:44:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF6F9141225; Tue, 26 Jan 2021 06:44:16 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id CC05C141222 for ; Tue, 26 Jan 2021 06:44:14 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id u67so9861249pfb.3 for ; Mon, 25 Jan 2021 21:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m4wAfqvtxoMnGg34T7sEezIr/0wdYVgMI/nmneAz7QY=; b=saiTYfEQoMLyxh44IaJjKqPANashwSh4zsfh3g0UdgY8TwJRw/PE2dPpvzJMEOOs3e B764v7rbVZhBg/ro+btwMtJR3/uPiYlFwO9izOClR9dnkdZh9f+n3wAvG3XMs4WGB7Ef EH32fr1md/Xvs4aVqpVTg1fpQeZkONL2pn7ukYd0n8J8bjQ+0OPm39vG6uE402eIXNjz XptfmbpCneQWFPSFh5RCHde81H7r72PJTAN2mj4oAeHO37d9A71dOiofS9K7yA9YGPtD jEg6uCl5eWdHm09EsuXznQRydQEeNpN67OEWp/i0ZfrY5Ld0UIHruAsZlKsnUGa4s1Xb akKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m4wAfqvtxoMnGg34T7sEezIr/0wdYVgMI/nmneAz7QY=; b=fUkKpU7FJE0bKWFWKFRRxGo7iSG/6HBsPl9AwNvPTHvlB+gakBQnGmYshTNgKvnCJQ WMuO9O9fYlAp5FsYGB18QQBg03G62i9X9EjU+wtyv/yVEbh9mMPwY/xhQTccqe4n+Zk7 QX7zbKQRXnWm1STucRgsWRJk/eP4hUAwzrZFmYprs8qwhFeIEg8Si4umxyTCG11YUtMo E23E5gQj/3ej+0OFY7DOpoPQMzt0LOFm34nHJWdNIGLZH5map/zzZf9SlPsnhkSWwKbv NKxmpNIW3OUWPK9RCppzRUGWTk1FGJEcmB+xE2pk/XyYQIAZesM4RaBbjc6F5sBg2kU4 d4ZQ== X-Gm-Message-State: AOAM531I2ItiGPMYh7kgwodq7eA8BusHa2NY6l5/wO8pjBrKLSx3Xj0V kz9v3udfWZw6SkB45rKKr6+UDQ== X-Google-Smtp-Source: ABdhPJyrzYSWE0US/ieuHV8pE9khnfkvCngOtBcY5Ucu7cw+g1PZi9ZBfVNLxprF1ul2Y28FxBQGYw== X-Received: by 2002:aa7:909a:0:b029:1bc:22d3:9e58 with SMTP id i26-20020aa7909a0000b02901bc22d39e58mr3742432pfa.29.1611639853983; Mon, 25 Jan 2021 21:44:13 -0800 (PST) Received: from hermes.local (76-14-222-244.or.wavecable.com. [76.14.222.244]) by smtp.gmail.com with ESMTPSA id w184sm18927582pgb.71.2021.01.25.21.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 21:44:13 -0800 (PST) Date: Mon, 25 Jan 2021 21:44:05 -0800 From: Stephen Hemminger To: Alexander Kozyrev Cc: "dev@dpdk.org" , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "jerinjacobk@gmail.com" , "ajit.khaparde@broadcom.com" Message-ID: <20210125214405.1984676c@hermes.local> In-Reply-To: References: <20210126033824.29175-1-akozyrev@nvidia.com> <20210125194354.5b2fccdc@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 26 Jan 2021 05:21:23 +0000 Alexander Kozyrev wrote: > > From: Stephen Hemminger on Monday, January 25, 2021 22:44 > > > > On Tue, 26 Jan 2021 03:38:24 +0000 > > Alexander Kozyrev wrote: > > > > > IPv6 DSCP field ID is missing from the original list of Field IDs > > > for MODIFY_FIELD action. Add it to support IPv6 header fully. > > > > > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action") > > > > > > Signed-off-by: Alexander Kozyrev > > > --- > > > lib/librte_ethdev/rte_flow.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > > index 46e8ee70ab..68c68cdd6c 100644 > > > --- a/lib/librte_ethdev/rte_flow.h > > > +++ b/lib/librte_ethdev/rte_flow.h > > > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id { > > > RTE_FLOW_FIELD_IPV4_TTL, > > > RTE_FLOW_FIELD_IPV4_SRC, > > > RTE_FLOW_FIELD_IPV4_DST, > > > + RTE_FLOW_FIELD_IPV6_DSCP, > > > RTE_FLOW_FIELD_IPV6_HOPLIMIT, > > > RTE_FLOW_FIELD_IPV6_SRC, > > > RTE_FLOW_FIELD_IPV6_DST, > > > > Adding field in middle of enum will break ABI. > > I added the rte_flow_field_id enum a week ago into 20.11-rc1. > I believe it is not too late to make it right without breaking ABI, don't you think so? Ok if not in release yet