From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69D9DA052A; Tue, 26 Jan 2021 16:42:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58FF7140E18; Tue, 26 Jan 2021 16:42:38 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 68C51140E11 for ; Tue, 26 Jan 2021 16:42:36 +0100 (CET) IronPort-SDR: LxpwouywFdqBbpsNVYIxcnIjRFgSun8BTuvW+qHhl5GPsOmHKiwYqt6bur4k7nsff4As4UrK2g F0YFgjo8TbBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="159695255" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="159695255" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:42:35 -0800 IronPort-SDR: tcT8Blg8u+Osh7JTIbq43c93fbOD/p3pTuADX2DTZeXnEIbGpXbrlsztiqIqoECOwdySkNpU5y NbUBIMhwKreQ== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="429748695" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.198]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Jan 2021 07:42:33 -0800 Date: Tue, 26 Jan 2021 15:42:30 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , dev , ferruh.yigit@intel.com Message-ID: <20210126154230.GE239@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210126142402.GB239@bricha3-MOBL.ger.corp.intel.com> <20210126143925.GC239@bricha3-MOBL.ger.corp.intel.com> <2592228.fJoplo53l3@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2592228.fJoplo53l3@thomas> Subject: Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote: > 26/01/2021 15:39, Bruce Richardson: > > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed > > throw up the errors with clang - but not gcc, which is strange. The > > offending headers seem to be (initially): > > > > * rte_ethdev_vdev.h > > * rte_ethdev_pci.h > > > > Are these public header files, or should they skip header checking - and > > installation - as internal-only? > > They are helpers for the drivers, so should be internal. > Just to confirm, by that you mean that they should not be installed for end-application use? In which case, I believe that "rte_ethdev_driver", "rte_ethdev_vdev" and "rte_ethdev_pci" should be removed from the "headers" list in "librte_ethdev/meson.build". Current file list there is: headers = files('rte_ethdev.h', 'rte_ethdev_driver.h', 'rte_ethdev_pci.h', 'rte_ethdev_trace.h', 'rte_ethdev_trace_fp.h', 'rte_ethdev_vdev.h', 'rte_dev_info.h', 'rte_flow.h', 'rte_flow_driver.h', 'rte_mtr.h', 'rte_mtr_driver.h', 'rte_tm.h', 'rte_tm_driver.h') headers_no_chkincs += files('rte_eth_ctrl.h', 'rte_ethdev_core.h') [Note that the "headers_no_chkincs" files still get installed, they just skip header checking as indirect includes.] Anything else that should be removed. Also, tangential to this, it would probably be good if we could come up with a different naming scheme for internal-only headers, to make the difference between what is to be installed or not, a lot clearer! /Bruce