From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DDCDA052A; Tue, 26 Jan 2021 16:57:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB722140D62; Tue, 26 Jan 2021 16:57:48 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B0D87140D5B for ; Tue, 26 Jan 2021 16:57:45 +0100 (CET) IronPort-SDR: Sw2LrRztNxNUwqDkAHZWbOq6KuIsaY6d1BfbFzxt+4jU6jsFMvfreL6nrwg1LiJ4X64FMe04zM SkmYz7wWjKcw== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="198710494" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="198710494" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 07:57:44 -0800 IronPort-SDR: 7VpfHyiqkMKOUaYkKEDJEYpxw7MYY5o+WNPTsiruSADXYGm5z9gd1sP17v0mpXDskF5Rg32xkr b4Bt0EpPE/ww== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="472790626" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.19.198]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Jan 2021 07:57:22 -0800 Date: Tue, 26 Jan 2021 15:57:19 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, Ruifeng Wang , Juraj =?utf-8?Q?Linke=C5=A1?= , david.marchand@redhat.com, bluca@debian.org Message-ID: <20210126155719.GF239@bricha3-MOBL.ger.corp.intel.com> References: <20210126150722.4018058-1-thomas@monjalon.net> <20210126153230.GD239@bricha3-MOBL.ger.corp.intel.com> <14391069.5Q96cbInNX@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14391069.5Q96cbInNX@thomas> Subject: Re: [dpdk-dev] [PATCH 1/1] doc: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 26, 2021 at 04:35:16PM +0100, Thomas Monjalon wrote: > 26/01/2021 16:32, Bruce Richardson: > > On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote: > > > When removing the label "arm_cross_build_getting_the_prerequisite_library" > > > in the rework of cross_build_dpdk_for_arm64.rst, > > > the reference to this section got broken. > > > It went unnoticed because "ninja -C doc" does not regenerate the file > > > which is referencing the changed file. > > > > > Do we know why this is? The doc builds should be doing proper dependency > > tracking, based off the output from sphinx IIRC. > > It seems it is building only the changed files. > I don't understand the logic in buildtools/call-sphinx-build.py > That needs some investigation, but it may be sphinx which is at fault rather than the DPDK build. Most of the extra work done in the wrapper is processing the files list worked by sphinx so we can mark them as dependencies of the doc target. Sphinx itself does the incremental builds of only changed files. Unfortunately I don't have time to dig into this more right now.