DPDK patches and discussions
 help / color / mirror / Atom feed
From: Michal Krawczyk <mk@semihalf.com>
To: dev@dpdk.org
Cc: gtzalik@amazon.com, igorch@amazon.com, mw@semihalf.com,
	Amit Bernstein <amitbern@amazon.com>,
	stable@dpdk.org, Michal Krawczyk <mk@semihalf.com>
Subject: [dpdk-dev] [PATCH v2 2/5] net/ena: Tx doorbell statistics fix
Date: Tue, 26 Jan 2021 19:32:23 +0100	[thread overview]
Message-ID: <20210126183226.2420903-3-mk@semihalf.com> (raw)
In-Reply-To: <20210126183226.2420903-1-mk@semihalf.com>

From: Amit Bernstein <amitbern@amazon.com>

Increment Tx doorbell statistics on tx_pkt_burst
after writing to doorbell and in case max burst size achieved

Fixes: c7519ea5eb8d ("net/ena: call additional doorbells if needed")
Cc: stable@dpdk.org

Signed-off-by: Amit Bernstein <amitbern@amazon.com>
Reviewed-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 516e244295..111e830bfa 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2519,6 +2519,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)
 			"llq tx max burst size of queue %d achieved, writing doorbell to send burst\n",
 			tx_ring->id);
 		ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);
+		tx_ring->tx_stats.doorbells++;
 	}
 
 	/* prepare the packet's descriptors to dma engine */
-- 
2.25.1


  parent reply	other threads:[~2021-01-26 18:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 18:32 [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 1/5] net/ena: flush Rx buffers memory pool cache Michal Krawczyk
2021-01-26 18:32 ` Michal Krawczyk [this message]
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 3/5] net/ena: validate Rx req id upon acquiring the desc Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment Michal Krawczyk
2021-01-29 12:07   ` Ferruh Yigit
2021-01-29 12:16     ` Michał Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 5/5] net/ena: prevent double doorbell Michal Krawczyk
2021-01-29 12:07   ` Ferruh Yigit
2021-01-29 12:17 ` [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements Ferruh Yigit
2021-01-29 12:33   ` Michał Krawczyk
2021-01-29 15:15     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126183226.2420903-3-mk@semihalf.com \
    --to=mk@semihalf.com \
    --cc=amitbern@amazon.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mw@semihalf.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).