The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode. Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> --- drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ice/base/ice_vlan_mode.c b/drivers/net/ice/base/ice_vlan_mode.c index 2e4c3f62c4..460c4f902b 100644 --- a/drivers/net/ice/base/ice_vlan_mode.c +++ b/drivers/net/ice/base/ice_vlan_mode.c @@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw *hw) */ enum ice_status ice_set_vlan_mode(struct ice_hw *hw) { + /* DCF only has the ability to query the VLAN mode. Setting the VLAN + * mode is done by the PF. + */ + if (hw->dcf_enabled) + return ICE_SUCCESS; + if (!ice_is_dvm_supported(hw)) return ICE_SUCCESS; -- 2.30.0
Acked-by: Qiming Yang <qiming.yang@intel.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, January 28, 2021 00:05
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
>
> The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ice/base/ice_vlan_mode.c
> b/drivers/net/ice/base/ice_vlan_mode.c
> index 2e4c3f62c4..460c4f902b 100644
> --- a/drivers/net/ice/base/ice_vlan_mode.c
> +++ b/drivers/net/ice/base/ice_vlan_mode.c
> @@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw
> *hw)
> */
> enum ice_status ice_set_vlan_mode(struct ice_hw *hw) {
> + /* DCF only has the ability to query the VLAN mode. Setting the VLAN
> + * mode is done by the PF.
> + */
> + if (hw->dcf_enabled)
> + return ICE_SUCCESS;
> +
> if (!ice_is_dvm_supported(hw))
> return ICE_SUCCESS;
>
> --
> 2.30.0
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, January 28, 2021 4:22 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
>
> Acked-by: Qiming Yang <qiming.yang@intel.com>
>
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Thursday, January 28, 2021 00:05
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> > Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
> >
> > The PF will set the VLAN mode globally, DCF just needs to get the VLAN
> mode.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi