From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6DF50A052A;
Wed, 27 Jan 2021 17:11:08 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 21EA2140ED6;
Wed, 27 Jan 2021 17:10:14 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id 512EF140EC8;
Wed, 27 Jan 2021 17:10:10 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id
10RG62XB017163; Wed, 27 Jan 2021 08:10:09 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=pfpt0220;
bh=p2PwKgAvRDbGvNUJlgnfFVeZMN+BcQtuepa2vv79z7s=;
b=UK9aC1HEPbIOCdd4azhgBEZo/rJ1+KBNJZdjheoao0HAuqmPdoef28Q2Zsrr8qO2XhuQ
CIkvfiMzKwzOnhrzSkL9V5P7QJ9MNnfjk3WM9ZL3aR4ogfsmxswezmNyqQfJ0zn8b3D4
MQrmmzRrtrLq5vj8tgfWrqc7uw7mZ4ZvIzGWIYELajRDPWxN7u2UxQ3y83sNFEsBfNMW
H4T/KxJ1CqzrDAF3h8NuxMa82pM1Qtm+deVB6rGMd+CTw9lj1mIWSWvTZ1m1BFBv1fph
r8qsHTHt4zpbZTADCvfz3DTttwAVt6L0mYBdgmpF7PGnYE7uGlmQdfR0RomLRSFERlHy Gg==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0b-0016f401.pphosted.com with ESMTP id 36b1xphfru-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Wed, 27 Jan 2021 08:10:09 -0800
Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Wed, 27 Jan 2021 08:10:07 -0800
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com
(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Wed, 27 Jan 2021 08:10:06 -0800
Received: from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend
Transport; Wed, 27 Jan 2021 08:10:05 -0800
From: <lironh@marvell.com>
To: <jerinj@marvell.com>, <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, Liron Himi <lironh@marvell.com>, <stable@dpdk.org>, "Yuri
Chipchev" <yuric@marvell.com>
Date: Wed, 27 Jan 2021 18:09:18 +0200
Message-ID: <20210127160948.6008-5-lironh@marvell.com>
X-Mailer: git-send-email 2.28.0
In-Reply-To: <20210127160948.6008-1-lironh@marvell.com>
References: <20210122191925.24308-1-lironh@marvell.com>
<20210127160948.6008-1-lironh@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737
definitions=2021-01-27_05:2021-01-27,
2021-01-27 signatures=0
Subject: [dpdk-dev] [PATCH v3 04/34] net/mvpp2: remove CRC len from MRU
validation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Liron Himi <lironh@marvell.com>
CRC is being removed by HW before packet get
write to the buffer, so CRC len should not be
included in MRU validation
Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations")
Cc: stable@dpdk.org
Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Yuri Chipchev <yuric@marvell.com>
---
drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 0c338c0c00..eafe4f7ac9 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -441,8 +441,8 @@ mrvl_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
* when this feature has not been enabled/supported so far
* (TODO check scattered_rx flag here once scattered RX is supported).
*/
- if (mru + MRVL_PKT_OFFS > mbuf_data_size) {
- mru = mbuf_data_size - MRVL_PKT_OFFS;
+ if (mru - RTE_ETHER_CRC_LEN + MRVL_PKT_OFFS > mbuf_data_size) {
+ mru = mbuf_data_size + RTE_ETHER_CRC_LEN - MRVL_PKT_OFFS;
mtu = MRVL_PP2_MRU_TO_MTU(mru);
MRVL_LOG(WARNING, "MTU too big, max MTU possible limitted "
"by current mbuf size: %u. Set MTU to %u, MRU to %u",
--
2.28.0