From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 68FF0A052A;
	Wed, 27 Jan 2021 17:11:19 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7878B140EA8;
	Wed, 27 Jan 2021 17:10:15 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
 [67.231.148.174])
 by mails.dpdk.org (Postfix) with ESMTP id 61DC4140EC8;
 Wed, 27 Jan 2021 17:10:11 +0100 (CET)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
 by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id
 10RG5eQU027133; Wed, 27 Jan 2021 08:10:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
 h=from : to : cc :
 subject : date : message-id : in-reply-to : references : mime-version :
 content-transfer-encoding : content-type; s=pfpt0220;
 bh=5fNXDILtn+hmAEVko6L6QU6Huhq5PRgPmhA7j5wW5VI=;
 b=bVL57IARSXWXYpIfNEQ6/2b4oCOxG095ZFVbHT7+fypeW7qsGsWqdT+8E4M8pFSYnVX+
 xRI9X0wwCuJD0DsuxAyKpl8YyfV6mUakInjmoYUKwbbi0KzYGbHRnhyttsmEyPJCGfAv
 PjtCKpC6Ve2fWW8bb1cZPXNIZrz8XU7d6PUgmds6awSkduRQi2O742i/n8iYwZ++aZS8
 TArJGKz3XsQFFEX1WR6/B82+fSxM6ngIzIYXDMbFb2XAks22d0/UZWdMR2hwKqX2Fxcc
 ZPeBW6bOotDAYmyxmH947igRgupvkB2RbahN0plWBaQAu7O8juIuvJJ/Pje4ps6nd61M iQ== 
Received: from dc5-exch02.marvell.com ([199.233.59.182])
 by mx0a-0016f401.pphosted.com with ESMTP id 368j1uc37m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
 Wed, 27 Jan 2021 08:10:10 -0800
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com
 (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
 Wed, 27 Jan 2021 08:10:09 -0800
Received: from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com
 (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend
 Transport; Wed, 27 Jan 2021 08:10:07 -0800
From: <lironh@marvell.com>
To: <jerinj@marvell.com>, <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, Liron Himi <lironh@marvell.com>, <stable@dpdk.org>, "Yuri
 Chipchev" <yuric@marvell.com>
Date: Wed, 27 Jan 2021 18:09:19 +0200
Message-ID: <20210127160948.6008-6-lironh@marvell.com>
X-Mailer: git-send-email 2.28.0
In-Reply-To: <20210127160948.6008-1-lironh@marvell.com>
References: <20210122191925.24308-1-lironh@marvell.com>
 <20210127160948.6008-1-lironh@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737
 definitions=2021-01-27_05:2021-01-27,
 2021-01-27 signatures=0
Subject: [dpdk-dev] [PATCH v3 05/34] net/mvpp2: fix frame size checking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

From: Liron Himi <lironh@marvell.com>

Need to add CRC len to the frame-size to compare against
max_rx_pkt_len which includes it.

Fixes: 79ec62028 ("net/mvpp2: update MTU and MRU related calculations")
Cc: stable@dpdk.org

Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Yuri Chipchev <yuric@marvell.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index eafe4f7ac9..6cd5acd337 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -1699,7 +1699,8 @@ mrvl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
 		return -EFAULT;
 	}
 
-	frame_size = buf_size - RTE_PKTMBUF_HEADROOM - MRVL_PKT_EFFEC_OFFS;
+	frame_size = buf_size - RTE_PKTMBUF_HEADROOM -
+		     MRVL_PKT_EFFEC_OFFS + RTE_ETHER_CRC_LEN;
 	if (frame_size < max_rx_pkt_len) {
 		MRVL_LOG(WARNING,
 			"Mbuf size must be increased to %u bytes to hold up "
-- 
2.28.0