From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C363A09E4; Thu, 28 Jan 2021 12:41:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC2C54067B; Thu, 28 Jan 2021 12:41:53 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2B67F4067A for <dev@dpdk.org>; Thu, 28 Jan 2021 12:41:52 +0100 (CET) IronPort-SDR: PhQkpOq5iaKQCAujysJ173k0A/BeDzelyVAmb3BASiIwX8uoMP6CCgbKZMRerjdQo5mJ20lIv5 B7tdISHRCu2w== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="265051845" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="265051845" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:41:51 -0800 IronPort-SDR: 1mNDKhT4bgTSG8OnvA/VkAvyurd0x6QXzHInDs4eDpit8QVvPBor70BWeiy9YHvHgx5CDsKVBR Qa6k0wq2sQJg== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="388769070" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.53]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Jan 2021 03:41:49 -0800 Date: Thu, 28 Jan 2021 11:41:44 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, david.marchand@redhat.com, Aaron Conole <aconole@redhat.com>, Michael Santana <maicolgabriel@hotmail.com> Message-ID: <20210128114144.GF899@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-9-bruce.richardson@intel.com> <3749594.2Ve71FdZX2@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3749594.2Ve71FdZX2@thomas> Subject: Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Jan 28, 2021 at 12:12:44PM +0100, Thomas Monjalon wrote: > 27/01/2021 18:33, Bruce Richardson: > > For CI builds, turn on the checking of includes. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: > > Aaron Conole <aconole@redhat.com> --- .ci/linux-build.sh | 1 + 1 file > > changed, 1 insertion(+) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index > > afa3689a09..fdbeb5a616 100755 --- a/.ci/linux-build.sh +++ > > b/.ci/linux-build.sh @@ -57,6 +57,7 @@ fi OPTS="$OPTS > > -Dmachine=default" OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS > > --buildtype=debugoptimized" +OPTS="$OPTS -Dcheck_includes=true" > > Which percentage of time does it add on GHA? > I'd have to gather some before/after tests to know for sure, but to check it wasn't too heavy-weight I was just monitoring the log at the end of a build on GHA. The specific build I watched took nearly 15 minutes, and I would guess-timate that the extra task took about 20 seconds of that.