From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3639A09E4; Thu, 28 Jan 2021 12:49:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0F9A4067A; Thu, 28 Jan 2021 12:49:04 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5E18740395 for ; Thu, 28 Jan 2021 12:49:03 +0100 (CET) IronPort-SDR: PlyMHkBIZoXmXo+ZLe6rZMCyj1nZkMZc4aY8c7NNMMNMnE7yOP4FyS0Qf0R8d8jXN9xpRUgqdU chMXbNymGF+w== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="199052688" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="199052688" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:49:02 -0800 IronPort-SDR: W6LtLkKEPQMXYibodEnqrZ5zqrF/UbEzPfgBw1m9x0ugisPKyT7j7iWTYTBWxwJXEbIeCHSdiq /6opvddPFX9Q== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="388774765" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.53]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Jan 2021 03:49:01 -0800 Date: Thu, 28 Jan 2021 11:48:58 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Thomas Monjalon Message-ID: <20210128114858.GH899@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-7-bruce.richardson@intel.com> <20210128112719.GD899@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 28, 2021 at 12:31:20PM +0100, David Marchand wrote: > On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson > wrote: > > > > +# some ethdev headers depend on bus headers > > > > +includes = include_directories('../../drivers/bus/pci', > > > > + '../../drivers/bus/vdev') > > > > > > ethdev headers are fine now, afaics. > > > So this comment can be changed to a more vague "some driver headers > > > depend on bus headers". > > > > > Driver headers are not checked yet by the code, only lib ones, so I will > > see if this block can be omitted until needed. > > I tried yesterday, iirc, you'll hit issues with eventdev driver headers. > Ok, thanks for trying.