From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDB6BA09E4; Thu, 28 Jan 2021 18:10:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60A4740682; Thu, 28 Jan 2021 18:10:36 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id 0E56B4067A for ; Thu, 28 Jan 2021 18:10:33 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from akozyrev@nvidia.com) with SMTP; 28 Jan 2021 19:10:32 +0200 Received: from nvidia.com (pegasus02.mtr.labs.mlnx [10.210.16.122]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10SHAWn4028844; Thu, 28 Jan 2021 19:10:32 +0200 From: Alexander Kozyrev To: dev@dpdk.org Cc: rasland@nvidia.com, ferruh.yigit@intel.com Date: Thu, 28 Jan 2021 17:10:30 +0000 Message-Id: <20210128171030.17013-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/mlx5: fix 32-bit arch compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is a "cast to pointer from integer of different size" compilation failure on 32-bit machines introduced by the RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation in mlx5 PMD. Cast the specified value to be used as RTE_FLOW_FIELD_POINTER to a pointer with an appropriate size suited for underlying arch. Please squash this patch into the original commit if possible. Fixes: 80ec1e84a4 ("net/mlx5: support modify field flow action") Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ec9cee8f25..a151c62c3a 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1749,7 +1749,9 @@ mlx5_flow_field_id_to_modify_info case RTE_FLOW_FIELD_POINTER: for (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) { if (mask[idx]) { - value[idx] = RTE_BE32(*(uint64_t *)data->value); + memcpy(&value[idx], + (void *)(uintptr_t)data->value, 32); + value[idx] = RTE_BE32(value[idx]); break; } } @@ -1757,7 +1759,7 @@ mlx5_flow_field_id_to_modify_info case RTE_FLOW_FIELD_VALUE: for (idx = 0; idx < MLX5_ACT_MAX_MOD_FIELDS; idx++) { if (mask[idx]) { - value[idx] = RTE_BE32(data->value); + value[idx] = RTE_BE32((uint32_t)data->value); break; } } -- 2.24.1