From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4DEE6A09E4;
Thu, 28 Jan 2021 18:23:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BE2F540682;
Thu, 28 Jan 2021 18:23:27 +0100 (CET)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by mails.dpdk.org (Postfix) with ESMTP id 468AD4067A
for <dev@dpdk.org>; Thu, 28 Jan 2021 18:23:24 +0100 (CET)
IronPort-SDR: H3i3yphImTa8gB8JVaWN4oOSw4/dKq7KZcx/jPHacucAE7M/fgEhZjyFEwyUCBGyxtHeukL393
KEQc62/gFFBA==
X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="265106993"
X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="265106993"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 Jan 2021 09:23:23 -0800
IronPort-SDR: X0PeDJMfj/Le96NCO66Tu+xTzletf+/PaVB6vAEOIQq/3KbX0D4ZfYOXQ05/7T2IwpZwaXEYr1
47qmRP92CsOg==
X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="430604758"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.53])
by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
28 Jan 2021 09:23:22 -0800
Date: Thu, 28 Jan 2021 17:23:18 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Message-ID: <20210128172318.GK899@bricha3-MOBL.ger.corp.intel.com>
References: <20210114110606.21142-1-bruce.richardson@intel.com>
<20210127173330.1671341-1-bruce.richardson@intel.com>
<20210127173330.1671341-7-bruce.richardson@intel.com>
<CAJFAV8x1RXJmVgGsnV2FqsGtOyjFJ+G3eEXmUogpq46vL498Yg@mail.gmail.com>
<20210128112719.GD899@bricha3-MOBL.ger.corp.intel.com>
<CAJFAV8wrS8LUaFQk0YTguvNS-==4R6OcCd0TQTWy4MFW29zsLg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wrS8LUaFQk0YTguvNS-==4R6OcCd0TQTWy4MFW29zsLg@mail.gmail.com>
Subject: Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify
header includes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Jan 28, 2021 at 12:31:20PM +0100, David Marchand wrote:
> On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > > > +# some ethdev headers depend on bus headers
> > > > +includes = include_directories('../../drivers/bus/pci',
> > > > + '../../drivers/bus/vdev')
> > >
> > > ethdev headers are fine now, afaics.
> > > So this comment can be changed to a more vague "some driver headers
> > > depend on bus headers".
> > >
> > Driver headers are not checked yet by the code, only lib ones, so I will
> > see if this block can be omitted until needed.
>
> I tried yesterday, iirc, you'll hit issues with eventdev driver headers.
>
Ok, I've done up a patch for eventdev similar to that of ethdev to make
private the rte_eventdev_pmd*.h files, and these lines can now be removed.
The eventdev files already had doxygen comments in them that they were not
for application use.
/Bruce