From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E21CA09E4; Thu, 28 Jan 2021 21:35:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42A8740682; Thu, 28 Jan 2021 21:35:28 +0100 (CET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 34AE34067A for ; Thu, 28 Jan 2021 21:35:26 +0100 (CET) Received: by mail-lf1-f45.google.com with SMTP id h12so9372254lfp.9 for ; Thu, 28 Jan 2021 12:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5yX1u9cnfeZMgCGsBRZuArqnX3vyyEyqBREHQ1UYIeo=; b=tQ4m0ULiW5YFY0WgbPTctCU+5jB9Enz4d/eZz+Sba/DUiyXsIatGU08DVy8woK0LwO yP3H00LCRnT6AUUdvM6lRdHZjQTwJgSoMB/hWUoH9vBAlbUORZzsB4S759/LAPvnC+N2 KT1rS4J15fWO3GtSFUeRGoXmHhIXKDbmB1Hg+LASY8wvdb37UnRMIvQVl35ESEm8wiBk o+ZM70jsHhG7PnpHdIbnjf1LFY3q6Ed2rVLbA7YmHv7YeWAf2ofnt03QUTlL1zW7ixz6 Ig0F1Z8KNjun35usAgsGi0XVBusyfbrQbwFMKB7ALh5Txx4fqIZlat7cHLMzvGEE0ryb pJmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5yX1u9cnfeZMgCGsBRZuArqnX3vyyEyqBREHQ1UYIeo=; b=rrsMCB6uO4koyvpt1ncSiT2+gF+tN4U+7W/ERimC4/7uSj4GNB+Qqv5+az1k/UNNzp uU62Dq2cbls9sbY51Vq8pYc/j9YH/makPW3MZ88a8lTSnZHNwSsbcHYcJq97kW/svzRp IJgk9k7Mf1T8lUl/7kn6EndsHCB47W7qn9vRB36YMG4QrYOkC3iuGwgkK1z21jafZQxd WrWo2aTXIRQ95RHj9dhM0JrqsEodMACOErcFHtZKS1vQ9Irzqi8ZYu4NH/0r+Qk5eSTC ldy308OalHzyKDUutMOfWmX5tTIymbVopqEff/4gXnUnkeVj/pxRcHA2df26aayPsONW /Q0Q== X-Gm-Message-State: AOAM531Ef6sqmaxr1XD4UsoAiwcGxhfbFOG3bYLI2yJJrp+E2VYkxlIy 9DKUKPitn/GIhUDFhw2+e0E= X-Google-Smtp-Source: ABdhPJzER5ksotzoFwH4dPRRDpgqUjkIxlsrj4GvgCka9kFi9Gqa2jGPN3TwJ+Asn6+RQI1XD8a+Aw== X-Received: by 2002:a19:6a13:: with SMTP id u19mr374099lfu.405.1611866125779; Thu, 28 Jan 2021 12:35:25 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id f9sm1765195lft.114.2021.01.28.12.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 12:35:24 -0800 (PST) Date: Thu, 28 Jan 2021 23:35:22 +0300 From: Dmitry Kozlyuk To: Ferruh Yigit Cc: Thomas Monjalon , "Rong, Leyi" , David Marchand , "Kadam, Pallavi" , dev@dpdk.org, Ali Alnubani , "Richardson, Bruce" , Tal Shnaiderman , Odi Assli , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Xing, Beilei" , "Menon, Ranjit" , Raslan Darawsheh Message-ID: <20210128233522.0d803796@sovereign> In-Reply-To: References: <20201215021945.103396-1-leyi.rong@intel.com> <3192552.88XjsRaxPa@thomas> <2421050.iSb15thaZp@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 26 Jan 2021 16:51:19 +0000, Ferruh Yigit wrote: > On 1/26/2021 4:48 PM, Thomas Monjalon wrote: > > 26/01/2021 17:39, Ferruh Yigit: > >> On 1/26/2021 4:22 PM, Thomas Monjalon wrote: > >>> 26/01/2021 17:17, Rong, Leyi: > >>>>>> On 1/20/2021 11:21 PM, Ferruh Yigit wrote: > >>>>>> > >>>>>> And for the mingw, I have same result with Ali, I can reproduce with (Fedora > >>>>> MinGW 9.2.1-6.fc32). > >>>>>> > >>>>>> But different from the CI, I am getting the error [1] for all following files: > >>>>>> rte_random.c > >>>>>> i40e_rxtx_vec_sse.c > >>>>>> i40e_rxtx_vec_avx512.c > >>>>>> i40e_rxtx_vec_avx2.c > >>>>>> rte_ethdev.c > >>> [...] > >>>> Send patch https://patchwork.dpdk.org/patch/87349/ to disable avx512 on windows as the workaround. > >>>> Pallavi also tested with this patch, and passed the mingw and clang build. Will try to see if has better way to fix. > >>> > >>> Ferruh mentioned errors with other files outside of i40e. > >>> > >> > >> The patch globally disables the avx512 for windows cross build, not just for > >> i40e, so I confirm it fixes the build errors in my environment. > >> > >> But disabling avx512 like this is not best option. > > > > Some may argue that AVX512 is not the best option ;) > > > > flame war mode activated. I found the following fix working: --- a/drivers/net/i40e/meson.build +++ b/drivers/net/i40e/meson.build @@ -60,6 +60,9 @@ if arch_subdir == 'x86' if cc.has_argument('-march=skylake-avx512') avx512_args += '-march=skylake-avx512' endif + if is_windows and cc.get_id() == 'gcc' + avx512_args += '-fno-asynchronous-unwind-tables' + endif i40e_avx512_lib = static_library('i40e_avx512_lib', 'i40e_rxtx_vec_avx512.c', dependencies: [static_rte_ethdev, It's admittedly from StackOverflow, but after reading about -fno-asynchronous-unwind-tables I see no harm disabling it, at least for just one file.