From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D50EA0A0D; Mon, 1 Feb 2021 06:30:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C190160691; Mon, 1 Feb 2021 06:30:43 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 7ED2840693 for ; Mon, 1 Feb 2021 06:30:41 +0100 (CET) IronPort-SDR: Sy5Y9gAHNa5tv1JV4WPhTDvbzFFrYn8f+W6CY0BmFliY1UHL7dh0uyBrqZbcBz8WrcYJK+VQqR x5ck3laJU4WQ== X-IronPort-AV: E=McAfee;i="6000,8403,9881"; a="265467755" X-IronPort-AV: E=Sophos;i="5.79,391,1602572400"; d="scan'208";a="265467755" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2021 21:30:40 -0800 IronPort-SDR: Ji4OXRSWsKiGG9+npUYGu8fHfExvEz74tg1/AXl43RtkmeNdKIRzHpytd9IHGKTF4/luPKCHg/ lgy7zuG0QEYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,391,1602572400"; d="scan'208";a="371420922" Received: from dpdk-xuanding-dev2.sh.intel.com ([10.67.119.124]) by orsmga002.jf.intel.com with ESMTP; 31 Jan 2021 21:30:38 -0800 From: Xuan Ding To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xuan Ding Date: Mon, 1 Feb 2021 05:16:59 +0000 Message-Id: <20210201051659.65873-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210201045302.55059-1-xuan.ding@intel.com> References: <20210201045302.55059-1-xuan.ding@intel.com> Subject: [dpdk-dev] [PATCH v2] net/ice: fix rss type checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask to fix rss rule cannot be created when set eth as rss type. Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing") Signed-off-by: Xuan Ding --- v2: * Refine the commit title. * Adjust the indentation by adding a space. --- drivers/net/ice/ice_hash.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index aee4761625..be63f09cab 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -424,24 +424,24 @@ struct ice_rss_hash_cfg empty_tmplt = { #define ICE_RSS_TYPE_GTPU_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \ ETH_RSS_GTPU) +/* PPPOE */ +#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE) + /* PPPOE IPv4 */ #define ICE_RSS_TYPE_PPPOE_IPV4 (ICE_RSS_TYPE_INNER_IPV4 | \ - ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) #define ICE_RSS_TYPE_PPPOE_IPV4_UDP (ICE_RSS_TYPE_INNER_IPV4_UDP | \ - ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) #define ICE_RSS_TYPE_PPPOE_IPV4_TCP (ICE_RSS_TYPE_INNER_IPV4_TCP | \ - ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) /* PPPOE IPv6 */ #define ICE_RSS_TYPE_PPPOE_IPV6 (ICE_RSS_TYPE_INNER_IPV6 | \ - ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) #define ICE_RSS_TYPE_PPPOE_IPV6_UDP (ICE_RSS_TYPE_INNER_IPV6_UDP | \ - ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) #define ICE_RSS_TYPE_PPPOE_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \ - ETH_RSS_PPPOE) - -/* PPPOE*/ -#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE) + ICE_RSS_TYPE_PPPOE) /* ESP, AH, L2TPV3 and PFCP */ #define ICE_RSS_TYPE_IPV4_ESP (ETH_RSS_ESP | ETH_RSS_IPV4) -- 2.17.1