* [dpdk-dev] [PATCH] net/ice: fix eth rss type checking
@ 2021-02-01 4:53 Xuan Ding
2021-02-01 5:16 ` [dpdk-dev] [PATCH v2] net/ice: fix " Xuan Ding
0 siblings, 1 reply; 3+ messages in thread
From: Xuan Ding @ 2021-02-01 4:53 UTC (permalink / raw)
To: qi.z.zhang, jingjing.wu, beilei.xing; +Cc: dev, Xuan Ding
For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask
to fix rss rule cannot be created when set eth as rss type.
Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing")
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
drivers/net/ice/ice_hash.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index aee4761625..ff0c55b4da 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -424,24 +424,24 @@ struct ice_rss_hash_cfg empty_tmplt = {
#define ICE_RSS_TYPE_GTPU_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
ETH_RSS_GTPU)
+/* PPPOE*/
+#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+
/* PPPOE IPv4 */
#define ICE_RSS_TYPE_PPPOE_IPV4 (ICE_RSS_TYPE_INNER_IPV4 | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_UDP (ICE_RSS_TYPE_INNER_IPV4_UDP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_TCP (ICE_RSS_TYPE_INNER_IPV4_TCP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
/* PPPOE IPv6 */
#define ICE_RSS_TYPE_PPPOE_IPV6 (ICE_RSS_TYPE_INNER_IPV6 | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_UDP (ICE_RSS_TYPE_INNER_IPV6_UDP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
- ETH_RSS_PPPOE)
-
-/* PPPOE*/
-#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
/* ESP, AH, L2TPV3 and PFCP */
#define ICE_RSS_TYPE_IPV4_ESP (ETH_RSS_ESP | ETH_RSS_IPV4)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v2] net/ice: fix rss type checking
2021-02-01 4:53 [dpdk-dev] [PATCH] net/ice: fix eth rss type checking Xuan Ding
@ 2021-02-01 5:16 ` Xuan Ding
2021-02-02 12:22 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Xuan Ding @ 2021-02-01 5:16 UTC (permalink / raw)
To: qi.z.zhang, jingjing.wu, beilei.xing; +Cc: dev, Xuan Ding
For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask
to fix rss rule cannot be created when set eth as rss type.
Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing")
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v2:
* Refine the commit title.
* Adjust the indentation by adding a space.
---
drivers/net/ice/ice_hash.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index aee4761625..be63f09cab 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -424,24 +424,24 @@ struct ice_rss_hash_cfg empty_tmplt = {
#define ICE_RSS_TYPE_GTPU_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
ETH_RSS_GTPU)
+/* PPPOE */
+#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+
/* PPPOE IPv4 */
#define ICE_RSS_TYPE_PPPOE_IPV4 (ICE_RSS_TYPE_INNER_IPV4 | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_UDP (ICE_RSS_TYPE_INNER_IPV4_UDP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_TCP (ICE_RSS_TYPE_INNER_IPV4_TCP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
/* PPPOE IPv6 */
#define ICE_RSS_TYPE_PPPOE_IPV6 (ICE_RSS_TYPE_INNER_IPV6 | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_UDP (ICE_RSS_TYPE_INNER_IPV6_UDP | \
- ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
- ETH_RSS_PPPOE)
-
-/* PPPOE*/
-#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+ ICE_RSS_TYPE_PPPOE)
/* ESP, AH, L2TPV3 and PFCP */
#define ICE_RSS_TYPE_IPV4_ESP (ETH_RSS_ESP | ETH_RSS_IPV4)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/ice: fix rss type checking
2021-02-01 5:16 ` [dpdk-dev] [PATCH v2] net/ice: fix " Xuan Ding
@ 2021-02-02 12:22 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-02-02 12:22 UTC (permalink / raw)
To: Ding, Xuan, Wu, Jingjing, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Monday, February 1, 2021 1:17 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH v2] net/ice: fix rss type checking
>
> For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask to
> fix rss rule cannot be created when set eth as rss type.
>
> Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 4:53 [dpdk-dev] [PATCH] net/ice: fix eth rss type checking Xuan Ding
2021-02-01 5:16 ` [dpdk-dev] [PATCH v2] net/ice: fix " Xuan Ding
2021-02-02 12:22 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).