[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

[Souvik Dey]

During the mlx5_dev_spawn(), it tries to sync the MAC address of the
Device to the internal MAC table. In case of SR-IOV VF , the 
mlx5_nl_mac_addr_sync() gets, 2 MAC address in the fresh start. 
One the unicast MAC assigned to the VF on the host and the second
the multicast mac of 33:33:00:00:00:01. Currently without check the 
type of MAC we try to add the MAC 33:33:00:00:00:01 to the first free
place in the MAC table which will be mostly index 1, as index 0 stores 
the unicast MAC assigned to the VF. This causes issues subsequently
when we try to add multicast address list. As every IPv6 IP generates 
differnet multicast MAC, to support multiple IP on a single interface, 
we need to add a list of multicast MAC. As an example, if we try to 
add 3 multicast MAC as mentioned below
mcast addr 0 - 33:33:00:00:00:01
mcast addr 1 - 01:00:5e:00:00:01
mcast addr 2 - 33:33:ff:68:fe:7d
then, the addition of these MAC will fail with error -EADDRINUSE in 
mlx5_internal_mac_addr_add(), and none of the MAC address will be 
added to the device, which will lead of packet drop in case multicast
promiscuous is not enable.
To make this work, we should store the synced MAC to the proper section 
of the internal table, after checking the type of the MAC synced. This
check will make the MAC of 33:33:00:00:00:01(synced MAC) to be stored at 
index 128(starting of MLX5_MAX_MC_MAC_ADDRESSES), which will be removed 
and added again during the mlx5_set_mc_addr_list(). This will make sure 
that all the multicast MACs are added properly to both the internal table
and also the device, specially in case of SR-IOV VF.

Souvik Dey (1):
  net/mlx5:fix storing the synced MAC to internal table

 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

-- 
2.9.3.windows.1

[dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

[Souvik Dey]

As the internal MAC table is divided into Unicast and Multicast address
section, we should check the type of synced MAC address before storing
it to the internal table. Currently the check is not done, and the
synced MAC of 33:33:00:00:00:01 gets stored in the unicast section
(mostly index 1) which causes all subsequent mlx5_set_mc_addr_list()
to fail with error -EADDRINUSE, as the mac_list contains the MAC
33:33:00:00:00:01. This denies adding of any new multicast address to
the internal list and also fails to add the MAC address to the device
in case of SR-IOV VF case.

Signed-off-by: Souvik Dey <sodey@rbbn.com>
---
 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 40d8620..ef7a521 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
 				break;
 		if (j != n)
 			continue;
-		/* Find the first entry available. */
-		for (j = 0; j != n; ++j) {
-			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
-				mac_addrs[j] = macs[i];
-				break;
+		if (rte_is_multicast_ether_addr(&macs[i])) {
+			/* Find the first entry available. */
+			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
+			}
+		} else {
+			/* Find the first entry available. */
+			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
 			}
 		}
 	}
-- 
2.9.3.windows.1

Re: [dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

[Slava Ovsiienko]

Hi, Souvik

Thank you for the patch, please see my comments below.
>From: Souvik Dey <sodey@rbbn.com> 
>Sent: Wednesday, December 9, 2020 17:11
>To: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler ><shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org; Souvik Dey <sodey@rbbn.com>
>Subject: [PATCH] net/mlx5:fix storing the synced MAC to internal table

We have the warnings:
Wrong headline format:
        net/mlx5:fix storing the synced MAC to internal table
Wrong headline prefix:
        net/mlx5:fix storing the synced MAC to internal table
Missing 'Fixes' tag:
        net/mlx5:fix storing the synced MAC to internal table

The patch headline should be:
common/mlx5: fix storing the synched MAC to internal table

- net/ -> common/
- space after mlx5:
- synced -> synched

The patch should contain the Fixes tag: 

Fixes: f22442cb5d42 (“net/mlx5: reduce Netlink commands dependencies”)
Fixes: ccdcba53a3f4 (“net/mlx5: use Netlink to add/remove MAC addresses”)

The patch should contain (to be sent to LTS ML):

Cc: stable@dpdk.org

>As the internal MAC table is divided into Unicast and Multicast address
>section, we should check the type of synced MAC address before storing
section -> sections
synced -> synched

>it to the internal table. Currently the check is not done, and the
>synced MAC of 33:33:00:00:00:01 gets stored in the unicast section
sync ->synched

>(mostly index 1) which causes all subsequent mlx5_set_mc_addr_list()
reword? :  which causes -> causing  

>to fail with error -EADDRINUSE, as the mac_list contains the MAC
>33:33:00:00:00:01. This denies adding of any new multicast address to
>the internal list and also fails to add the MAC address to the device
>in case of SR-IOV VF case.
typo: case (to remove)

With best regards,
Slava

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 40d8620..ef7a521 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
break;
if (j != n)
continue;
- /* Find the first entry available. */
- for (j = 0; j != n; ++j) {
- if (rte_is_zero_ether_addr(&mac_addrs[j])) {
- mac_addrs[j] = macs[i];
- break;
+ if (rte_is_multicast_ether_addr(&macs[i])) {
+ /* Find the first entry available. */
+ for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+ if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+ mac_addrs[j] = macs[i];
+ break;
+ }
+ }
+ } else {
+ /* Find the first entry available. */
+ for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+ if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+ mac_addrs[j] = macs[i];
+ break;
+ }
}
}
}
-- 
2.9.3.windows.1

________________________________________
Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.
________________________________________

[dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched MAC to internal table

[Dey, Souvik]

From: Souvik Dey <sodey@rbbn.com>

As the internal MAC table is divided into Unicast and Multicast address
sections, we should check the type of synched MAC address before storing
it to the internal table. Currently the check is not done, and the
synched MAC of 33:33:00:00:00:01 gets stored in the unicast section
(mostly index 1) causing all subsequent mlx5_set_mc_addr_list()
to fail with error -EADDRINUSE, as the mac_list contains the MAC
33:33:00:00:00:01. This denies adding of any new multicast address to
the internal list and also fails to add the MAC address to the device
in case of SR-IOV VF.

Fixes: f22442cb5d42 (�net/mlx5: reduce Netlink commands dependencies�)
Fixes: ccdcba53a3f4 (�net/mlx5: use Netlink to add/remove MAC addresses�)
Cc: stable@dpdk.org

Signed-off-by: Souvik Dey <sodey@rbbn.com>
---
v2:
* net/ -> common/
* space after mlx5:
* synched -> synched
* section -> sections
* rewording which causes -> causing 
* typo: case (to remove)
* added Fixes for LTS ML
---
 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 40d8620..ef7a521 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
 				break;
 		if (j != n)
 			continue;
-		/* Find the first entry available. */
-		for (j = 0; j != n; ++j) {
-			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
-				mac_addrs[j] = macs[i];
-				break;
+		if (rte_is_multicast_ether_addr(&macs[i])) {
+			/* Find the first entry available. */
+			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
+			}
+		} else {
+			/* Find the first entry available. */
+			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
 			}
 		}
 	}
-- 
2.9.3.windows.1


Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched MAC to internal table

[Slava Ovsiienko]

Hi, 

It seems there is wrong quota character in the "Fixes: " tags:

( net/mlx5: reduce Netlink commands dependencies )

With best regards,
Slava

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Tuesday, February 2, 2021 5:54
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> Subject: [PATCH v2] common/mlx5: fix storing the synched MAC to internal
> table
> 
> From: Souvik Dey <sodey@rbbn.com>
> 
> As the internal MAC table is divided into Unicast and Multicast address
> sections, we should check the type of synched MAC address before storing it
> to the internal table. Currently the check is not done, and the synched MAC of
> 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) causing
> all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the
> mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any new
> multicast address to the internal list and also fails to add the MAC address to
> the device in case of SR-IOV VF.
> 
> Fixes: f22442cb5d42 ( net/mlx5: reduce Netlink commands dependencies )
> Fixes: ccdcba53a3f4 ( net/mlx5: use Netlink to add/remove MAC addresses )
> Cc: stable@dpdk.org
> 
> Signed-off-by: Souvik Dey <sodey@rbbn.com>
> ---
> v2:
> * net/ -> common/
> * space after mlx5:
> * synched -> synched
> * section -> sections
> * rewording which causes -> causing
> * typo: case (to remove)
> * added Fixes for LTS ML
> ---
>  drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> b/drivers/common/mlx5/linux/mlx5_nl.c
> index 40d8620..ef7a521 100644
> --- a/drivers/common/mlx5/linux/mlx5_nl.c
> +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int
> iface_idx,
>  				break;
>  		if (j != n)
>  			continue;
> -		/* Find the first entry available. */
> -		for (j = 0; j != n; ++j) {
> -			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> -				mac_addrs[j] = macs[i];
> -				break;
> +		if (rte_is_multicast_ether_addr(&macs[i])) {
> +			/* Find the first entry available. */
> +			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j)
> {
> +				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +					mac_addrs[j] = macs[i];
> +					break;
> +				}
> +			}
> +		} else {
> +			/* Find the first entry available. */
> +			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j)
> {
> +				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +					mac_addrs[j] = macs[i];
> +					break;
> +				}
>  			}
>  		}
>  	}
> --
> 2.9.3.windows.1
> 
> 
> Notice: This e-mail together with any attachments may contain information of
> Ribbon Communications Inc. and its Affiliates that is confidential and/or
> proprietary for the sole use of the intended recipient. Any review, disclosure,
> reliance or distribution by others or forwarding without express permission is
> strictly prohibited. If you are not the intended recipient, please notify the
> sender immediately and then delete all copies, including any attachments.

[dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Dey, Souvik]

From: Souvik Dey <sodey@rbbn.com>

As the internal MAC table is divided into Unicast and Multicast address
sections, we should check the type of synched MAC address before storing
it to the internal table. Currently the check is not done, and the
synched MAC of 33:33:00:00:00:01 gets stored in the unicast section
(mostly index 1) causing all subsequent mlx5_set_mc_addr_list()
to fail with error -EADDRINUSE, as the mac_list contains the MAC
33:33:00:00:00:01. This denies adding of any new multicast address to
the internal list and also fails to add the MAC address to the device
in case of SR-IOV VF.

Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses')
Cc: stable@dpdk.org

Signed-off-by: Souvik Dey <sodey@rbbn.com>
---
v2:
* net/ -> common/
* space after mlx5:
* synched -> synched
* section -> sections
* rewording which causes -> causing 
* typo: case (to remove)
* added Fixes for LTS ML
---
v3:
* Changed the "" in Fixes tags to ''.
---
 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 40d8620..ef7a521 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
 				break;
 		if (j != n)
 			continue;
-		/* Find the first entry available. */
-		for (j = 0; j != n; ++j) {
-			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
-				mac_addrs[j] = macs[i];
-				break;
+		if (rte_is_multicast_ether_addr(&macs[i])) {
+			/* Find the first entry available. */
+			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
+			}
+		} else {
+			/* Find the first entry available. */
+			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
 			}
 		}
 	}
-- 
2.9.3.windows.1


Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Slava Ovsiienko]

Hi,

I'm sorry, but quota character in "Fixes" tags is still wrong, causing the checking script errors.
It should be " (0x22 ASCII), not ' (0x27 ASCII).

Beside this:

Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Tuesday, February 2, 2021 19:49
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to internal
> table
> 
> From: Souvik Dey <sodey@rbbn.com>
> 
> As the internal MAC table is divided into Unicast and Multicast address
> sections, we should check the type of synched MAC address before storing it
> to the internal table. Currently the check is not done, and the synched MAC of
> 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) causing
> all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the
> mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any new
> multicast address to the internal list and also fails to add the MAC address to
> the device in case of SR-IOV VF.
> 
> Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
> Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses')
> Cc: stable@dpdk.org
> 
> Signed-off-by: Souvik Dey <sodey@rbbn.com>
> ---
> v2:
> * net/ -> common/
> * space after mlx5:
> * synched -> synched
> * section -> sections
> * rewording which causes -> causing
> * typo: case (to remove)
> * added Fixes for LTS ML
> ---
> v3:
> * Changed the "" in Fixes tags to ''.
> ---
>  drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> b/drivers/common/mlx5/linux/mlx5_nl.c
> index 40d8620..ef7a521 100644
> --- a/drivers/common/mlx5/linux/mlx5_nl.c
> +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int
> iface_idx,
>  				break;
>  		if (j != n)
>  			continue;
> -		/* Find the first entry available. */
> -		for (j = 0; j != n; ++j) {
> -			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> -				mac_addrs[j] = macs[i];
> -				break;
> +		if (rte_is_multicast_ether_addr(&macs[i])) {
> +			/* Find the first entry available. */
> +			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j)
> {
> +				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +					mac_addrs[j] = macs[i];
> +					break;
> +				}
> +			}
> +		} else {
> +			/* Find the first entry available. */
> +			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j)
> {
> +				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +					mac_addrs[j] = macs[i];
> +					break;
> +				}
>  			}
>  		}
>  	}
> --
> 2.9.3.windows.1
> 
> 
> Notice: This e-mail together with any attachments may contain information of
> Ribbon Communications Inc. and its Affiliates that is confidential and/or
> proprietary for the sole use of the intended recipient. Any review, disclosure,
> reliance or distribution by others or forwarding without express permission is
> strictly prohibited. If you are not the intended recipient, please notify the
> sender immediately and then delete all copies, including any attachments.

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Dey, Souvik]

Hi Slava,
	Initially v2 of the patch has " instead of ' in the Fixes tags, but it gave some warnings as wrong quota. So thought of changing it to '. I can change it back again, do you suggest me to submit v4 with with corrected quota character or its ok to have the v3 of the patch itself as you have already acked ?

--
Regards,
Souvik

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Slava Ovsiienko
Sent: Wednesday, February 3, 2021 3:04 AM
To: Dey, Souvik <sodey@rbbn.com>; Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

NOTICE: This email was received from an EXTERNAL sender.


Hi,

I'm sorry, but quota character in "Fixes" tags is still wrong, causing the checking script errors.
It should be " (0x22 ASCII), not ' (0x27 ASCII).

Beside this:

Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Tuesday, February 2, 2021 19:49
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko 
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf 
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to 
> internal table
>
> From: Souvik Dey <sodey@rbbn.com>
>
> As the internal MAC table is divided into Unicast and Multicast 
> address sections, we should check the type of synched MAC address 
> before storing it to the internal table. Currently the check is not 
> done, and the synched MAC of
> 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) 
> causing all subsequent mlx5_set_mc_addr_list() to fail with error 
> -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This 
> denies adding of any new multicast address to the internal list and 
> also fails to add the MAC address to the device in case of SR-IOV VF.
>
> Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
> Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC 
> addresses')
> Cc: stable@dpdk.org
>
> Signed-off-by: Souvik Dey <sodey@rbbn.com>
> ---
> v2:
> * net/ -> common/
> * space after mlx5:
> * synched -> synched
> * section -> sections
> * rewording which causes -> causing
> * typo: case (to remove)
> * added Fixes for LTS ML
> ---
> v3:
> * Changed the "" in Fixes tags to ''.
> ---
>  drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> b/drivers/common/mlx5/linux/mlx5_nl.c
> index 40d8620..ef7a521 100644
> --- a/drivers/common/mlx5/linux/mlx5_nl.c
> +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int 
> iface_idx,
>                               break;
>               if (j != n)
>                       continue;
> -             /* Find the first entry available. */
> -             for (j = 0; j != n; ++j) {
> -                     if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> -                             mac_addrs[j] = macs[i];
> -                             break;
> +             if (rte_is_multicast_ether_addr(&macs[i])) {
> +                     /* Find the first entry available. */
> +                     for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j)
> {
> +                             if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +                                     mac_addrs[j] = macs[i];
> +                                     break;
> +                             }
> +                     }
> +             } else {
> +                     /* Find the first entry available. */
> +                     for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j)
> {
> +                             if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> +                                     mac_addrs[j] = macs[i];
> +                                     break;
> +                             }
>                       }
>               }
>       }
> --
> 2.9.3.windows.1
>
>

Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Slava Ovsiienko]

> back again, do you suggest me to submit v4 with with corrected quota
> character or its ok to have the v3 of the patch itself as you have already
> acked ?

OK, let's ask Raslan to fix this minor issue while integrating the patch.
Raslan, could you, please, fix the quota character in the commit message?

With best regards, Slava

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Wednesday, February 3, 2021 14:09
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v3] common/mlx5: fix storing the synched MAC to
> internal table
> 
> Hi Slava,
> 	Initially v2 of the patch has " instead of ' in the Fixes tags, but it gave
> some warnings as wrong quota. So thought of changing it to '. I can change it
> back again, do you suggest me to submit v4 with with corrected quota
> character or its ok to have the v3 of the patch itself as you have already
> acked ?
> 
> --
> Regards,
> Souvik
> 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Slava Ovsiienko
> Sent: Wednesday, February 3, 2021 3:04 AM
> To: Dey, Souvik <sodey@rbbn.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched
> MAC to internal table
> 
> NOTICE: This email was received from an EXTERNAL sender.
> 
> 
> Hi,
> 
> I'm sorry, but quota character in "Fixes" tags is still wrong, causing the
> checking script errors.
> It should be " (0x22 ASCII), not ' (0x27 ASCII).
> 
> Beside this:
> 
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 
> > -----Original Message-----
> > From: Dey, Souvik <sodey@rbbn.com>
> > Sent: Tuesday, February 2, 2021 19:49
> > To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> > Shuler <shahafs@nvidia.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> > Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to
> > internal table
> >
> > From: Souvik Dey <sodey@rbbn.com>
> >
> > As the internal MAC table is divided into Unicast and Multicast
> > address sections, we should check the type of synched MAC address
> > before storing it to the internal table. Currently the check is not
> > done, and the synched MAC of
> > 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1)
> > causing all subsequent mlx5_set_mc_addr_list() to fail with error
> > -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This
> > denies adding of any new multicast address to the internal list and
> > also fails to add the MAC address to the device in case of SR-IOV VF.
> >
> > Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
> > Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC
> > addresses')
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Souvik Dey <sodey@rbbn.com>
> > ---
> > v2:
> > * net/ -> common/
> > * space after mlx5:
> > * synched -> synched
> > * section -> sections
> > * rewording which causes -> causing
> > * typo: case (to remove)
> > * added Fixes for LTS ML
> > ---
> > v3:
> > * Changed the "" in Fixes tags to ''.
> > ---
> >  drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
> >  1 file changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/common/mlx5/linux/mlx5_nl.c
> > b/drivers/common/mlx5/linux/mlx5_nl.c
> > index 40d8620..ef7a521 100644
> > --- a/drivers/common/mlx5/linux/mlx5_nl.c
> > +++ b/drivers/common/mlx5/linux/mlx5_nl.c
> > @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned
> int
> > iface_idx,
> >                               break;
> >               if (j != n)
> >                       continue;
> > -             /* Find the first entry available. */
> > -             for (j = 0; j != n; ++j) {
> > -                     if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> > -                             mac_addrs[j] = macs[i];
> > -                             break;
> > +             if (rte_is_multicast_ether_addr(&macs[i])) {
> > +                     /* Find the first entry available. */
> > +                     for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j)
> > {
> > +                             if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> > +                                     mac_addrs[j] = macs[i];
> > +                                     break;
> > +                             }
> > +                     }
> > +             } else {
> > +                     /* Find the first entry available. */
> > +                     for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j)
> > {
> > +                             if (rte_is_zero_ether_addr(&mac_addrs[j])) {
> > +                                     mac_addrs[j] = macs[i];
> > +                                     break;
> > +                             }
> >                       }
> >               }
> >       }
> > --
> > 2.9.3.windows.1
> >
> >
> 
> Notice: This e-mail together with any attachments may contain information
> of Ribbon Communications Inc. and its Affiliates that is confidential and/or
> proprietary for the sole use of the intended recipient. Any review, disclosure,
> reliance or distribution by others or forwarding without express permission
> is strictly prohibited. If you are not the intended recipient, please notify the
> sender immediately and then delete all copies, including any attachments.

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Raslan Darawsheh]

> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, February 3, 2021 4:15 PM
> To: Dey, Souvik <sodey@rbbn.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v3] common/mlx5: fix storing the synched MAC to
> internal table
> 
> > back again, do you suggest me to submit v4 with with corrected quota
> > character or its ok to have the v3 of the patch itself as you have already
> > acked ?
> 
> OK, let's ask Raslan to fix this minor issue while integrating the patch.
> Raslan, could you, please, fix the quota character in the commit message?
Sure, will handle on integration,
> 
> With best regards, Slava
> 
Kindest regards
Raslan Darawsheh

Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Tuesday, February 2, 2021 7:49 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to internal
> table
> 
> From: Souvik Dey <sodey@rbbn.com>
> 
> As the internal MAC table is divided into Unicast and Multicast address
> sections, we should check the type of synched MAC address before storing
> it to the internal table. Currently the check is not done, and the
> synched MAC of 33:33:00:00:00:01 gets stored in the unicast section
> (mostly index 1) causing all subsequent mlx5_set_mc_addr_list()
> to fail with error -EADDRINUSE, as the mac_list contains the MAC
> 33:33:00:00:00:01. This denies adding of any new multicast address to
> the internal list and also fails to add the MAC address to the device
> in case of SR-IOV VF.
> 
> Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
> Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses')
Replaced  ' to "
> Cc: stable@dpdk.org
> 
> Signed-off-by: Souvik Dey <sodey@rbbn.com>
> ---
> v2:
> * net/ -> common/
> * space after mlx5:
> * synched -> synched
> * section -> sections
> * rewording which causes -> causing
> * typo: case (to remove)
> * added Fixes for LTS ML
> ---
> v3:
> * Changed the "" in Fixes tags to ''.
> 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh