From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D53CA052A; Tue, 2 Feb 2021 04:54:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B43CA24024A; Tue, 2 Feb 2021 04:54:11 +0100 (CET) Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.2]) by mails.dpdk.org (Postfix) with ESMTP id D5F44240249; Tue, 2 Feb 2021 04:54:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=rbbnselector03122020; t=1612238049; i=@rbbn.com; bh=cGdqAGci6FwSsX5GZB2ME0SAMMGWlaO4f1qvModR4ow=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:MIME-Version; b=PhXQY2lj8riC9QEj62Ii8OweNUSozpcIFlgPM/QpwkNVmcsm6diT2n2cq/28rwSSk a1qQFZ66iOmVTYJUNnXZUrgWX/Lwr5DieOhUunBlAYpioES9PyhHMmDTsLBFhJGuCT Ef72NKbCeaUCuzGIwmG9m7EVO94JRAE1zyvgOKlXmAjC9tK0B1RsNK9YAfCH7nz5EM Eyx9u2UdyB1ad6xVxlRq2MeuYkjmu1myRIUn9jQ4+2921E7Z3jHOGcc8IdsqGQeM9I rwafImtUj6o5YcReddCyce/68NCvrs1zMa7Mtno0Ckw91GDHWvXggFzXqjEdgmTIJf eEkpwsc3tKYFA== Received: from [100.113.0.194] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-2.bemta.az-a.eu-central-1.aws.symcld.net id 59/89-55623-0ECC8106; Tue, 02 Feb 2021 03:54:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRWlGSWpSXmKPExsWSoa9mpvvgjES CwYH58hbvPm1nsrhzooXVYubBF+wW868uZbf41/GH3WJP414WBzaPXwuWsnr0Nr9jC2CKYs3M S8qvSGDNeLv2K3PBJoGKjfNXMjUw7uLtYuTiYBRYyizxv/kyM4RzjEXi3KotrBDOKkaJzvl/G EEcFoHdzBJ/1i5gg8h0MUp07JgG5ggJzGaS6Nu0nBXCuccocb6nFcjh5GATUJG42TqFGcQWEQ iXOLh1HzuIzSzgILFiTRNYjbCAn0R/cwMjiM0ioCrxbv8UsBpeAWOJps41YLaEgIbEgXW72EB sTgETiaO37jGB2EJANY+P9rB0MXIAzVSXWD9PCGK8vETz1tnMIGEJAQWJbw+1IaZMZZT42R0I 0Skt8erofBaITYISJ2c+YYGo0ZH4u6gR6pWZTBIfT51hhkjIShw9OweqyFfi0ZF7rBC2lsTPu 3uhdqlI3H5iA2HmSCy/pQhRoSax9MxnNghbTuJU7zkmCFtGYuKeCywTGHVnIdw/C8n9s5Act4 CReRWjRVJRZnpGSW5iZo6uoYGBrqGhsa6RrqmhXmKVbqJeaqlucmpeSVEiUFIvsbxYr7gyNzk nRS8vtWQTIzD9pBQyGe9gvPb6g94hRkkOJiVR3g/vRBOE+JLyUyozEosz4otKc1KLDzHKcHAo SfCKnZJIEBIsSk1PrUjLzAGmQpi0BAePkgiv22mgNG9xQWJucWY6ROoUoy7HhJdzFzELseTl5 6VKifO6gxQJgBRllObBjYCl5UuMslLCvIwMDAxCPAWpRbmZJajyrxjFORiVhHlfg0zhycwrgd v0CugIJqAjPm4VAzmiJBEhJdXAtLdF+XF3yqctFrPL+bv5Nb984ftbtntVq9wt2Q8TLsxffmL NuR/nV3Zc3vq+fUJbVrpW4pMix8cGFR4TXP5+/dXQ6xF573vAxbroeRqZrGn8P6fNyc+07Dms 5XbRtWVip6phj4ebqaYRQ5npson8N+52x3SmKHx5P32/UmPNyfOu/OIXbPnENJL+rDnK2Lu26 8zx+rQ1++rvpXswcZ3OavCeG3knbEbL8eSoTd58M177T+9rnKkhInU8rOPAsdLW25tfds8r4Q phP9uXYqIndzij6NpjFbWHAXuEZt690x1V5NLwQShxqe7O4ltLTr00CF88OWK76Ob5gssnbzj 74urlB7qnUz4FpdW3G/79rcRSnJFoqMVcVJwIADLggYhGBAAA X-Env-Sender: sodey@rbbn.com X-Msg-Ref: server-9.tower-226.messagelabs.com!1612238047!88139!1 X-Originating-IP: [104.47.38.54] X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=rbbn.com,-,- X-VirusChecked: Checked Received: (qmail 25853 invoked from network); 2 Feb 2021 03:54:08 -0000 Received: from mail-bl2nam02lp2054.outbound.protection.outlook.com (HELO NAM02-BL2-obe.outbound.protection.outlook.com) (104.47.38.54) by server-9.tower-226.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 2 Feb 2021 03:54:08 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=geB4fJfNvm+lS6naH5ruxtj/83tyOtIOipBPz9uXbtBgqbCeQxjgjzXSIzONNjovBLZX5llGriGO2ChRZ0GEkwM+hF/FKsimzyv0RdlG1LyuHXRIgYvP5KHxf01921wiGz7IvJmsqvDg9cKnNSFxSQdBWoa14lai03BMbHnOiQiQ0iTI5NuWvO8rJbT07+duLvuyKnHAZRJVNCGEAP8jmCnC1UulgWNouc0OXHTre8PcvMekupLKJFoFRqoCZU2rM9oGGyIyzg8aIixT8CvSTlR31YpAMh0Y+ma6izivf5IpNdw2iaobnbZcqwuABOnFrTVxnd37OKmVfl5yJlwoeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BuIKRmLkdskHM0Ct8Gz9eeIiylK8XFx5Xo4iIiNvXJ8=; b=juvtn2ISyiMGYMOViF9/+VYyYE3ZSqfyUBkV/5URWUK9bwZmnUX9hMx1Cw64bRU4PxhJIgydv4Djz/WtZsDFNO3bbT+gSMgM69VA9OoB05t6wvHXWOz7YFObCjdk4gAjiwvFKXOPaDPX2hlIs6GJoMx9N3Z1V39mzvFPPp2GLArSsUnVskv8v1MawRoRd2dHAisptSDQjyfNSEoYXSl/8H7e2wUz2rGFicNkOJgETkU64sFJ/Mt+BB8kzryvsk0KoCCyM6pZaFdDmChGGJ8l0LSbhPaB1kAigWPXA1AxcHIFcI9KwO1R6xaIlp6SEUtTYTQFkPdM1hEQwBUHrtRk7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=rbbn.com; dmarc=pass action=none header.from=rbbn.com; dkim=pass header.d=rbbn.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector2-SonusNetworks-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BuIKRmLkdskHM0Ct8Gz9eeIiylK8XFx5Xo4iIiNvXJ8=; b=PcEwz8kBmruA48dGjpFpYbihfBU9Op44MaxYLEpFb28jkhcQ9vgdCoJcFUB1T1AFmSesx0ZwSxf5T6gkN/lm08kIfq94sjkIm6LAbuVHpI3v6DjNwD6I0GwBjsO/IPSK8aoL5Q+hiiHfYigQMg2DXwYFv0k6VAbTJCUNc47cYRM= Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM6PR03MB3420.namprd03.prod.outlook.com (2603:10b6:5:ac::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Tue, 2 Feb 2021 03:54:05 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::a4d1:8a68:f527:d513]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::a4d1:8a68:f527:d513%6]) with mapi id 15.20.3805.028; Tue, 2 Feb 2021 03:54:05 +0000 From: "Dey, Souvik" To: rasland@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, stable@dpdk.org, Souvik Dey Date: Mon, 1 Feb 2021 22:53:51 -0500 Message-Id: <20210202035352.24512-1-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: <20201209151108.12352-2-sodey@rbbn.com> References: <20201209151108.12352-2-sodey@rbbn.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: MN2PR15CA0018.namprd15.prod.outlook.com (2603:10b6:208:1b4::31) To DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by MN2PR15CA0018.namprd15.prod.outlook.com (2603:10b6:208:1b4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3805.17 via Frontend Transport; Tue, 2 Feb 2021 03:54:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91aa159f-72e8-416c-1144-08d8c72e2f88 X-MS-TrafficTypeDiagnostic: DM6PR03MB3420: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OS9ih5AsBLxhh4K+4p8A09KNCrbF0DVWP4iKKI9Q0LeiuCxeqjx3Ylk9mD0BIn+sYhiBP6y51BQH+17cJ7WJ0+ENT+UrfwOPYLfl0Bv9KZ1xZmxZrJc+vIkCN1394WdT1VN/SPwGrd/S0KTD6CwHGXEaPC9eiClAjcf1wz13hHCQ59Vj+XnBlqKAcYtEc1roquWvb/E9aBwxqU1yMcqFVNYnyrqno4BaP7prI92IgADLne1osz+wtuGAy9ELu+RilqCQ8B151dlMo4JHR9CD4t0pSdV1cVYizDLGzYCsLRyRkToQ2F4OJjyL1upbek1nv2f3CClQp77QGYMEHcjzytmbDWvbVN6+u0S72YLqhSNW1gNClJKn/zgp8yc5W38dtwCHHdK73KZ2EkIFWk4RITgAoh2iy/xM8/SqxhApA4bREMuQokblo5L6Nr6PacC+Ay9i+b9184bc+1zfj5c9vsrY4I1ycZDowzgVIOHaPG+Ql7+gW5oH7kjtYBlEyUISk1hUSeDO+biLL3oP4lu1vg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(956004)(52116002)(86362001)(2616005)(107886003)(1076003)(6506007)(4326008)(186003)(16526019)(316002)(66946007)(66556008)(5660300002)(66476007)(8936002)(6512007)(478600001)(36756003)(26005)(2906002)(83380400001)(6486002)(8676002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UDNEeHRtaG1iVkcydGRNZUR1dlI0WFVpb3NRVFBvU0ttUFNWei8ralEyQng4?= =?utf-8?B?KzZrdk15UXZMK29CcFBUOHRIWlVqdFduVHlMUXBONUxjOElQandSMWZtM2Nx?= =?utf-8?B?MGh4d2src3hhN0MvaWZmajF3QSs2dEx0Y3czMW41ZG9Pa1lENEpiRW9IbTY0?= =?utf-8?B?V3pwdkFRek9DbnZ2VUxLc1R0ZjFESHlrL2gvOVZRbFdhc2hOYTNxNGpCOEls?= =?utf-8?B?WTQ5MjlJeG8xWGNlUlRJMGh5WkZoY1dQVko3dFZ2SXpJNmxDa0I2QVR4Y05i?= =?utf-8?B?K1BTLytGWDgrMGRoQS9ERU9TOEd0dXpDMVhRN1dRS2pXUmdrU2F1N0FZSkl1?= =?utf-8?B?d1d4Q0pydk5vRUdObXdIRUQ5c24zS1pLcThvQTROcFlIb1RhTlJUU2Y0RW54?= =?utf-8?B?Z0pSQlJid0YxWkRlWHN4aWcyS3UzTU1sSWp5TU1xbGY5UExyWFpqVkloR2lQ?= =?utf-8?B?K296dStCWDhqVDZMZmZ2V1ZZM0RJa1pWd09MZ0l4bkJwNDVpVXFSZWkyY1hu?= =?utf-8?B?SXdabnU3Z2NlVW5LSWc3cW91R09PYVF4QjRVN2p6MnpzVU0wUi9IOVJzaFR0?= =?utf-8?B?dHVCSkkyNDY3SXZiWVJvTDI5eEQ1a212VlI0RWhobUtxU1hQdU1RTzM5Vk84?= =?utf-8?B?YVFpY2FRMi9Celc3TUtZZlgyaVpMNnB4QTBjWTc2clBvdlhxYTJUejFaa0Nr?= =?utf-8?B?VEp6Wnd4VHlNR1dJWTVzZnM1dEZCVDZzRjRiOWJwNk50by9BSmU5RmNMT3hz?= =?utf-8?B?NXE2ZnAzV3h3a0Z4RGZzcFFYdnhMSTk0VVUzaEtXeVNyZFQxTUdUN0kyYldC?= =?utf-8?B?RzlIM1RFeDkwNGhxSWVCRytBeGF6MDNjL3NRQ040d1VYMmNBd2ZmQWtPS2tX?= =?utf-8?B?V0JqL2hidVZFalQxWG01aFNpK1diNUVNMisvbWlvYlJLdVY4bkdyWFY2U1dn?= =?utf-8?B?MG5yaWxteEZjczRSSVZ0eXpkc0NMVUhRckE1S1F0QUxmME91YWNDaEtvMmU0?= =?utf-8?B?NS9xU21waWN2alp4ZGg2TmpYTnlTTndnV3VEeWlLWmcxdUdZNzVJYUFTRTdo?= =?utf-8?B?UVlSdjZZbFZxUzFHRGFUNUI3d2hGN1dTNUEyUDlteDhnYTNNRkQ3ZEVMbk9Y?= =?utf-8?B?SWZTVkVuUW8vcFJ5R0NzS2NLQ1lSeHlPVUZ5WWtHSkhRMlJqcDVJUGk4SHRy?= =?utf-8?B?WlR0ay94V1l1aUU3UWd3YTY5L1NUR0xXUllkbW0xUllEbzBxS05wUzY4dFhr?= =?utf-8?B?b05GTEROQ0o3djBGL3hBdGduT1hUa1ZvZGxiMEh6aDZsYk44d00zeXpIdkhF?= =?utf-8?B?cGVVNktubG1YUnVnSURoQ0tIR0dDZy8rU0tlVGJ3dTRFSHNhN1ZCWTVid1h4?= =?utf-8?B?eGZJOFlNWUhkbVlWL2xWVVBmQ0FGaEF3QUt2ZFlTTlE1ekgzeW9yWkRja05T?= =?utf-8?Q?oDzKJFH/?= X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91aa159f-72e8-416c-1144-08d8c72e2f88 X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2021 03:54:05.5922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2n7QvbAvRMWgZA57edojrI+pX5QmxETg9oX596pIS8AlobeHxChlIR8Yr4M0HAWE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3420 Subject: [dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Souvik Dey As the internal MAC table is divided into Unicast and Multicast address sections, we should check the type of synched MAC address before storing it to the internal table. Currently the check is not done, and the synched MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) causing all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any new multicast address to the internal list and also fails to add the MAC address to the device in case of SR-IOV VF. Fixes: f22442cb5d42 (�net/mlx5: reduce Netlink commands dependencies�) Fixes: ccdcba53a3f4 (�net/mlx5: use Netlink to add/remove MAC addresses�) Cc: stable@dpdk.org Signed-off-by: Souvik Dey --- v2: * net/ -> common/ * space after mlx5: * synched -> synched * section -> sections * rewording which causes -> causing * typo: case (to remove) * added Fixes for LTS ML --- drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 40d8620..ef7a521 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx, break; if (j != n) continue; - /* Find the first entry available. */ - for (j = 0; j != n; ++j) { - if (rte_is_zero_ether_addr(&mac_addrs[j])) { - mac_addrs[j] = macs[i]; - break; + if (rte_is_multicast_ether_addr(&macs[i])) { + /* Find the first entry available. */ + for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } + } + } else { + /* Find the first entry available. */ + for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } } } } -- 2.9.3.windows.1 Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.