* [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide
@ 2021-02-02 14:27 Viacheslav Ovsiienko
2021-02-02 15:37 ` Asaf Penso
2021-02-03 14:18 ` Raslan Darawsheh
0 siblings, 2 replies; 5+ messages in thread
From: Viacheslav Ovsiienko @ 2021-02-02 14:27 UTC (permalink / raw)
To: dev; +Cc: rasland, thomas, asafp, carsten.andrich, stable
The fixes:
- Buffer Split offload is supported/verified on ConnectX-5
- Tx scheduling requires ConnectX-6DX and depends on firmware version
Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5 guide")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
doc/guides/nics/mlx5.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index e99fea4342..6c8cb71ace 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1474,7 +1474,8 @@ Supported hardware offloads
Rx timestamp 17.11 4.14 16 4.2-1 12.21.1000 ConnectX-4
TSO 17.11 4.14 16 4.2-1 12.21.1000 ConnectX-4
LRO 19.08 N/A N/A 4.6-4 16.25.6406 ConnectX-5
- Buffer Split 20.11 N/A N/A 5.1-2 22.28.2006 ConnectX-6 Dx
+ Tx scheduling 20.08 N/A N/A 5.1-2 22.28.2006 ConnectX-6 Dx
+ Buffer Split 20.11 N/A N/A 5.1-2 16.28.2006 ConnectX-5
============== ===== ===== ========= ===== ========== =============
.. table:: Minimal SW/HW versions for rte_flow offloads
--
2.18.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide
2021-02-02 14:27 [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide Viacheslav Ovsiienko
@ 2021-02-02 15:37 ` Asaf Penso
2021-02-03 14:18 ` Raslan Darawsheh
1 sibling, 0 replies; 5+ messages in thread
From: Asaf Penso @ 2021-02-02 15:37 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Cc: Raslan Darawsheh, NBU-Contact-Thomas Monjalon, carsten.andrich, stable
Hi
>-----Original Message-----
>From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>Sent: Tuesday, February 2, 2021 4:28 PM
>To: dev@dpdk.org
>Cc: Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon
><thomas@monjalon.net>; Asaf Penso <asafp@nvidia.com>;
>carsten.andrich@tu-ilmenau.de; stable@dpdk.org
>Subject: [PATCH] doc: fix supported feature table in mlx5 guide
>
>The fixes:
>
>- Buffer Split offload is supported/verified on ConnectX-5
>- Tx scheduling requires ConnectX-6DX and depends on firmware version
>
>Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5 guide")
>Cc: stable@dpdk.org
>
>Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>
>---
> doc/guides/nics/mlx5.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
>e99fea4342..6c8cb71ace 100644
>--- a/doc/guides/nics/mlx5.rst
>+++ b/doc/guides/nics/mlx5.rst
>@@ -1474,7 +1474,8 @@ Supported hardware offloads
> Rx timestamp 17.11 4.14 16 4.2-1 12.21.1000 ConnectX-4
> TSO 17.11 4.14 16 4.2-1 12.21.1000 ConnectX-4
> LRO 19.08 N/A N/A 4.6-4 16.25.6406 ConnectX-5
>- Buffer Split 20.11 N/A N/A 5.1-2 22.28.2006 ConnectX-6 Dx
>+ Tx scheduling 20.08 N/A N/A 5.1-2 22.28.2006 ConnectX-6 Dx
>+ Buffer Split 20.11 N/A N/A 5.1-2 16.28.2006 ConnectX-5
> ============== ===== ===== ========= ===== ==========
>=============
>
> .. table:: Minimal SW/HW versions for rte_flow offloads
>--
>2.18.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide
2021-02-02 14:27 [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide Viacheslav Ovsiienko
2021-02-02 15:37 ` Asaf Penso
@ 2021-02-03 14:18 ` Raslan Darawsheh
2021-02-03 14:25 ` Slava Ovsiienko
1 sibling, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-02-03 14:18 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Cc: NBU-Contact-Thomas Monjalon, Asaf Penso, carsten.andrich, stable
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Tuesday, February 2, 2021 4:28 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Asaf Penso <asafp@nvidia.com>;
> carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> Subject: [PATCH] doc: fix supported feature table in mlx5 guide
>
> The fixes:
I'd replace this with something like following if it's OK with you and I can do it during integration,
This sets the correct minimal requirements for these feature:
>
> - Buffer Split offload is supported/verified on ConnectX-5
> - Tx scheduling requires ConnectX-6DX and depends on firmware version
>
> Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5 guide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
[..]
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide
2021-02-03 14:18 ` Raslan Darawsheh
@ 2021-02-03 14:25 ` Slava Ovsiienko
2021-02-03 14:27 ` Raslan Darawsheh
0 siblings, 1 reply; 5+ messages in thread
From: Slava Ovsiienko @ 2021-02-03 14:25 UTC (permalink / raw)
To: Raslan Darawsheh, dev
Cc: NBU-Contact-Thomas Monjalon, Asaf Penso, carsten.andrich, stable
> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Wednesday, February 3, 2021 16:19
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Asaf Penso
> <asafp@nvidia.com>; carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> Subject: RE: [PATCH] doc: fix supported feature table in mlx5 guide
>
> Hi,
>
> > -----Original Message-----
> > From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > Sent: Tuesday, February 2, 2021 4:28 PM
> > To: dev@dpdk.org
> > Cc: Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas
> Monjalon
> > <thomas@monjalon.net>; Asaf Penso <asafp@nvidia.com>;
> > carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> > Subject: [PATCH] doc: fix supported feature table in mlx5 guide
> >
> > The fixes:
> I'd replace this with something like following if it's OK with you and I can do
> it during integration,
>This sets the correct minimal requirements for these
> feature:
>
Just a typo: "these featureS"
I'm OK with the update, thank you.
With best regards,
Slava
> > - Buffer Split offload is supported/verified on ConnectX-5
> > - Tx scheduling requires ConnectX-6DX and depends on firmware version
> >
> > Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5
> > guide")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > ---
> > doc/guides/nics/mlx5.rst | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> [..]
>
> Kindest regards
> Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide
2021-02-03 14:25 ` Slava Ovsiienko
@ 2021-02-03 14:27 ` Raslan Darawsheh
0 siblings, 0 replies; 5+ messages in thread
From: Raslan Darawsheh @ 2021-02-03 14:27 UTC (permalink / raw)
To: Slava Ovsiienko, dev
Cc: NBU-Contact-Thomas Monjalon, Asaf Penso, carsten.andrich, stable
> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, February 3, 2021 4:25 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Asaf Penso
> <asafp@nvidia.com>; carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> Subject: RE: [PATCH] doc: fix supported feature table in mlx5 guide
>
> > -----Original Message-----
> > From: Raslan Darawsheh <rasland@nvidia.com>
> > Sent: Wednesday, February 3, 2021 16:19
> > To: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org
> > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Asaf Penso
> > <asafp@nvidia.com>; carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> > Subject: RE: [PATCH] doc: fix supported feature table in mlx5 guide
> >
> > Hi,
> >
> > > -----Original Message-----
> > > From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > > Sent: Tuesday, February 2, 2021 4:28 PM
> > > To: dev@dpdk.org
> > > Cc: Raslan Darawsheh <rasland@nvidia.com>; NBU-Contact-Thomas
> > Monjalon
> > > <thomas@monjalon.net>; Asaf Penso <asafp@nvidia.com>;
> > > carsten.andrich@tu-ilmenau.de; stable@dpdk.org
> > > Subject: [PATCH] doc: fix supported feature table in mlx5 guide
> > >
> > > The fixes:
> > I'd replace this with something like following if it's OK with you and I can do
> > it during integration,
> >This sets the correct minimal requirements for these
> > feature:
> >
> Just a typo: "these featureS"
Sure,
>
> I'm OK with the update, thank you.
>
> With best regards,
> Slava
>
> > > - Buffer Split offload is supported/verified on ConnectX-5
> > > - Tx scheduling requires ConnectX-6DX and depends on firmware version
> > >
> > > Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5
> > > guide")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > > ---
> > > doc/guides/nics/mlx5.rst | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > [..]
> >
> > Kindest regards
> > Raslan Darawsheh
Patch applied to next-net-mlx, with the small modification agreed above.
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-03 14:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 14:27 [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide Viacheslav Ovsiienko
2021-02-02 15:37 ` Asaf Penso
2021-02-03 14:18 ` Raslan Darawsheh
2021-02-03 14:25 ` Slava Ovsiienko
2021-02-03 14:27 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).