From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3132CA0A0E; Wed, 3 Feb 2021 14:59:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B800B2405B7; Wed, 3 Feb 2021 14:59:28 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 627182405B6 for ; Wed, 3 Feb 2021 14:59:27 +0100 (CET) IronPort-SDR: NIU2AcZ+ynEDGtbs278HjSPFVj6waLcXxr+kizBw8yUL0BqOaFATIeTAq1f+btxWB2ZAnDF1Rx 0kEDL8xOpZ9w== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="245117761" X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="245117761" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 05:59:25 -0800 IronPort-SDR: AnbESdYuOV9D4f+cajr0eqoGxA+h+0WLy3CBRo1oH05hDiyi3jpT5PRyaulvBPhb9Hhgy9/2J+ vwq9r1b6nLqQ== X-IronPort-AV: E=Sophos;i="5.79,398,1602572400"; d="scan'208";a="392448235" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.14]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Feb 2021 05:59:25 -0800 Date: Wed, 3 Feb 2021 13:59:21 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20210203135921.GB1708@bricha3-MOBL.ger.corp.intel.com> References: <20210203103057.2821352-1-thomas@monjalon.net> <20210203121812.GA1708@bricha3-MOBL.ger.corp.intel.com> <107491602.YXUHrCGqlC@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <107491602.YXUHrCGqlC@thomas> Subject: Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 03, 2021 at 01:53:58PM +0100, Thomas Monjalon wrote: > 03/02/2021 13:18, Bruce Richardson: > > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > > - https://raw.githubusercontent.com/codespell-project/codespell/master/codespell_lib/data/dictionary.txt > > > + git clone https://github.com/codespell-project/codespell.git > > > > > > > Does installing via apt or dnf work as well? If we do install from package > > do we still need to specify the path to codespell as script parameter? > > It depends whether all needed dictionary files are installed. Are they? > > > > -The path to the downloaded ``dictionary.txt`` must be set > > > +There is a DPDK script to build an adjusted dictionary:: > > > + > > > + devtools/build-dict.sh codespell/ > codespell-dpdk.txt > > > + > > > > Do we always need to have people build this themselves? Can we create a > > .codespell-dpdk.txt file in the repo and have that as the default value for > > the path if the environment variable is not set? > > The dictionaries are frequently updated. > I don't really want to update them in DPDK. > > The default dictionary from the distro is used by default (if installed). > > In general, I think only tree maintainers and CI admins > have to install the dictionaries for better result. > That's good. Perhaps it's better to note down then first that the default distro dictionaries are used and if one wants enhanced checking to follow the extra steps. /Bruce