* [dpdk-dev] [PATCH v1] net/ice: fix QinQ switch rule input set mask
@ 2021-02-04 6:07 Yuying Zhang
2021-02-04 8:06 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Yuying Zhang @ 2021-02-04 6:07 UTC (permalink / raw)
To: dev, qi.z.zhang, haiyue.wang; +Cc: qi.fu, Yuying Zhang
QinQ switch rule doesn't support ethertype field match.
QinQ ethertype pattern should not be created. Change the
input set mask to fix the issue.
Fixes: bb3386f348dd ("net/ice: enable QinQ filter for switch")
Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
drivers/net/ice/ice_switch_filter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 5ca0985e21..6525e6c115 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -38,7 +38,8 @@
ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE | \
ICE_INSET_VLAN_INNER)
#define ICE_SW_INSET_MAC_QINQ ( \
- ICE_SW_INSET_MAC_VLAN | ICE_INSET_VLAN_OUTER)
+ ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_VLAN_INNER | \
+ ICE_INSET_VLAN_OUTER)
#define ICE_SW_INSET_MAC_IPV4 ( \
ICE_INSET_DMAC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_SRC | \
ICE_INSET_IPV4_PROTO | ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_TOS)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH v1] net/ice: fix QinQ switch rule input set mask
2021-02-04 6:07 [dpdk-dev] [PATCH v1] net/ice: fix QinQ switch rule input set mask Yuying Zhang
@ 2021-02-04 8:06 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-02-04 8:06 UTC (permalink / raw)
To: Zhang, Yuying, dev, Wang, Haiyue; +Cc: Fu, Qi
> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Thursday, February 4, 2021 2:08 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Cc: Fu, Qi <qi.fu@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
> Subject: [PATCH v1] net/ice: fix QinQ switch rule input set mask
>
> QinQ switch rule doesn't support ethertype field match.
> QinQ ethertype pattern should not be created. Change the input set mask to
> fix the issue.
>
> Fixes: bb3386f348dd ("net/ice: enable QinQ filter for switch")
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 8:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 6:07 [dpdk-dev] [PATCH v1] net/ice: fix QinQ switch rule input set mask Yuying Zhang
2021-02-04 8:06 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).