From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0838A0524; Thu, 4 Feb 2021 21:37:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1696E2407EC; Thu, 4 Feb 2021 21:37:22 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 693032407D2 for ; Thu, 4 Feb 2021 21:37:21 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id q72so2377299pjq.2 for ; Thu, 04 Feb 2021 12:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id; bh=6odNgLQH8OqGUY4b5+7Kfa0lvdJRWefguC+jClJuF1o=; b=i0ieYfU1mzmLpyvIh0yXak/D02eNHf+kv4yDX6fgqCY2dNy2HGCm4GwZX6eIL55qxg Ys8JLbZu/fgpc+u9gETzDEhXUfOmZu3NDq6kGvQ7U5BGBWjTHT8Bh5/6vuQAokFwf2RY +N9qeoNC+ElRi/pXquyJx/t2NlgyVcayEnWkSaukb6t9xLY6wrDXftE82VNy4IOLrxQU TmBWgd/kWp9eeu9KCHOiPnQnJ1e0fA0arX3rU9sp4OJqSdJdkc51YXLAaQiTjUDgE7aZ W5vd9Rt2aNvcE9q6t/nqJvBTXrLAqd6Ve+cFyXackB0ETXORZr8DAIIs4FH9cuQa8xVM m1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6odNgLQH8OqGUY4b5+7Kfa0lvdJRWefguC+jClJuF1o=; b=nC+GjFd8FXJxt7mlAGSO2Eb8x5Jfk1HEcdeDLAXP5m48E30PtoX6Ch2hQbvnC7wWg1 AdMEK2oGAvlv6iNHxXaCDIYIoKzSiOLy+7FRZOYLGpCkHkWL5zzHewv1VYHM13s96Nsp OVjo1EmbYsRd+Pekz6miaujZ3x50YERlwVXSRtEgflhMI/kudCdkJEYH3hPshi+WaGPu 3jKyt+hP2cVl/6mF0IyNu8lLiZdESPyGl8semShx5Y8E3bwdRirKi8eIonApg88jxAY4 wjx3xoLSP1S+T3/x4AzoE2TNi0ssuPDVPchCQNjq1zq4DhEQpkus+EDhKSHKrnfR5NsX IPSA== X-Gm-Message-State: AOAM533FuKKLhpQFIky4wAEqU/JfUajzCwYnS7qCT10oAOvcQqWVZnmd pUftPyHqR8/dnZ9fnbkJgL8bepKYwhw+BQ== X-Google-Smtp-Source: ABdhPJwcXUBDqr381MlO3dIEzMjGMd/d5zcgF6TXFX+mSYMr4x3HZvg8o8IEZ0uIA1Lih80CDPra4A== X-Received: by 2002:a17:90b:1996:: with SMTP id mv22mr712040pjb.121.1612471040414; Thu, 04 Feb 2021 12:37:20 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id v23sm5122463pgo.43.2021.02.04.12.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 12:37:19 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Thu, 4 Feb 2021 12:37:10 -0800 Message-Id: <20210204203710.34690-1-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ionic: fix Tx fragment limits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The reported nb_seg_max should include the main fragment in the descriptor and the fragments in the accompanying SGL. Update the Tx prep check as well. These were missed when updating to the v1 Tx queue structures. Fixes: 786c64763b50 ("net/ionic: clean up Tx queue version support") Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 4 ++-- drivers/net/ionic/ionic_rxtx.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index c9d8493f49..cffe899c07 100644 --- a/drivers/net/ionic/ionic_ethdev.c +++ b/drivers/net/ionic/ionic_ethdev.c @@ -74,8 +74,8 @@ static const struct rte_eth_desc_lim tx_desc_lim_v1 = { .nb_max = IONIC_MAX_RING_DESC, .nb_min = IONIC_MIN_RING_DESC, .nb_align = 1, - .nb_seg_max = IONIC_TX_MAX_SG_ELEMS_V1, - .nb_mtu_seg_max = IONIC_TX_MAX_SG_ELEMS_V1, + .nb_seg_max = IONIC_TX_MAX_SG_ELEMS_V1 + 1, + .nb_mtu_seg_max = IONIC_TX_MAX_SG_ELEMS_V1 + 1, }; static const struct eth_dev_ops ionic_eth_dev_ops = { diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 5ae9ecf400..99920109eb 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -596,7 +596,7 @@ ionic_prep_pkts(void *tx_queue __rte_unused, struct rte_mbuf **tx_pkts, for (i = 0; i < nb_pkts; i++) { txm = tx_pkts[i]; - if (txm->nb_segs > IONIC_TX_MAX_SG_ELEMS) { + if (txm->nb_segs > IONIC_TX_MAX_SG_ELEMS_V1 + 1) { rte_errno = -EINVAL; break; } -- 2.17.1