From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D561A0524; Fri, 5 Feb 2021 10:42:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF8CA1606BB; Fri, 5 Feb 2021 10:42:57 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B461940682 for ; Fri, 5 Feb 2021 10:42:55 +0100 (CET) IronPort-SDR: mcEe8D0aspuXXzWrQqEvGnU1WlbK4jr/OdOhTSCJOs7+KQW6n85paWyVtEIzIiuOkflSWED/FP RDt/R62YbYJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="178848313" X-IronPort-AV: E=Sophos;i="5.81,154,1610438400"; d="scan'208";a="178848313" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 01:42:53 -0800 IronPort-SDR: c7SE7/ZzeWrYS7bsYBgl5XfdNArEPlQn9qyBj3r2Ew3RLvqQbUo4uLZxuyFnMINu1u94HAfHjt VbJse9OsH3OA== X-IronPort-AV: E=Sophos;i="5.81,154,1610438400"; d="scan'208";a="393783421" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.143]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Feb 2021 01:42:51 -0800 Date: Fri, 5 Feb 2021 09:42:48 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: "thomas@monjalon.net" , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" Message-ID: <20210205094248.GB1462@bricha3-MOBL.ger.corp.intel.com> References: <1611916159-32158-1-git-send-email-juraj.linkes@pantheon.tech> <1612432301-14961-1-git-send-email-juraj.linkes@pantheon.tech> <20210204173352.GE1712@bricha3-MOBL.ger.corp.intel.com> <0055021693274b0caf0b542bbefd0715@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0055021693274b0caf0b542bbefd0715@pantheon.tech> Subject: Re: [dpdk-dev] [RFC PATCH v2] build: kni cross-compilation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 05, 2021 at 09:26:05AM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Thursday, February 4, 2021 6:34 PM > > To: Juraj Linkeš > > Cc: thomas@monjalon.net; Ruifeng.Wang@arm.com; > > Honnappa.Nagarahalli@arm.com; jerinjacobk@gmail.com; > > hemant.agrawal@nxp.com; ferruh.yigit@intel.com; aboyer@pensando.io; > > dev@dpdk.org > > Subject: Re: [RFC PATCH v2] build: kni cross-compilation support > > > > On Thu, Feb 04, 2021 at 10:51:41AM +0100, Juraj Linkeš wrote: > > > The kni linux module is using a custom target for building, which > > > doesn't take into account any cross compilation arguments. The > > > arguments in question are ARCH, CROSS_COMPILE (for gcc, clang) and CC, > > > LD (for clang). Get those from the cross file and pass them to the > > > custom target. > > > > > > The user supplied path may not contain the 'build' directory, such as > > > when using cross-compiled headers, so only append that in the default > > > case (when no path is supplied in native builds) and use the > > > unmodified path from the user otherwise. Also modify the install path > > accordingly. > > > > > > Signed-off-by: Juraj Linkeš > > > > Some comments inline below. > > > > Thanks, these are very helpful. > > > > + install_dir = '' > > > + install = false > > > > I think these should be defined and initialized further up the file, outside the > > conditional block. > > > > Ok, I'll make the default true and set it to false in the cross compilation case. > Can you just initialize the value to !meson.is_cross_build() and leave it at that?