[dpdk-dev] [PATCH] telemetry: mark init function as internal-only

[dpdk-dev] [PATCH] telemetry: mark init function as internal-only

[Bruce Richardson]

The "rte_telemetry_init()" function is for use by "rte_eal_init()" and
should not be part of the public API. Mark it as internal only.

Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 doc/guides/rel_notes/release_21_02.rst | 5 +++++
 lib/librte_telemetry/rte_telemetry.h   | 2 +-
 lib/librte_telemetry/version.map       | 5 ++++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index baf32151f..84b04a018 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -266,6 +266,11 @@ ABI Changes
 
 * No ABI change that would break compatibility with 20.11.
 
+* The experimental function ``rte_telemetry_init`` has been removed from the
+  public API and is now an internal-only function. Where telemetry library is
+  available, it is called automatically from ``rte_eal_init()`` and so no end
+  application need use it.
+
 
 Known Issues
 ------------
diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h
index f6c3992a9..f7c8534b8 100644
--- a/lib/librte_telemetry/rte_telemetry.h
+++ b/lib/librte_telemetry/rte_telemetry.h
@@ -309,7 +309,7 @@ rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help);
  * @return
  *  -1 on failure.
  */
-__rte_experimental
+__rte_internal
 int
 rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,
 		const char **err_str);
diff --git a/lib/librte_telemetry/version.map b/lib/librte_telemetry/version.map
index d1dbf8d58..ec0ebc1be 100644
--- a/lib/librte_telemetry/version.map
+++ b/lib/librte_telemetry/version.map
@@ -14,9 +14,12 @@ EXPERIMENTAL {
 	rte_tel_data_start_array;
 	rte_tel_data_start_dict;
 	rte_tel_data_string;
-	rte_telemetry_init;
 	rte_telemetry_legacy_register;
 	rte_telemetry_register_cmd;
 
 	local: *;
 };
+
+INTERNAL {
+	rte_telemetry_init;
+};
-- 
2.27.0

Re: [dpdk-dev] [PATCH] telemetry: mark init function as internal-only

[Thomas Monjalon]

05/02/2021 22:23, Bruce Richardson:
> The "rte_telemetry_init()" function is for use by "rte_eal_init()" and
> should not be part of the public API. Mark it as internal only.
> 
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks