From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A37A9A0524; Fri, 5 Feb 2021 22:26:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0175622A1F4; Fri, 5 Feb 2021 22:26:15 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 186624067B; Fri, 5 Feb 2021 22:26:12 +0100 (CET) IronPort-SDR: e4bCcI4YvgTEWkoAbOiiJiM39AdaeycSoZynMsiThJh4hknBLMJBcA1ipHs5PUb9/BGoE5m6GG NF2PMd+F97qA== X-IronPort-AV: E=McAfee;i="6000,8403,9886"; a="242993779" X-IronPort-AV: E=Sophos;i="5.81,156,1610438400"; d="scan'208";a="242993779" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2021 13:26:12 -0800 IronPort-SDR: myjc5hYh78TX6D2UPtlYGlmiIX4Jg2ypqzSrT5gWTBebYRnW8lUEcBEYBxYsq4fTvs8Bhc1q3w e9w0+sL+ligg== X-IronPort-AV: E=Sophos;i="5.81,156,1610438400"; d="scan'208";a="394019679" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.23.143]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 05 Feb 2021 13:26:10 -0800 Date: Fri, 5 Feb 2021 21:26:06 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org, Ray Kinsella , Neil Horman , Kevin Laatz Message-ID: <20210205212606.GA1479@bricha3-MOBL.ger.corp.intel.com> References: <20210205193933.410011-1-bruce.richardson@intel.com> <1695007.lsEMqjsl9x@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1695007.lsEMqjsl9x@thomas> Subject: Re: [dpdk-dev] [PATCH] eal: fix querying DPDK version at runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote: > 05/02/2021 20:39, Bruce Richardson: > > For using a DPDK application, such as OVS, which is dynamically linked, the > > DPDK version in use should always report the actual version, not the > > version used at build time. This incorrect behaviour can be seen by > > building OVS against one version of DPDK and running it against a later > > one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the > > dpdk_version returned will be the build version not the currently running > > one - which can be verified using the DPDK telemetry library client. > > > > $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version > > dpdk_version : "DPDK 20.11.0-rc4" > > > > $ echo quit | sudo dpdk-telemetry.py > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > > {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384} > > Nice demonstration. > > > __rte_experimental > > int > > -rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset, > > +rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, > > const char **err_str); > > It is changing the API. > As it is experimental, you just need to mention it in the release notes. I don't think I actually need to mention it there, because this API is more "INTERNAL" than "EXPERIMENTAL". It's called automatically from rte_eal_init(). I've done up patch http://patches.dpdk.org/patch/87806/ to correct this, including a RN addition. That should remove the need for a doc update for this patch. > > It is the fix. Do you think it should be merged quickly? > Or wait for 21.05? > I'm not sure either way to be honest. Given the bug has been around so long, it's not exactly urgent. On the other hand, to get the fix the user needs to rebuild their app, so having it sooner is nicer, and will mean it would make the next LTS point release. Overall, though, I'm fine whichever you decide. /Bruce