From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCB72A0547; Tue, 9 Feb 2021 13:39:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D75240693; Tue, 9 Feb 2021 13:39:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1EBBD4014E for ; Tue, 9 Feb 2021 13:39:21 +0100 (CET) IronPort-SDR: 2qwYpyBkES4OcYUrMEZd2uHJBAtTUU5+W2jquAPDAdaQ9w4qaGW8n5Ssd1hO2j2Ymizpy/m4Ru JE2kf/zx9Thw== X-IronPort-AV: E=McAfee;i="6000,8403,9889"; a="161621760" X-IronPort-AV: E=Sophos;i="5.81,164,1610438400"; d="scan'208";a="161621760" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 04:39:21 -0800 IronPort-SDR: LWXdSfwqhLOhMyPinIzFD3xaND5knY6cmmAvLl8NtP4mELtWPusWZrHbjtERHRCgLULafu71lz mmAHr+H1hL5w== X-IronPort-AV: E=Sophos;i="5.81,164,1610438400"; d="scan'208";a="396104329" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.24.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Feb 2021 04:39:18 -0800 Date: Tue, 9 Feb 2021 12:39:15 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: "thomas@monjalon.net" , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" Message-ID: <20210209123915.GD1208@bricha3-MOBL.ger.corp.intel.com> References: <1612537472-18192-1-git-send-email-juraj.linkes@pantheon.tech> <1612860425-27646-1-git-send-email-juraj.linkes@pantheon.tech> <20210209115059.GA1208@bricha3-MOBL.ger.corp.intel.com> <3b4b24d6de064419a6c7e8403b12e1c1@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b4b24d6de064419a6c7e8403b12e1c1@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH v5] build: kni cross-compilation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 09, 2021 at 12:07:13PM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, February 9, 2021 12:51 PM > > To: Juraj Linkeš > > Cc: thomas@monjalon.net; Ruifeng.Wang@arm.com; > > Honnappa.Nagarahalli@arm.com; jerinjacobk@gmail.com; > > hemant.agrawal@nxp.com; ferruh.yigit@intel.com; aboyer@pensando.io; > > dev@dpdk.org > > Subject: Re: [PATCH v5] build: kni cross-compilation support > > > > > + description: 'Path to the kernel for building kernel modules. > > > +Headers must be in $kernel_dir. Modules will be installed in > > > +/lib/modules/$(uname -r)/extra/dpdk for native builds.') > > > > While correct, the last sentence isn't really relevant to the build option, it's more > > an additional note, and it seems a bit awkward. Maybe it can be shortened by > > referencing "/lib/modules" rather than giving the full path. > > Alternatively, maybe just putting the details in the documentation is a better > > plan, and leaving the comment here as just "path to the kernel for building > > kernel modules". > > > > Having it in docs would be better, but where exactly? I tried looking, but didn't find a suitable place. > It probably should go in the GSG doc, but I agree that there is nowhere obvious for it. I think we could do with the addition of some descriptions of the various options in the GSG, but that is out of the scope of this patch.