From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup
Date: Thu, 11 Feb 2021 08:23:45 -0800 [thread overview]
Message-ID: <20210211082345.03ad1cc4@hermes.local> (raw)
In-Reply-To: <ccc9efa8619cb4a1f852e1ca8801a17266fc0d02.1600088628.git.anatoly.burakov@intel.com>
On Mon, 14 Sep 2020 14:04:05 +0100
Anatoly Burakov <anatoly.burakov@intel.com> wrote:
> Currently, we don't detach the shared memory on EAL cleanup, which
> leaves the page table descriptors still holding on to the file
> descriptors as well as memory space occupied by them. Fix it by adding
> another detach stage that closes the internal memory allocator resource
> references, detaches shared fbarrays and unmaps the shared mem config.
>
> Bugzilla ID: 380
> Bugzilla ID: 381
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Sure looks good. We should put more tests of cleanup
in the test suite.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Sorry for the late response been stuck in internal project stuff.
next prev parent reply other threads:[~2021-02-11 16:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:18 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-09-14 11:26 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-09-14 11:45 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2020-09-14 13:04 ` [dpdk-dev] [PATCH v4] " Anatoly Burakov
2020-10-15 9:54 ` Burakov, Anatoly
2020-10-20 11:53 ` Thomas Monjalon
2020-11-22 18:16 ` Thomas Monjalon
2020-11-27 12:56 ` Burakov, Anatoly
2020-11-27 13:21 ` Thomas Monjalon
2021-02-11 10:53 ` Burakov, Anatoly
2021-02-11 16:23 ` Stephen Hemminger [this message]
2021-03-03 9:04 ` David Marchand
2021-02-11 13:33 ` [dpdk-dev] [PATCH v2] " Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211082345.03ad1cc4@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).