From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: dev@dpdk.org, ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH v2 19/20] bus/dpaa: support shared ethernet MAC interface
Date: Thu, 11 Feb 2021 19:46:19 +0530 [thread overview]
Message-ID: <20210211141620.12482-20-hemant.agrawal@nxp.com> (raw)
In-Reply-To: <20210211141620.12482-1-hemant.agrawal@nxp.com>
From: Nipun Gupta <nipun.gupta@nxp.com>
DPAA can share an interface on classification criteria with kernel.
This patch enables default kernel driver to be used as a shared MAC
interface with DPDK interface. (provided that VSP is enabled on that
interface.)
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
drivers/bus/dpaa/base/fman/fman.c | 149 +++++++++++++++++++++---------
1 file changed, 105 insertions(+), 44 deletions(-)
diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c
index 39102bc1f3..692071b4b0 100644
--- a/drivers/bus/dpaa/base/fman/fman.c
+++ b/drivers/bus/dpaa/base/fman/fman.c
@@ -211,12 +211,16 @@ fman_if_init(const struct device_node *dpa_node)
const phandle *mac_phandle, *ports_phandle, *pools_phandle;
const phandle *tx_channel_id = NULL, *mac_addr, *cell_idx;
const phandle *rx_phandle, *tx_phandle;
+ const phandle *port_cell_idx, *ext_args_cell_idx;
+ const struct device_node *parent_node_ext_args;
uint64_t tx_phandle_host[4] = {0};
uint64_t rx_phandle_host[4] = {0};
uint64_t regs_addr_host = 0;
uint64_t cell_idx_host = 0;
+ uint64_t port_cell_idx_val = 0;
+ uint64_t ext_args_cell_idx_val = 0;
- const struct device_node *mac_node = NULL, *tx_node;
+ const struct device_node *mac_node = NULL, *tx_node, *ext_args_node;
const struct device_node *pool_node, *fman_node, *rx_node;
const uint32_t *regs_addr = NULL;
const char *mname, *fname;
@@ -230,16 +234,112 @@ fman_if_init(const struct device_node *dpa_node)
return 0;
if (!of_device_is_compatible(dpa_node, "fsl,dpa-ethernet-init") &&
- !of_device_is_compatible(dpa_node, "fsl,dpa-ethernet-shared")) {
+ !of_device_is_compatible(dpa_node, "fsl,dpa-ethernet")) {
return 0;
}
- if (of_device_is_compatible(dpa_node, "fsl,dpa-ethernet-shared"))
- is_shared = 1;
-
rprop = "fsl,qman-frame-queues-rx";
mprop = "fsl,fman-mac";
+ /* Obtain the MAC node used by this interface except macless */
+ mac_phandle = of_get_property(dpa_node, mprop, &lenp);
+ if (!mac_phandle) {
+ FMAN_ERR(-EINVAL, "%s: no %s\n", dname, mprop);
+ return -EINVAL;
+ }
+ assert(lenp == sizeof(phandle));
+ mac_node = of_find_node_by_phandle(*mac_phandle);
+ if (!mac_node) {
+ FMAN_ERR(-ENXIO, "%s: bad 'fsl,fman-mac\n", dname);
+ return -ENXIO;
+ }
+ mname = mac_node->full_name;
+
+ /* Extract the Rx and Tx ports */
+ ports_phandle = of_get_property(mac_node, "fsl,port-handles",
+ &lenp);
+ if (!ports_phandle)
+ ports_phandle = of_get_property(mac_node, "fsl,fman-ports",
+ &lenp);
+ if (!ports_phandle) {
+ FMAN_ERR(-EINVAL, "%s: no fsl,port-handles\n",
+ mname);
+ return -EINVAL;
+ }
+ assert(lenp == (2 * sizeof(phandle)));
+ rx_node = of_find_node_by_phandle(ports_phandle[0]);
+ if (!rx_node) {
+ FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[0]\n", mname);
+ return -ENXIO;
+ }
+ tx_node = of_find_node_by_phandle(ports_phandle[1]);
+ if (!tx_node) {
+ FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[1]\n", mname);
+ return -ENXIO;
+ }
+
+ /* Check if the port is shared interface */
+ if (of_device_is_compatible(dpa_node, "fsl,dpa-ethernet")) {
+ port_cell_idx = of_get_property(rx_node, "cell-index", &lenp);
+ if (!port_cell_idx) {
+ FMAN_ERR(-ENXIO,
+ "%s: no cell-index for port\n", mname);
+ return -ENXIO;
+ }
+ assert(lenp == sizeof(*port_cell_idx));
+ port_cell_idx_val =
+ of_read_number(port_cell_idx, lenp / sizeof(phandle));
+
+ if (of_device_is_compatible(rx_node, "fsl,fman-port-1g-rx"))
+ port_cell_idx_val -= 0x8;
+ else if (of_device_is_compatible(
+ rx_node, "fsl,fman-port-10g-rx"))
+ port_cell_idx_val -= 0x10;
+
+ parent_node_ext_args = of_find_compatible_node(NULL,
+ NULL, "fsl,fman-extended-args");
+ if (!parent_node_ext_args)
+ return 0;
+
+ for_each_child_node(parent_node_ext_args, ext_args_node) {
+ ext_args_cell_idx = of_get_property(ext_args_node,
+ "cell-index", &lenp);
+ if (!ext_args_cell_idx) {
+ FMAN_ERR(-ENXIO,
+ "%s: no cell-index for ext args\n",
+ mname);
+ return -ENXIO;
+ }
+ assert(lenp == sizeof(*ext_args_cell_idx));
+ ext_args_cell_idx_val =
+ of_read_number(ext_args_cell_idx, lenp /
+ sizeof(phandle));
+
+ if (port_cell_idx_val == ext_args_cell_idx_val) {
+ if (of_device_is_compatible(ext_args_node,
+ "fsl,fman-port-1g-rx-extended-args") &&
+ of_device_is_compatible(rx_node,
+ "fsl,fman-port-1g-rx")) {
+ if (of_get_property(ext_args_node,
+ "vsp-window", &lenp))
+ is_shared = 1;
+ break;
+ }
+ if (of_device_is_compatible(ext_args_node,
+ "fsl,fman-port-10g-rx-extended-args") &&
+ of_device_is_compatible(rx_node,
+ "fsl,fman-port-10g-rx")) {
+ if (of_get_property(ext_args_node,
+ "vsp-window", &lenp))
+ is_shared = 1;
+ break;
+ }
+ }
+ }
+ if (!is_shared)
+ return 0;
+ }
+
/* Allocate an object for this network interface */
__if = rte_malloc(NULL, sizeof(*__if), RTE_CACHE_LINE_SIZE);
if (!__if) {
@@ -253,20 +353,6 @@ fman_if_init(const struct device_node *dpa_node)
strlcpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
__if->node_path[PATH_MAX - 1] = '\0';
- /* Obtain the MAC node used by this interface except macless */
- mac_phandle = of_get_property(dpa_node, mprop, &lenp);
- if (!mac_phandle) {
- FMAN_ERR(-EINVAL, "%s: no %s\n", dname, mprop);
- goto err;
- }
- assert(lenp == sizeof(phandle));
- mac_node = of_find_node_by_phandle(*mac_phandle);
- if (!mac_node) {
- FMAN_ERR(-ENXIO, "%s: bad 'fsl,fman-mac\n", dname);
- goto err;
- }
- mname = mac_node->full_name;
-
/* Map the CCSR regs for the MAC node */
regs_addr = of_get_address(mac_node, 0, &__if->regs_size, NULL);
if (!regs_addr) {
@@ -290,7 +376,6 @@ fman_if_init(const struct device_node *dpa_node)
/* Get rid of endianness (issues). Convert to host byte order */
regs_addr_host = of_read_number(regs_addr, na);
-
/* Get the index of the Fman this i/f belongs to */
fman_node = of_get_parent(mac_node);
na = of_n_addr_cells(mac_node);
@@ -384,25 +469,6 @@ fman_if_init(const struct device_node *dpa_node)
}
memcpy(&__if->__if.mac_addr, mac_addr, ETHER_ADDR_LEN);
- /* Extract the Tx port (it's the second of the two port handles)
- * and get its channel ID
- */
- ports_phandle = of_get_property(mac_node, "fsl,port-handles",
- &lenp);
- if (!ports_phandle)
- ports_phandle = of_get_property(mac_node, "fsl,fman-ports",
- &lenp);
- if (!ports_phandle) {
- FMAN_ERR(-EINVAL, "%s: no fsl,port-handles\n",
- mname);
- goto err;
- }
- assert(lenp == (2 * sizeof(phandle)));
- tx_node = of_find_node_by_phandle(ports_phandle[1]);
- if (!tx_node) {
- FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[1]\n", mname);
- goto err;
- }
/* Extract the channel ID (from tx-port-handle) */
tx_channel_id = of_get_property(tx_node, "fsl,qman-channel-id",
&lenp);
@@ -412,11 +478,6 @@ fman_if_init(const struct device_node *dpa_node)
goto err;
}
- rx_node = of_find_node_by_phandle(ports_phandle[0]);
- if (!rx_node) {
- FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[0]\n", mname);
- goto err;
- }
regs_addr = of_get_address(rx_node, 0, &__if->regs_size, NULL);
if (!regs_addr) {
FMAN_ERR(-EINVAL, "of_get_address(%s)\n", mname);
--
2.17.1
next prev parent reply other threads:[~2021-02-11 14:30 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 14:27 [dpdk-dev] [PATCH 0/7] NXP DPAAx ethernet PMD changes Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 1/7] bus/fslmc: fix to use ci value for qbman 5.0 Hemant Agrawal
2021-02-02 11:36 ` Ferruh Yigit
2021-02-04 12:42 ` Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 2/7] net/dpaa2: fix link get API implementation Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 3/7] net/dpaa2: allocate SGT table from first segment Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 4/7] net/dpaa2: support external buffers in Tx Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 5/7] net/dpaa: " Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 6/7] net/dpaa2: add traffic management driver Hemant Agrawal
2021-02-02 11:41 ` Ferruh Yigit
2021-02-04 10:47 ` Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len Hemant Agrawal
2021-02-02 11:38 ` Ferruh Yigit
2021-02-04 10:46 ` Hemant Agrawal
2021-01-20 14:27 ` [dpdk-dev] [PATCH 0/7] NXP DPAAx ethernet PMD changes Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 00/20] " Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 01/20] bus/fslmc: fix to use ci value for qbman 5.0 Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 02/20] bus/dpaa: fix statistics reading Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 03/20] net/dpaa2: fix link get API implementation Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 04/20] net/dpaa: " Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 05/20] net/dpaa2: allocate SGT table from first segment Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 06/20] net/dpaa2: support external buffers in Tx Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 07/20] net/dpaa: " Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 08/20] net/dpaa2: add traffic management driver Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 09/20] net/dpaa2: add support to configure dpdmux max Rx frame len Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 10/20] net/dpaa2: add support for raw pattern in dpdmux Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 11/20] net/dpaa2: dpdmux skip reset Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 12/20] net/dpaa2: support dpdmux to not drop parse err pkts Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 13/20] net/dpaa2: add device args for enable Tx confirmation Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 14/20] net/dpaa2: optionally enable error queues Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 15/20] mempool/dpaa2: support stats for secondary process Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 16/20] net/dpaa: do not release the cgr ranges Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 17/20] net/dpaa: prevent multiple mp config on an device Hemant Agrawal
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 18/20] bus/dpaa: secondary process init support Hemant Agrawal
2021-02-11 14:16 ` Hemant Agrawal [this message]
2021-02-11 14:16 ` [dpdk-dev] [PATCH v2 20/20] bus/dpaa: enhance checks for bus and device detection Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 00/23] NXP DPAAx ethernet PMD changes Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 01/23] bus/fslmc: fix to use ci value for qbman 5.0 Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 02/23] bus/dpaa: fix statistics reading Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 03/23] net/dpaa2: fix link get API implementation Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 04/23] net/dpaa: " Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 05/23] net/dpaa2: allocate SGT table from first segment Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 06/23] net/dpaa2: support external buffers in Tx Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 07/23] net/dpaa: " Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 08/23] net/dpaa2: add traffic management driver Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 09/23] net/dpaa2: add support to configure dpdmux max Rx frame len Hemant Agrawal
2021-02-24 17:22 ` Ferruh Yigit
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 10/23] net/dpaa2: add support for raw pattern in dpdmux Hemant Agrawal
2021-02-24 12:42 ` [dpdk-dev] [PATCH v3 11/23] net/dpaa2: dpdmux skip reset Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 12/23] net/dpaa2: support dpdmux to not drop parse err pkts Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 13/23] net/dpaa2: add device args for enable Tx confirmation Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 14/23] net/dpaa2: optionally enable error queues Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 15/23] net/dpaa2: change Tx queue congestion settings Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 16/23] mempool/dpaa2: support stats for secondary process Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 17/23] net/dpaa: do not release the cgr ranges Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 18/23] net/dpaa: prevent multiple mp config on an device Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 19/23] bus/dpaa: secondary process init support Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 20/23] bus/dpaa: support shared ethernet MAC interface Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 21/23] bus/dpaa: enhance checks for bus and device detection Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 22/23] net/dpaa2: add Rx buf size support Hemant Agrawal
2021-02-24 12:43 ` [dpdk-dev] [PATCH v3 23/23] net/dpaa: " Hemant Agrawal
2021-02-24 17:23 ` [dpdk-dev] [PATCH v3 00/23] NXP DPAAx ethernet PMD changes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211141620.12482-20-hemant.agrawal@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).